public inbox for cygwin@cygwin.com
 help / color / mirror / Atom feed
From: Corinna Vinschen <corinna-cygwin@cygwin.com>
To: Takashi Yano <takashi.yano@nifty.ne.jp>
Cc: cygwin@cygwin.com
Subject: Re: cygwin snapshots after 23, Feb. ocasionally destroys windows logon session
Date: Mon, 04 Mar 2019 16:39:00 -0000	[thread overview]
Message-ID: <20190304163857.GI3785@calimero.vinschen.de> (raw)
In-Reply-To: <20190304160630.GH3785@calimero.vinschen.de>

[-- Attachment #1: Type: text/plain, Size: 1766 bytes --]

On Mar  4 17:06, Corinna Vinschen wrote:
> On Mar  4 16:57, Corinna Vinschen wrote:
> > On Mar  5 00:28, Takashi Yano wrote:
> > > Hi Corinna,
> > > 
> > > I encountered a problem with cygwin snapshots after 23, Feb.
> > > If I login to cygwin via ssh and logout from ssh session,
> > > explorer sometimes gets into erroneous state. Most of
> > > operations cannot be done on explorer.
> > > [...]
> 
> FTR, I just reproduced it after the fifth logon/logoff in a row
> on W10 64 bit w/ 64 bit Cygwin.
> 
> > > To reproduce this, logon windows with a user and start
> > > cygwin. Then, repeat login and logout via cygwin ssh/sshd
> > > a few ten times with the user who logon to windows.
> > > [...]
> > > Is this code really necessary?
> > 
> > It's probably not necessary, at least we hadn't had anything like that
> > before.  As you can see from commits 71b8777a7140, 8eee25241e86,
> > dd3730ed9c1c and bcb33dc4f055, the idea is to unload a user profile if
> > it's not used anymore.
> > 
> > I'm puzzled that calling UnloadUserProfile should actually unload a user
> > profile if it's still in use by the interactive session.  That sounds
> > like a bug in Windows to me, but what do I know?
> > 
> > I can revert this single patch, or I can revert the above patchset
> > trying to unload a user profile entirely, whatever makes more sense.
> > 
> > However, what makes most sense?!?

I reverted the entire patchset and uploaded new developer snapshots
to https://cygwin.com/snapshots/.

Incidentally, Microsoft's OpenSSH port calls LoadUserProfile, but it
never calls UnloadUserProfile.  I guess they know why.

It seemed like a good idea at the time...


Thanks,
Corinna

-- 
Corinna Vinschen
Cygwin Maintainer

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2019-03-04 16:39 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-04 15:28 Takashi Yano
2019-03-04 15:57 ` Corinna Vinschen
2019-03-04 16:06   ` Corinna Vinschen
2019-03-04 16:39     ` Corinna Vinschen [this message]
2019-03-04 17:26       ` Bill Stewart
2019-03-05 12:16       ` Takashi Yano
2019-03-05 12:46         ` Corinna Vinschen
2019-03-04 18:10 ` Achim Gratz
2019-03-04 19:35   ` Andrey Repin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190304163857.GI3785@calimero.vinschen.de \
    --to=corinna-cygwin@cygwin.com \
    --cc=cygwin@cygwin.com \
    --cc=takashi.yano@nifty.ne.jp \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).