From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 89459 invoked by alias); 22 Jul 2019 16:45:37 -0000 Mailing-List: contact cygwin-help@cygwin.com; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: cygwin-owner@cygwin.com Mail-Followup-To: cygwin@cygwin.com Received: (qmail 89205 invoked by uid 89); 22 Jul 2019 16:45:23 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-106.3 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_2,GOOD_FROM_CORINNA_CYGWIN,NORMAL_HTTP_TO_IP,NUMERIC_HTTP_ADDR,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 spammy= X-HELO: mout.kundenserver.de Received: from mout.kundenserver.de (HELO mout.kundenserver.de) (212.227.126.135) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 22 Jul 2019 16:45:21 +0000 Received: from calimero.vinschen.de ([24.134.7.25]) by mrelayeu.kundenserver.de (mreue012 [212.227.15.167]) with ESMTPSA (Nemesis) id 1MnpP8-1iEBsy1dXe-00pQ12; Mon, 22 Jul 2019 18:45:10 +0200 Received: by calimero.vinschen.de (Postfix, from userid 500) id 10CA6A808BB; Mon, 22 Jul 2019 18:45:09 +0200 (CEST) Date: Mon, 22 Jul 2019 16:45:00 -0000 From: Corinna Vinschen To: Ken Brown Cc: "cygwin@cygwin.com" , "Erik M. Bray" Subject: Re: Regression (last snapshot) Message-ID: <20190722164509.GG21169@calimero.vinschen.de> Reply-To: cygwin@cygwin.com Mail-Followup-To: Ken Brown , "cygwin@cygwin.com" , "Erik M. Bray" References: <8f6a87faa9c8130241c026889a01d763@xs4all.nl> <5414d0e1-79d9-cab7-b1bd-4761265bf8bd@cornell.edu> <265a2749-95b6-38aa-a191-7913bfcc98b6@cornell.edu> <20190722152016.GE21169@calimero.vinschen.de> <20190722155340.GF21169@calimero.vinschen.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="oXNgvKVxGWJ0RPMJ" Content-Disposition: inline In-Reply-To: <20190722155340.GF21169@calimero.vinschen.de> User-Agent: Mutt/1.11.3 (2019-02-01) X-SW-Source: 2019-07/txt/msg00169.txt.bz2 --oXNgvKVxGWJ0RPMJ Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-length: 2176 On Jul 22 17:53, Corinna Vinschen wrote: > On Jul 22 17:20, Corinna Vinschen wrote: > > On Jul 22 13:44, Ken Brown wrote: > > > On 7/22/2019 8:23 AM, Ken Brown wrote: > > > > On 7/20/2019 6:55 PM, Houder wrote: > > > >> 64-@@ uname -a > > > >> CYGWIN_NT-6.1 Seven 3.1.0s(0.339/5/3) 2019-07-12 15:28 x86_64 Cygw= in > > > >> > > > >> 64-@@ ls -lL <(grep bash .bashrc) > > > >> ls: /dev/fd/63: No such file or directory > > > >> pr-------- 1 Henri None 0 Jul 21 00:41 /dev/fd/63 > > > >=20 > > > > Thanks for the report. This is probably caused by my new FIFO code= . I'm > > > > looking into it. > > >=20 > > > Actually, a bisection shows that the regression is due to the followi= ng commit: > > >=20 > > > commit 2607639992f6600135532831c8357c10cb248821 > > > Author: Erik M. Bray > > > Date: Wed Apr 10 17:05:22 2019 +0200 > > >=20 > > > Improve error handling in /proc/[pid]/ virtual files. > > > [...] > > > Erik, can you take a look? > >=20 > > I have a hunch. It's this change: > >=20 > > @@ -355,7 +355,7 @@ fhandler_process::fill_filebuf () > > } > > else > > filesize =3D process_tab[fileid].format_func (p, filebuf); > > - return !filesize ? false : true; > > + return filesize < 0 ? false : true; > > } > > return false; > > } > >=20 > > The formatter for /proc/PID/fd, format_process_fd, returns *valid* > > negative values. But the above patch treats all negative values as > > error now. > >=20 > > The fact that format_process_fd returns negative values has historical > > reasons. Negative values of type virtual_ftype_t are files, positive > > values are directories. > >=20 > > One way to fix this is to change this to all positive values. At a > > first glance I don't see any check for an explicit negative > > virtual_ftype_t value, especially not in the only consumer > > path_conv::check in path.cc, and the simple numbers have long been > > replaced with enum values. >=20 > A second glance shows a few problems in the code... I pushed a patch and I'm building new developer snapshots right now. Please give them a try. Corinna --=20 Corinna Vinschen Cygwin Maintainer --oXNgvKVxGWJ0RPMJ Content-Type: application/pgp-signature; name="signature.asc" Content-length: 833 -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEoVYPmneWZnwT6kwF9TYGna5ET6AFAl016BQACgkQ9TYGna5E T6BzBA/9EgT0K7l50Y6db4xrLIbzl0onbtaXFoqpvdZpbD/rJttVdk4oExE38eM9 DuWdJlWm80Kq/xo0vNWpyxEMkyCwZku4iy6SZfC8/pQ1zvHALD/cl6tq+v8C49so 2dbzXXy0T6SW5qfw0Vc1yMiZ3A2wDJZiSkkiHE/+OlFhB8cp/IP9Kr6vQ+D6DEuU w2a1A10b0ARmWXOie/jcllrwl/i8fNWvWrAVhxENHRxnogjQKXc4FSOBoKe7Sclz oAa4H6vZcyBkPC1WvE7SXutbHzrnR9D8h8XHDxF1eKsaayjhc14UaFXDo3oaNR8Y /oOjFLgHTDV6bHefMZwiBQm4Pe4qllxIbj/mkjBUZ5GZLkEoio3lMjkJbmnTBJVy uYe4Jk6Igqw1ft8EjBk4EkguGg1o3UQe6BNDs5iAwL44PnZvW6bFvAXHb/LdzpP2 9bSKqWATQletOJLnDrGRo1jiVtwxOTdUK/4GuXeL3sg/ySml/l5+Zg4b+92uZAmy R8EisImbIQxzAA/WF/nO+AY8ieEbqx1hk9mv5KcU4u6BbVMqjfqXN92REn2V9UEe dNi4UPw73rqYBomunDfQCkA0z4nXLhm8sn6q/j/sSNS8Jl1Vz2zSvQ4PsWg1r3jA ZJQgDmtSETRhza78s6zs7+jjSZi+mOxKjIHUy+5UJcrUj221Q8U= =l/NL -----END PGP SIGNATURE----- --oXNgvKVxGWJ0RPMJ--