From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 58865 invoked by alias); 15 Aug 2019 10:20:50 -0000 Mailing-List: contact cygwin-help@cygwin.com; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: cygwin-owner@cygwin.com Mail-Followup-To: cygwin@cygwin.com Received: (qmail 58858 invoked by uid 89); 15 Aug 2019 10:20:50 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-103.8 required=5.0 tests=AWL,BAYES_00,GOOD_FROM_CORINNA_CYGWIN,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 spammy=learning, tricky, online, our X-HELO: mout.kundenserver.de Received: from mout.kundenserver.de (HELO mout.kundenserver.de) (217.72.192.75) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 15 Aug 2019 10:20:49 +0000 Received: from calimero.vinschen.de ([24.134.7.25]) by mrelayeu.kundenserver.de (mreue106 [212.227.15.183]) with ESMTPSA (Nemesis) id 1Mq2Sa-1icRQZ3xWU-00n943; Thu, 15 Aug 2019 12:20:41 +0200 Received: by calimero.vinschen.de (Postfix, from userid 500) id C4FD1A8071F; Thu, 15 Aug 2019 12:20:38 +0200 (CEST) Date: Thu, 15 Aug 2019 10:20:00 -0000 From: Corinna Vinschen To: "Lavrentiev, Anton (NIH/NLM/NCBI) [C]" Cc: "cygwin@cygwin.com" Subject: Re: getpriority() and top display for priority inconsistent Message-ID: <20190815102038.GM11632@calimero.vinschen.de> Reply-To: cygwin@cygwin.com Mail-Followup-To: "Lavrentiev, Anton (NIH/NLM/NCBI) [C]" , "cygwin@cygwin.com" References: <20190815072854.GE11632@calimero.vinschen.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="BvhWI31Ceb2Zf+Ez" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.11.3 (2019-02-01) X-SW-Source: 2019-08/txt/msg00198.txt.bz2 --BvhWI31Ceb2Zf+Ez Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-length: 1657 On Aug 15 09:41, Lavrentiev, Anton (NIH/NLM/NCBI) [C] via cygwin wrote: > > git format-patch output with commit message, please? >=20 > Please educate me how to do that; I am just using "git diff --no-color". $ git add $ git commit -a - opens editor to create a commit message. first line is summary, second line stays empty, descriptive text follows in line 3+. $ git format-patch -1 - creates a git patch file which can be attached to your email or just send *as* email with `git send-email --to=3D Starting with git has a bit steep learning curve, but it's totally worth it. There's a great free online book available: https://git-scm.com/book/ > > The commit message should describe what the problem is and how the patc= h fixes it. One or > > two sentences are enough. >=20 > The commit message is there: >=20 > > > "getpriority() consistent with process priority > > https://cygwin.com/ml/cygwin/2019-08/msg00122.html" Well, that's just a quote from a former email. I would never have recognized it as a commit message. A commit message should consist of the one-line summary (in our case starting with the text "Cygwin: " to distinguish the change from generic newlib changes), followed by an empty line, followed by a descriptive text, what problem this patch fixes and how. Don't get me wrong, I'm glad you send patches, but it's tricky to create a meaningful commit message if you're not the author of a patch. It's also pretty time-consuming since you have to care for correct authorship and stuff. Thanks, Corinna --=20 Corinna Vinschen Cygwin Maintainer --BvhWI31Ceb2Zf+Ez Content-Type: application/pgp-signature; name="signature.asc" Content-length: 833 -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEoVYPmneWZnwT6kwF9TYGna5ET6AFAl1VMfYACgkQ9TYGna5E T6Dc/w//c2URAomYkJI/be4w5xclsCu8raJaAUksLcP9gqC6SMZLcmT6Ay60lYwy YzObYDASBXr0WcPZ7Nmif+nIztbQAV89aEP6M2dALQcTGlosI8tNPm0UZevMgkB9 io53ELuP3fwWHzMKH3NdmOe3PUsHNHwZlJMgw+5THWDNlrX/hqmYj4yprppiajNb /iVAJlvsHMnmG2FZJftOJELIvAWtoOVOE+zn57kW6OQ8LyNZfVw17dwS8LagFMHS PV/ts0zFZaPhM6jIa6AqeKkNI7H33y5x6w0Uc+ObkL/XIMVJqlxwO5mwNnCAlhdS 61HLnUE/CCRa598IzjE0rWiF8ejJLOi9sQLR2pl6TEdyeH53gKgAorNxZxuMxi8l c1gMFxZM6pBpaW4s5qTLxvEMaZhGrH7nG21ErZ6v+lbeQMNmrEVpVL+2AG0emAVf AOjWhOLjMHPx30vTPbuQsnr/HS/SdGpdR4IISjxFlQqzfZ2sZV5NdOnhQPSoVn04 fLDyyzdetC33kw19QSrdB7IfAcaEccQT5eKFQc103UjierTP5YRAklAqrjANuPoi B7NXJRpvKRKwBcQ+y0Nug1KHivtfrlPqASPadCZelDibJCC7Ins0i/QzbwzqDBYK JSeCigcDAanO7ckk7+96IRzCPjwICk9g/BwtWLnKjiC9jtg2av4= =t0ew -----END PGP SIGNATURE----- --BvhWI31Ceb2Zf+Ez--