From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 114558 invoked by alias); 17 Aug 2019 16:43:21 -0000 Mailing-List: contact cygwin-help@cygwin.com; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: cygwin-owner@cygwin.com Mail-Followup-To: cygwin@cygwin.com Received: (qmail 114551 invoked by uid 89); 17 Aug 2019 16:43:20 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-6.4 required=5.0 tests=AWL,BAYES_00,KAM_NUMSUBJECT,RCVD_IN_DNSWL_NONE autolearn=no version=3.3.1 spammy=ideally, HDKIM-Filter:v2.10.3, HX-Spam-Relays-External:Sendmail, H*RU:Sendmail X-HELO: conssluserg-04.nifty.com Received: from conssluserg-04.nifty.com (HELO conssluserg-04.nifty.com) (210.131.2.83) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 17 Aug 2019 16:43:18 +0000 Received: from Express5800-S70 (ntsitm268057.sitm.nt.ngn.ppp.infoweb.ne.jp [125.1.110.57]) (authenticated) by conssluserg-04.nifty.com with ESMTP id x7HGhCeH026092 for ; Sun, 18 Aug 2019 01:43:12 +0900 DKIM-Filter: OpenDKIM Filter v2.10.3 conssluserg-04.nifty.com x7HGhCeH026092 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.ne.jp; s=dec2015msa; t=1566060192; bh=MRhEzTF81/sAysH/y4LaKYX7xJSdL6zFXAkCAfvx+3g=; h=Date:From:To:Subject:In-Reply-To:References:From; b=dvLkGA18uE1I4QuDTjqc/kQ8CoKE/Q8oZPl2SzCv2Rw6lAAx4327Itb4okotFReuK E59/hlLrmFi/fFgD5gBpxnXi93JjWshp+fxfgDJcAaql3b6XE3FMzZfWvAowcVnde+ PHcgON9uZmnS0GOyuDKjAJOsOp0mE9HAspA+V5ktTsOV1v1R4cnnL3q+a1+JZPCHDc +lLBbIr8L8ZM/7lwEk/uPA1SsGBj8vNOlKyQbPJJAzS9CxoJDJNx5E5T4nQawMOywc 4PoY6y24agU432clkS41Ou7RKR8TuRm9bE4+3Jm1MXWhn9MGp5cnzOA1eXjTVL3tfJ L3Antpy2/LUCQ== Date: Sat, 17 Aug 2019 16:59:00 -0000 From: Takashi Yano To: cygwin@cygwin.com Subject: Re: [ANNOUNCEMENT] TEST: Cygwin 3.1.0-0.1 Message-Id: <20190818014317.38e23198147dad936da1ac94@nifty.ne.jp> In-Reply-To: <20190816144811.GW11632@calimero.vinschen.de> References: <20190812153613.GN11632@calimero.vinschen.de> <20190813104753.GU11632@calimero.vinschen.de> <20190814204100.659fe40d928eae15338198a7@nifty.ne.jp> <20190814204717.caf6884b1216bbeee2f586d6@nifty.ne.jp> <20190814134900.GY11632@calimero.vinschen.de> <20190815042126.7c2f0baf57b4a82f7d013f74@nifty.ne.jp> <20190815074930.GF11632@calimero.vinschen.de> <20190815103638.GO11632@calimero.vinschen.de> <20190815150436.GP11632@calimero.vinschen.de> <20190815150908.GQ11632@calimero.vinschen.de> <20190816144811.GW11632@calimero.vinschen.de> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2019-08/txt/msg00251.txt.bz2 Hi Corinna, On Fri, 16 Aug 2019 16:48:11 +0200 Corinna Vinschen wrote: > I now had an idea, but I'm not entirely sure if it's the right thing to > do. Can you please test this? It consists of two patches, one with the > revamped signalfd handling, and one with the revert of the signalfd > patch I applied a couple of days ago. > > Quick description: I dropped signalfd_select_wait entirely. Instead, > wait_sig sets or resets a manual event object to indicate if there are > signals pending in the queue, even after trying to handle them the > normal way. That usually means they are blocked. > > select() uses the event to wake up from WFMO, if at least one signalfd > is present in the read descriptor set. The rest is done via the peek > and verify functions in select, which basically just check if this > signalfd is waiting for one of the pending signals. > > The reversion of my patch from a couple days ago is not required as > such, but after thinking about this a while I'm convinced that this was > just me not getting the full picture. Also, reverting this patch would > revert to seeing a SEGV in your testcase and thus a bug in the new code, > too. > > I attached both patches. It would be pretty nice if you could test them > and point out any problems you get with this new code. > > Please note that you should ideally perform a full rebuild due to the > slight change in TLS layout. I confirmed that my STC and script command works as expected with these patches. Thank you for greate work! -- Takashi Yano -- Problem reports: http://cygwin.com/problems.html FAQ: http://cygwin.com/faq/ Documentation: http://cygwin.com/docs.html Unsubscribe info: http://cygwin.com/ml/#unsubscribe-simple