From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 34457 invoked by alias); 18 Aug 2019 11:58:57 -0000 Mailing-List: contact cygwin-help@cygwin.com; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: cygwin-owner@cygwin.com Mail-Followup-To: cygwin@cygwin.com Received: (qmail 34450 invoked by uid 89); 18 Aug 2019 11:58:57 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-101.7 required=5.0 tests=AWL,BAYES_00,GOOD_FROM_CORINNA_CYGWIN,KAM_NUMSUBJECT,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 spammy=work!, HX-Languages-Length:1751, greate, H*F:D*cygwin.com X-HELO: mout.kundenserver.de Received: from mout.kundenserver.de (HELO mout.kundenserver.de) (212.227.17.13) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 18 Aug 2019 11:58:56 +0000 Received: from calimero.vinschen.de ([24.134.7.25]) by mrelayeu.kundenserver.de (mreue107 [212.227.15.183]) with ESMTPSA (Nemesis) id 1MyKYE-1iBav03LEy-00yf8G; Sun, 18 Aug 2019 13:58:50 +0200 Received: by calimero.vinschen.de (Postfix, from userid 500) id 4691BA80773; Sun, 18 Aug 2019 13:58:49 +0200 (CEST) Date: Sun, 18 Aug 2019 12:07:00 -0000 From: Corinna Vinschen To: Takashi Yano Cc: cygwin@cygwin.com Subject: Re: [ANNOUNCEMENT] TEST: Cygwin 3.1.0-0.1 Message-ID: <20190818115849.GE11632@calimero.vinschen.de> Reply-To: cygwin@cygwin.com Mail-Followup-To: Takashi Yano , cygwin@cygwin.com References: <20190814204100.659fe40d928eae15338198a7@nifty.ne.jp> <20190814204717.caf6884b1216bbeee2f586d6@nifty.ne.jp> <20190814134900.GY11632@calimero.vinschen.de> <20190815042126.7c2f0baf57b4a82f7d013f74@nifty.ne.jp> <20190815074930.GF11632@calimero.vinschen.de> <20190815103638.GO11632@calimero.vinschen.de> <20190815150436.GP11632@calimero.vinschen.de> <20190815150908.GQ11632@calimero.vinschen.de> <20190816144811.GW11632@calimero.vinschen.de> <20190818014317.38e23198147dad936da1ac94@nifty.ne.jp> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="/MgqJpI0ZKqTFycX" Content-Disposition: inline In-Reply-To: <20190818014317.38e23198147dad936da1ac94@nifty.ne.jp> User-Agent: Mutt/1.11.3 (2019-02-01) X-SW-Source: 2019-08/txt/msg00259.txt.bz2 --/MgqJpI0ZKqTFycX Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-length: 1743 On Aug 18 01:43, Takashi Yano wrote: > Hi Corinna, >=20 > On Fri, 16 Aug 2019 16:48:11 +0200 > Corinna Vinschen wrote: > > I now had an idea, but I'm not entirely sure if it's the right thing to > > do. Can you please test this? It consists of two patches, one with the > > revamped signalfd handling, and one with the revert of the signalfd > > patch I applied a couple of days ago. > >=20 > > Quick description: I dropped signalfd_select_wait entirely. Instead, > > wait_sig sets or resets a manual event object to indicate if there are > > signals pending in the queue, even after trying to handle them the > > normal way. That usually means they are blocked. > >=20 > > select() uses the event to wake up from WFMO, if at least one signalfd > > is present in the read descriptor set. The rest is done via the peek > > and verify functions in select, which basically just check if this > > signalfd is waiting for one of the pending signals. > >=20 > > The reversion of my patch from a couple days ago is not required as > > such, but after thinking about this a while I'm convinced that this was > > just me not getting the full picture. Also, reverting this patch would > > revert to seeing a SEGV in your testcase and thus a bug in the new code, > > too. > >=20 > > I attached both patches. It would be pretty nice if you could test them > > and point out any problems you get with this new code. > >=20 > > Please note that you should ideally perform a full rebuild due to the > > slight change in TLS layout. >=20 > I confirmed that my STC and script command works as expected with these > patches. >=20 > Thank you for greate work! Great, thank you, and thanks for testing! Corinna --=20 Corinna Vinschen Cygwin Maintainer --/MgqJpI0ZKqTFycX Content-Type: application/pgp-signature; name="signature.asc" Content-length: 833 -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEoVYPmneWZnwT6kwF9TYGna5ET6AFAl1ZPXkACgkQ9TYGna5E T6DgFxAAie0Dr1hTEfjCWoIvO2vYily1U+mUEQtZmGBq1rdsfE87l9kF4Pan2qpi 7qwrYUkU4LUXISOvkuGYv32xljwQUXMukym2ruX3S3vufufrZm9/1iY0P2cu17DL Xp9AENcA0WLJD4B7Ev/ZNikTXplpggEm1shkdlfUSE4igsIqdSh2QD9fgJhXAqRE oy5tndRli5FNSjDo5By1p1HSJYUepmCzK/HzXQowkqoHjBfGIInvTV+UGu43fXTb enzeJ6oJQcm0/t8gwiI2J8Rz51snNqpB4f1U9OZpKQRpTFC9JcRLEm7EKsiAIZ2E XWHW1Eepmi++xSuyTPzM88UR9d2/z/FD/VlPk5TtUYB1ZR+yswIZ09CByEyouof3 RSVrfCl5eb6n51qQRphVkvjNdc0ad33pYNNnIUwRY1+aokBG5bcodg/SJLfbCv5q h/avXaVRkcrij4YG5xa7vGX58XS8k4Dxw88wIvXqRVhpOGFpilIs9EDXNOyIgCaj tWPGQNsGuoMOWwxXo6dxl3dNOlquhf4fJCr3fMMsj0B18cE0eXdHpHe2UJDBtgrs xZm+CD+acOJG8IPRMnVI7kpDYSQSyRiG3ggEvXHSbwblVKfZlcpi+b/Mk8sZ2xhR uA3hk8dG6vX0LoOB649Oqq+BWno1xkA7vcjPET0VpcC2qvbPYbA= =x6bs -----END PGP SIGNATURE----- --/MgqJpI0ZKqTFycX--