From: Corinna Vinschen <corinna-cygwin@cygwin.com>
To: cygwin@cygwin.com
Cc: Takashi Yano <takashi.yano@nifty.ne.jp>
Subject: Re: [ANNOUNCEMENT] TEST: Cygwin 3.1.0-0.3
Date: Fri, 30 Aug 2019 08:11:00 -0000 [thread overview]
Message-ID: <20190830075523.GB27273@calimero.vinschen.de> (raw)
In-Reply-To: <CALK-3mLPXAcjZdftE_L-YwneyM79GBEt8c1nyVTisjKp0abCUg@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 2468 bytes --]
[CC Takashi]
On Aug 29 22:15, Biswapriyo Nath wrote:
> On Thursday, August 29, 2019, Corinna Vinschen <corinna-cygwin@cygwin.com>
> wrote:
> > Support the new pseudo console in PTY. Pseudo console is a new feature
> in Windows 10 1809, which provides console APIs on virtual terminal.
>
> Some queries about this specific feature:
Please note that this is very likely not the final version. I'm
planning for a release end of october or early november so there's
still lots of time to fix issues. However, this is a great new feature
which needs good testing, that's why we do these test releases.
> 1a. In fhandler_pty_mater::ioctl function, shouldn't the function pointer
> be checked before use? Also what the FIXME says, isn't clear. Any hint?
Yeah, right. What happens on pre-W10 1809 systems? They probably
crash on TIOCSWINSZ. See below.
> 1b. GetModuleHandle and GetProcessHeap is called several times. Wouldn't be
> it easier to get all the pseudo console function pointers in one
> constructor?
In terms of GetModuleHandle/GetProcAddress the right thing to do is to
use the autoload feature, i.e., add the functions to autoload.cc like
this:
LoadDLLfuncEx (ClosePseudoConsole, 4, kernel32, 1)
LoadDLLfuncEx (CreatePseudoConsole, 20, kernel32, 1)
LoadDLLfuncEx (ResizePseudoConsole, 8, kernel32, 1)
If the function call returns FALSE with GetLastError() ==
ERROR_PROC_NOT_FOUND, then the function is not available.
Takashi, I didn't actually notice the usage of the Windows heap here.
The usual method is to use a tls_pbuf buffer, and rather than
using MultiByteToWideChar/WideCharToMultiByte, use sys_mbstowcs/
sys_wcstombs.
Also, can you please change the camelback names in class tty_min to
underscored writing, e.g., term_codepage rather than TermCodePage?
> 2. There are many defined values are added but those are also present in
> mingw-w64 current git repo. For example, ENABLE_VIRTUAL_TERMINAL_PROCESSING.
We can only use what's part of the current w32api-headers package.
> 3. I can't reproduce this issue with exact steps. But when I zoom in/out +
> resize mintty window + execute cmd.exe in mintty in some random order it
> crashed. Here is the error:
>
> [main] D:\Cygwin64\bin\bash 1129
> fhandler_pty_slave::push_to_pcon_screenbuffer: pty0: pcon_attach
> mismatch?????? (0x18035DBD0)
Takashi?
Thanks,
Corinna
--
Corinna Vinschen
Cygwin Maintainer
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2019-08-30 7:55 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-29 12:47 Corinna Vinschen
2019-08-29 16:51 ` Biswapriyo Nath
2019-08-30 8:11 ` Corinna Vinschen [this message]
2019-08-30 19:16 ` Takashi Yano
2019-08-30 20:21 ` Corinna Vinschen
2019-08-31 3:58 ` Biswapriyo Nath
2019-08-31 4:21 ` Takashi Yano
2019-09-01 6:32 ` Biswapriyo Nath
2019-09-02 8:17 ` Corinna Vinschen
2019-09-03 9:28 ` Biswapriyo Nath
2019-09-03 10:48 ` Corinna Vinschen
2019-09-05 18:11 ` Jim Reisert AD1C
2019-09-06 2:23 ` Ken Brown
2019-09-06 5:22 ` Jim Reisert AD1C
2019-09-06 10:03 ` Thomas Wolff
2019-09-07 3:32 ` Takashi Yano
2019-09-07 11:53 ` Thomas Wolff
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190830075523.GB27273@calimero.vinschen.de \
--to=corinna-cygwin@cygwin.com \
--cc=cygwin@cygwin.com \
--cc=takashi.yano@nifty.ne.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).