From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 37162 invoked by alias); 30 Aug 2019 18:20:09 -0000 Mailing-List: contact cygwin-help@cygwin.com; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: cygwin-owner@cygwin.com Mail-Followup-To: cygwin@cygwin.com Received: (qmail 37154 invoked by uid 89); 30 Aug 2019 18:20:09 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-5.4 required=5.0 tests=AWL,BAYES_00,KAM_NUMSUBJECT,RCVD_IN_DNSWL_NONE autolearn=no version=3.3.1 spammy=revised, HDKIM-Filter:v2.10.3, culprit, HX-Spam-Relays-External:Sendmail X-HELO: conssluserg-04.nifty.com Received: from conssluserg-04.nifty.com (HELO conssluserg-04.nifty.com) (210.131.2.83) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 30 Aug 2019 18:20:06 +0000 Received: from Express5800-S70 (ntsitm268057.sitm.nt.ngn.ppp.infoweb.ne.jp [125.1.110.57]) (authenticated) by conssluserg-04.nifty.com with ESMTP id x7UIK2VX021466 for ; Sat, 31 Aug 2019 03:20:02 +0900 DKIM-Filter: OpenDKIM Filter v2.10.3 conssluserg-04.nifty.com x7UIK2VX021466 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.ne.jp; s=dec2015msa; t=1567189202; bh=5JOuEFqMcZWRHDIoZOn02ol+93vzokMflDs6FMw4xuU=; h=Date:From:To:Subject:In-Reply-To:References:From; b=buoSyswXU4TLz4gcEoAU4p0Ryl/djatT5i8Va6wfj1/chgu+EzoCzWjeuH4PcdI+r yB02Qvdi5Rh+eplofeIBamO2w6ZxAorIINcxc7yoi6xhMatcNBzjIfg0+1t6fAAwqu AbVOiP1d+4FCl+vYPyc0WG03Wdw7p9ov5uupm6/G4TO9C8mngGBWqRPzIp6O4lSt8q xyyEk+r/uvOwzMB89blWJPle7fBSXJMHO+I0CVAyYay13rZy+SyH9q7QOkowMWxykl pvebv0TNBk2+XoiEyqE0acB4cUjSWKX8OOEIHmG3XH1fm/e+RFNSrLiem9D0VsnVYO 2HkTiVhRwuPZg== Date: Fri, 30 Aug 2019 19:16:00 -0000 From: Takashi Yano To: cygwin@cygwin.com Subject: Re: [ANNOUNCEMENT] TEST: Cygwin 3.1.0-0.3 Message-Id: <20190831032003.d19fb7060c632bb51777c0de@nifty.ne.jp> In-Reply-To: <20190830075523.GB27273@calimero.vinschen.de> References: <20190830075523.GB27273@calimero.vinschen.de> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2019-08/txt/msg00430.txt.bz2 Hi Biswapriyo and Corinna, Thank you very much for testing. On Fri, 30 Aug 2019 09:55:23 +0200 Corinna Vinschen wrote: > On Aug 29 22:15, Biswapriyo Nath wrote: > > On Thursday, August 29, 2019, Corinna Vinschen > > 1a. In fhandler_pty_mater::ioctl function, shouldn't the function pointer > > be checked before use? Also what the FIXME says, isn't clear. Any hint? > > Yeah, right. What happens on pre-W10 1809 systems? They probably > crash on TIOCSWINSZ. See below. This code is protected by if (getPseudoConsole () && ... that is, pseudo console handle is set only if CreatePseudoConsole() successes. In pre-W10 1809, since pseudo console handle is not set, this code is not reached. However, it is better to check before call as you suggest. What is meant in FIXME comment: ResizePseudoConsole() needs handle to pseudo console. This handle is valid only in the process which created it. If ioctl(TIOCSWINSZ, ...) is called from other process, it fails. I had tried DuplicateHandle(), but it did not work. Therefore, ResizePseudoConsole() is called only if ioctl() is called from PTY master process. Similarly, ClosePseudoConsole() can work only in the master process. > > 1b. GetModuleHandle and GetProcessHeap is called several times. Wouldn't be > > it easier to get all the pseudo console function pointers in one > > constructor? > > In terms of GetModuleHandle/GetProcAddress the right thing to do is to > use the autoload feature, i.e., add the functions to autoload.cc like > this: > > LoadDLLfuncEx (ClosePseudoConsole, 4, kernel32, 1) > LoadDLLfuncEx (CreatePseudoConsole, 20, kernel32, 1) > LoadDLLfuncEx (ResizePseudoConsole, 8, kernel32, 1) > > If the function call returns FALSE with GetLastError() == > ERROR_PROC_NOT_FOUND, then the function is not available. > > Takashi, I didn't actually notice the usage of the Windows heap here. > The usual method is to use a tls_pbuf buffer, and rather than > using MultiByteToWideChar/WideCharToMultiByte, use sys_mbstowcs/ > sys_wcstombs. > > Also, can you please change the camelback names in class tty_min to > underscored writing, e.g., term_codepage rather than TermCodePage? OK. I will revised the code followed to your advice. First, I would like to fix some bugs and will post a patch. Second, I will revise the coding style. May I post them as indivisual patches? I also suppose the patch should be against the v9 patch, right? > > 3. I can't reproduce this issue with exact steps. But when I zoom in/out + > > resize mintty window + execute cmd.exe in mintty in some random order it > > crashed. Here is the error: > > > > [main] D:\Cygwin64\bin\bash 1129 > > fhandler_pty_slave::push_to_pcon_screenbuffer: pty0: pcon_attach > > mismatch?????? (0x18035DBD0) > > Takashi? This most likely is caused by a bug. Now, I am looking into this problem. I have found the culprit, maybe. -- Takashi Yano -- Problem reports: http://cygwin.com/problems.html FAQ: http://cygwin.com/faq/ Documentation: http://cygwin.com/docs.html Unsubscribe info: http://cygwin.com/ml/#unsubscribe-simple