public inbox for cygwin@cygwin.com
 help / color / mirror / Atom feed
From: Takashi Yano <takashi.yano@nifty.ne.jp>
To: cygwin@cygwin.com
Subject: Re: [ANNOUNCEMENT] cygwin 3.1.0-0.6 (TEST)
Date: Thu, 03 Oct 2019 10:44:00 -0000	[thread overview]
Message-ID: <20191003194404.8bde935fcee1a987f6007121@nifty.ne.jp> (raw)
In-Reply-To: <1e27eef9-930c-0441-3da3-8039c84206e8@ssi-schaefer.com>

Hi Michael,

Thanks for the report.

On Wed, 2 Oct 2019 16:03:53 +0200
Michael Haubenwallner wrote:
> * I'm logged into some Server 2012r2 box via Cygwin sshd from Linux xterm,
> * export EDITOR=vim     # but same problem with EDITOR=emacs
> * cd to some git project
> * git rebase -i HEAD^
> * Ctrl-Z, to temporarily return to shell prompt
> 
> Both the editor and the git processes seem to be suspended, but the
> shell does not react nor show the prompt in any way, although further
> keyboard input characters are displayed.

I looked into this problem, and found this caused by the following
change.

> diff --git a/winsup/cygwin/exceptions.cc b/winsup/cygwin/exceptions.cc
> index 848f9bd68..db0fe0867 100644
> --- a/winsup/cygwin/exceptions.cc
> +++ b/winsup/cygwin/exceptions.cc
> @@ -949,7 +949,7 @@ _cygtls::interrupt_setup (siginfo_t& si, void *handler, struct sigaction& siga)
>    if (incyg)
>      set_signal_arrived ();
>  
> -  if (!have_execed)
> +  if (!have_execed && ch_spawn.iscygwin ())
>      proc_subproc (PROC_CLEARWAIT, 1);
>    sigproc_printf ("armed signal_arrived %p, signal %d",
>  		  signal_arrived, si.si_signo);

The cause is that iscygwin() returns false even if the process
is cygwin process, contrary to my expectation. However, it is
natural if I think well.

I have just submitted a patch for this issue.

-- 
Takashi Yano <takashi.yano@nifty.ne.jp>

--
Problem reports:       http://cygwin.com/problems.html
FAQ:                   http://cygwin.com/faq/
Documentation:         http://cygwin.com/docs.html
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple

  parent reply	other threads:[~2019-10-03 10:44 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-22 16:24 Ken Brown
2019-09-24  7:38 ` Michael Haubenwallner
2019-09-24 12:50   ` Ken Brown
2019-09-24 23:05 ` Ken Brown
2019-09-25 18:30   ` Takashi Yano
2019-09-26 12:51     ` Takashi Yano
2019-09-26 14:38       ` Ken Brown
2019-10-02 14:04 ` Michael Haubenwallner
2019-10-02 18:24   ` Ken Brown
2019-10-03 10:44   ` Takashi Yano [this message]
2019-10-10 10:44 ` Michael Haubenwallner
2019-10-11  9:25   ` Takashi Yano
2019-10-14 11:07     ` Michael Haubenwallner
2019-10-16 12:32       ` Takashi Yano
2019-10-18 11:36         ` Takashi Yano
2019-10-16 14:34       ` Takashi Yano
2019-10-16 16:34         ` Michael Haubenwallner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191003194404.8bde935fcee1a987f6007121@nifty.ne.jp \
    --to=takashi.yano@nifty.ne.jp \
    --cc=cygwin@cygwin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).