From: Corinna Vinschen <corinna-cygwin@cygwin.com>
To: cygwin@cygwin.com
Subject: Re: 3.0.7(0.338/5/3): Possible reference to Developer's instances of dev files in deployed build
Date: Mon, 09 Dec 2019 09:20:00 -0000 [thread overview]
Message-ID: <20191209091728.GE3499@calimero.vinschen.de> (raw)
In-Reply-To: <fe61ad0a-1c5e-120c-94ab-746ff839b426@cornell.edu>
[-- Attachment #1: Type: text/plain, Size: 1798 bytes --]
On Dec 7 21:03, Ken Brown wrote:
> I don't have any words of wisdom here, but I need to correct something I said
> earlier.
>
> On 12/4/2019 3:50 PM, Ken Brown wrote:
> > The assertion fails because 'Z:' doesn't contain a backslash.
>
> This is not quite right. It's true that path_conv::check strips the trailing
> backslash from Z:\, but then it adds it back before calling symlink_info::check:
>
> /* If path is only a drivename, Windows interprets it as the
> current working directory on this drive instead of the root
> dir which is what we want. So we need the trailing backslash
> in this case. */
> if (full_path[0] && full_path[1] == ':' && full_path[2] == '\0')
> {
> full_path[2] = '\\';
> full_path[3] = '\0';
> }
>
> Thus symlink_info::check is in fact called on Z:\, but the assertion fails
> because the code at path.cc:2905 is looking for a backslash prior to the
> trailing backslash. So maybe the right fix for the assertion failure is the
> following:
>
> --- a/winsup/cygwin/path.cc
> +++ b/winsup/cygwin/path.cc
> @@ -2895,7 +2895,8 @@ restart:
> slow down normal operation. This extra check only kicks in if
> we encountered a STATUS_OBJECT_NAME_NOT_FOUND *and* we didn't
> already attach a suffix. */
> - if (!restarted && !*ext_here && !(mount_flags & MOUNT_DOS))
> + if (!restarted && !*ext_here && ext_here[-1] != '\\'
> + && !(mount_flags & MOUNT_DOS))
> {
> /* Check for trailing dot or space or leading space in
> last component. */
Ok, please push that. I'll create a snapshot so Wilfed can test this.
Thanks,
Corinna
--
Corinna Vinschen
Cygwin Maintainer
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2019-12-09 9:17 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-06 4:56 Wilfed Olaf Sulla via cygwin
2019-12-06 11:07 ` Corinna Vinschen
2019-12-06 14:35 ` Corinna Vinschen
2019-12-07 21:03 ` Ken Brown
2019-12-09 9:20 ` Corinna Vinschen [this message]
2019-12-09 13:05 ` Ken Brown
2019-12-09 17:29 ` Corinna Vinschen
2019-12-10 8:44 ` Ken Brown
-- strict thread matches above, loose matches on Subject: below --
2019-12-10 13:37 Wilfed Olaf Sulla via cygwin
2019-12-10 18:57 ` Ken Brown
2019-12-11 0:09 ` Corinna Vinschen
2019-12-11 5:43 ` Ken Brown
2019-12-11 16:03 ` Corinna Vinschen
2019-12-06 12:35 Wilfed Olaf Sulla via cygwin
2019-12-04 21:03 Wilfed Olaf Sulla via cygwin
2019-12-04 21:41 ` Ken Brown
2019-12-05 9:18 ` Corinna Vinschen
2019-12-05 12:52 ` Corinna Vinschen
2019-12-05 16:10 ` Ken Brown
2019-12-05 19:16 ` Corinna Vinschen
2019-12-05 19:44 ` Ken Brown
2019-12-06 2:11 ` Norton Allen
2019-12-06 9:31 ` Corinna Vinschen
2019-12-08 21:50 ` Andrey Repin
2019-12-09 10:22 ` Corinna Vinschen
2019-12-04 17:18 Wilfed Olaf Sulla via cygwin
2019-12-04 18:22 ` Corinna Vinschen
2019-12-04 19:27 ` Wilfed Olaf Sulla via cygwin
2019-12-04 20:50 ` Ken Brown
2019-12-04 10:41 Wilfed Olaf Sulla via cygwin
2019-12-04 14:40 ` Ken Brown
2019-12-04 16:19 ` Wilfed Olaf Sulla via cygwin
2019-12-04 16:39 ` Ken Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191209091728.GE3499@calimero.vinschen.de \
--to=corinna-cygwin@cygwin.com \
--cc=cygwin@cygwin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).