From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8738 invoked by alias); 25 Feb 2020 14:40:03 -0000 Mailing-List: contact cygwin-help@cygwin.com; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: cygwin-owner@cygwin.com Mail-Followup-To: cygwin@cygwin.com Received: (qmail 8729 invoked by uid 89); 25 Feb 2020 14:40:03 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-7.6 required=5.0 tests=BAYES_00,GIT_PATCH_2,RCVD_IN_DNSWL_LOW,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.1 spammy=freundlichen, technologies, schon, mu X-HELO: smtprelay06.ispgateway.de Received: from smtprelay06.ispgateway.de (HELO smtprelay06.ispgateway.de) (80.67.31.101) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 25 Feb 2020 14:39:53 +0000 Received: from [134.119.228.1] (helo=webmailfront-cgn01.ispgateway.de) by smtprelay06.ispgateway.de with esmtpsa (TLSv1:ECDHE-RSA-AES256-SHA:256) (Exim 4.92.3) (envelope-from ) id 1j6bNG-0008EE-Bq for cygwin@cygwin.com; Tue, 25 Feb 2020 15:39:50 +0100 Received: from 217.10.52.10 ([217.10.52.10]) by webmail.df.eu (Horde Framework) with HTTP; Tue, 25 Feb 2020 15:39:50 +0100 Date: Tue, 25 Feb 2020 14:40:00 -0000 Message-ID: <20200225153950.Horde.z195jFsJbgwsyFSP_AqtyQ3@webmail.df.eu> From: matthias@koefferlein.de To: cygwin@cygwin.com Subject: qmake-qt5 does not support QMAKE_POST_LINK on shared object targets User-Agent: Internet Messaging Program (IMP) H5 (6.0.4) Content-Type: text/plain; charset=UTF-8; format=flowed; DelSp=Yes MIME-Version: 1.0 Content-Disposition: inline Content-Transfer-Encoding: 8bit X-SW-Source: 2020-02/txt/msg00230.txt.bz2 Dear qt5-base maintainers, I noticed that QMAKE_POST_LINK is not applied to shared object targets in qmake (version 3.1 from Qt 5.9.4). The purpose of QMAKE_POST_LINK is to add custom script statements after the link step in qmake-generated Makefiles. I checked cygwin's package files for qt5-base and found this patch which IMHO is lacking QMAKE_POST_LINK support. The qmake.patch is taken from here: https://cygwin.com/git-cygwin-packages/?p=git/cygwin-packages/qt5-base.git;a=blob;f=5.9-cygwin-qmake.patch;h=e6feef3d3a19e5e412adf6e4f2b9ac512553cdc1;hb=HEAD I am referring to this part of the qmake.patch file: 72 if (!isystem.isEmpty() && isSystemInclude(inc.toQString())) 73 @@ -603,6 +603,14 @@ UnixMakefileGenerator::writeMakeParts(QT 74 if(!project->isEmpty("QMAKE_POST_LINK")) 75 t << "\n\t" << var("QMAKE_POST_LINK"); 76 t << endl << endl; 77 + } else if(!project->isEmpty("QMAKE_CYGWIN_SHLIB")) { 78 + t << "\n\t" 79 + << "-$(DEL_FILE) $(TARGET) $(TARGET0)" << "\n\t" 80 + << var("QMAKE_LINK_SHLIB_CMD") << "\n\t"; 81 + if(!destdir.isEmpty()) 82 + t << "-$(DEL_FILE) " << destdir << "$(TARGET)\n\t" 83 + << "-$(DEL_FILE) " << destdir << "$(TARGET0)\n\t" 84 + << "-$(MOVE) $(TARGET) $(TARGET0) " << destdir; ---- # IMHO this part of the patch is missing to enable QMAKE_POST_LINK: if(!project->isEmpty("QMAKE_POST_LINK")) t << "\n\t" << var("QMAKE_POST_LINK"); t << endl << endl; ---- 85 } else if(project->isEmpty("QMAKE_HPUX_SHLIB")) { 86 t << "\n\t"; 87 Thanks for considering this bug report. Best regards, Matthias -----Original Message----- From: Gratz Achim (IFD PMM TI ICTD) Sent: Dienstag, 25. Februar 2020 09:26 To: Koefferlein Matthias (IFAG DES TCP FLP) Subject: RE: KLayout cygwin build Hallo Matthias, > Ok, verstehe. Dann ist der execinfo-Patch auch eine Lösung - es geht > ja nur um den crash handler. Genauer um den Stacktrace. > Das build-Skript macht eigentlich ja nicht viel. Wenn Du die Variablen > selber definierst, kannst Du den qmake auch direkt aufrufen. Sind aber > halt eine Menge Variablen. Ich krieg' das schon hin, ich muß es ja normalerweise nur einmal durchturnen. > Ich bekomme übrigens ein: > > fatal: repository > 'https://cygwin.com/git-cygwin-packages/?p=git/cygwin- > packages/qt5-base.git/' not found > > :( Probier's nochmal, irgendjemand scheint gerade den Sourceware-Server zu DOSen. Mit freundlichen Grüßen. -- mailto:Achim.Gratz@Infineon.com HV-CMOS Technology Development and Process Integration Office: +49 351 886 17 84 Fax: +49 351 886 84 17 84 Infineon Technologies Dresden GmbH & Co. KG Sitz der Gesellschaft: Dresden Registergericht: Dresden HRA 10404 Persönlich haftende Gesellschafterin: Infineon Technologies Dresden Verwaltungs GmbH Vorsitzender des Aufsichtsrats: Pantelis Haidas Geschäftsführer: Dr. Rutger Wijburg, Raik Brettschneider Sitz der Gesellschaft: Neubiberg Registergericht: München HRB 229585 ----- Ende der weitergeleiteten Nachricht ----- -- Problem reports: http://cygwin.com/problems.html FAQ: http://cygwin.com/faq/ Documentation: http://cygwin.com/docs.html Unsubscribe info: http://cygwin.com/ml/#unsubscribe-simple