From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 97801 invoked by alias); 2 Mar 2020 16:07:48 -0000 Mailing-List: contact cygwin-help@cygwin.com; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: cygwin-owner@cygwin.com Mail-Followup-To: cygwin@cygwin.com Received: (qmail 97711 invoked by uid 89); 2 Mar 2020 16:07:48 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-106.4 required=5.0 tests=AWL,BAYES_00,GOOD_FROM_CORINNA_CYGWIN,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 spammy=HX-Languages-Length:2042, solved, H*F:D*cygwin.com X-HELO: mout.kundenserver.de Received: from mout.kundenserver.de (HELO mout.kundenserver.de) (212.227.17.10) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 02 Mar 2020 16:07:46 +0000 Received: from calimero.vinschen.de ([24.134.7.25]) by mrelayeu.kundenserver.de (mreue108 [212.227.15.183]) with ESMTPSA (Nemesis) id 1MDQmW-1jH0Y52GOc-00ATQW for ; Mon, 02 Mar 2020 17:07:43 +0100 Received: by calimero.vinschen.de (Postfix, from userid 500) id B201EA82778; Mon, 2 Mar 2020 17:07:42 +0100 (CET) Date: Mon, 02 Mar 2020 16:07:00 -0000 From: Corinna Vinschen To: cygwin@cygwin.com Subject: Re: Incorrect behavior in TIOCINQ ioctl Message-ID: <20200302160742.GR4045@calimero.vinschen.de> Reply-To: cygwin@cygwin.com Mail-Followup-To: cygwin@cygwin.com References: <20200228192330.GN4045@calimero.vinschen.de> <09e4b16c-a4fb-4062-1d29-a92a916f186b@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="1y/7ip9Z0l6NTTti" Content-Disposition: inline In-Reply-To: <09e4b16c-a4fb-4062-1d29-a92a916f186b@gmail.com> X-SW-Source: 2020-03/txt/msg00013.txt --1y/7ip9Z0l6NTTti Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-length: 2194 On Feb 29 11:37, =C3=85ke Rehnman wrote: >=20 > On 2020-02-28 20:23, Corinna Vinschen wrote: >=20 > > - Is it a safe bet that ClearCommError returns valid values in > > st.cbInQue even if one of the error conditions occur? Maybe the > > right thing to do is to return 0 in certain error cases...? >=20 > The win32 api=C2=A0 documentation does not mention anything about not ret= urning > proper device status as long as the function succeeds... >=20 > Anyhow in my pursuit for the truth I whipped up a small test program and > strace:d it (with some extra debug printout in fhandler_serial::ioctl) >=20 > =C2=A0127 2403456 [main] python2.7 1662 fhandler_serial::ioctl: 0 =3D ioc= tl(541B, > 0xFFFFBCB0) ev=3DC st.cbInQue=3D7 > =C2=A0 216 3406481 [main] python2.7 1662 fhandler_serial::ioctl: 0 =3D io= ctl(541B, > 0xFFFFBCB0) ev=3DC st.cbInQue=3DE > =C2=A0=C2=A0 90 4409676 [main] python2.7 1662 fhandler_serial::ioctl: 0 = =3D ioctl(541B, > 0xFFFFBCB0) ev=3DC st.cbInQue=3D15 > =C2=A0 141 5413027 [main] python2.7 1662 fhandler_serial::ioctl: 0 =3D io= ctl(541B, > 0xFFFFBCB0) ev=3DC st.cbInQue=3D1C > =C2=A0 129 6416204 [main] python2.7 1662 fhandler_serial::ioctl: 0 =3D io= ctl(541B, > 0xFFFFBCB0) ev=3DC st.cbInQue=3D23 > =C2=A0 121 7419254 [main] python2.7 1662 fhandler_serial::ioctl: 0 =3D io= ctl(541B, > 0xFFFFBCB0) ev=3DC st.cbInQue=3D2A > =C2=A0 203 8423829 [main] python2.7 1662 fhandler_serial::ioctl: 0 =3D io= ctl(541B, > 0xFFFFBCB0) ev=3DC st.cbInQue=3D31 > =C2=A0=C2=A0 89 9427183 [main] python2.7 1662 fhandler_serial::ioctl: 0 = =3D ioctl(541B, > 0xFFFFBCB0) ev=3DC st.cbInQue=3D38 > =C2=A0 131 10431271 [main] python2.7 1662 fhandler_serial::ioctl: 0 =3D i= octl(541B, > 0xFFFFBCB0) ev=3DC st.cbInQue=3D3F > =C2=A0 118 11435254 [main] python2.7 1662 fhandler_serial::ioctl: 0 =3D i= octl(541B, > 0xFFFFBCB0) ev=3DC st.cbInQue=3D46 >=20 > >=20 > > - Did you actually try if this fixes your problem? It's pretty > > simple to build the Cygwin DLL > > https://cygwin.com/faq.html#faq.programming.building-cygwin >=20 > I patched it yesterday and it solved the problem... >=20 > /Ake I pushed a patch. Thanks, Corinna --=20 Corinna Vinschen Cygwin Maintainer --1y/7ip9Z0l6NTTti Content-Type: application/pgp-signature; name="signature.asc" Content-length: 833 -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEoVYPmneWZnwT6kwF9TYGna5ET6AFAl5dL04ACgkQ9TYGna5E T6Cqlg/+KszZt+q0S+zEs7Rrfnm971VVrqfP9r2WJYXn2BUemDrfBufrXYGhNk3X xIXP5RfONEEt60IedxYS4WxJU2mogxkGN18SUiG7kcpUJNTjXNWVN94ppLfZOW/d zqS4Zi/mGFEz3G2tGZdHaRoBnDEzZdqUFWv/46SmqVxOGRPl6xxuhBhfbITKS73m v+OmMhbQH6OQ4Akkl8s5Kgq4ADIe79lU7/QqDmj9smy0X4HOAds6nZfC1RI0DhvX RECKcL+jlQ52f/b+/a7pi3BxGWruUhCaJmTiGpDW7ddGAdN17SRaoEBygOYW7jSq WinDukCtPxJ0RxVHNXKysvj71nAP/EGcOT6A7Z3j1V5JzcUvxUsyj6OOJLj8QiE1 rqoWSMklCcw3Sd/vQ+Akwp+hsuZzgcxUcBteA00YglE35IZ1Ysa6qN8P+liJNpPU CFqrEnxnLWFJl/EdtOfw4OBUb8LfUsPzmYbooVdBNPqhDDwVAYDCS80OurxZHgYt 60z5VQ7bsJa0CGLwYtS+HRmz95Hg884OdIe6fkwobi4b+N0ZaDIP8fyP6iA0cRzd vGeW8dmWBiSvew38KytROFnAz+zcdJeG0mehSusDnYLzfrKT8x33TUl/fy6vGweY uFhyAGGeIIEaYY1SqPV8lh+aarbqJQk43IAGQjM8ayXKcwVhRyo= =Sdtg -----END PGP SIGNATURE----- --1y/7ip9Z0l6NTTti--