From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mout.kundenserver.de (mout.kundenserver.de [212.227.17.24]) by sourceware.org (Postfix) with ESMTPS id 01F233858D35 for ; Mon, 6 Jul 2020 11:23:02 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 01F233858D35 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=cygwin.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=corinna-cygwin@cygwin.com Received: from calimero.vinschen.de ([217.91.18.234]) by mrelayeu.kundenserver.de (mreue109 [212.227.15.183]) with ESMTPSA (Nemesis) id 1MlNgx-1kdars2NxN-00llum; Mon, 06 Jul 2020 13:22:49 +0200 Received: by calimero.vinschen.de (Postfix, from userid 500) id 36794A80B98; Mon, 6 Jul 2020 13:22:47 +0200 (CEST) Date: Mon, 6 Jul 2020 13:22:47 +0200 From: Corinna Vinschen To: Josh Thompson Cc: Ken Brown , cygwin@cygwin.com, dev@vcl.apache.org Subject: Re: change in handling quotes in cygwin package from 3.1.4-1 to 3.1.5-1 Message-ID: <20200706112247.GD514059@calimero.vinschen.de> Reply-To: cygwin@cygwin.com Mail-Followup-To: Josh Thompson , Ken Brown , cygwin@cygwin.com, dev@vcl.apache.org References: <3394273.JRUgpOGd2y@dvr> <2825592.AUrzYYFGSl@dvr> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <2825592.AUrzYYFGSl@dvr> X-Provags-ID: V03:K1:dqOjkTSdP5FZTimE9onz5WhRBX6VGw7uEOOSzIy33CmFh6dUtJ0 CE0hs9Hd9/bNUjaSpdZ/9yyx1fyCEB6EAv3t0AWUtHrl3LQKrnjaKl831yxR8QUYM5Ftsa/ KrXvOqXzXi9ghI3sl94jh21eCky4Z2iDkfz7WaF2O9BjfE2qwLvplab/1zAoCipbuYgPFVZ AOB5Zy+0iggIx8239eWRA== X-UI-Out-Filterresults: notjunk:1;V03:K0:B2gFC/7Qiwg=:M2bLM0tjSRXA6n6atI9kCB HZR35DosYK83cY7sjIr/GjT+PwFc+4Ncl0pOLnBGwQkt0MYVco0AWiD6eZTf7kmbu4a+vWKls NaTeFaZmn0Kysp97pLF5+dTmu5NJzOMyQ6+9quHAhU2LyIRdxTrGzSXPMcAtvMiUcYkynX3hG XmBv3gCm4QhCL4abXtfUQvOWkiAmtF0uoXoVfGumkqOIwMpa0cC43v7fj+Oa9n9PNYEIgy9ET RGsspPh6Bj91QxxF94DuClnImaTXs/iblBDp6Cm2DDMJbG2866I470388f+CafwCqy6f1HlZm dvQ/hAoeqHTWhCN6iiOAx2KKOj8zI84cpy/p/KqZUeSGUbiaAoPGvfcqODMStfRc8aulGEEc+ r4h6XUo12iYX2e1YdeJUg/hl/oWSVsmNFTPHNdRoacRMDD2TmkeLLLDhURBg8vKXl87epvmY8 yCTJZBjcYx8C4gT92zJ7SmKFV/qGV6lWmuVAlrGCdm1VCBKTBmhVQHhgLoViswKyp7wmXx/HO nQebJTXi4REjCpvhs4j/ASQa5GxfAJ//4eVj2d1XPZwCHGAB3psF/1LlfWQTqtl8M3ypcuZTB GC8g72tOGK8ip6nt1fG/niiXWXi56FdPbvy12VVTnOBZqh/xzonDkRa9iN+8aG+47PssbKIfW rY+XwEj1RW//WN05ciUkXXngxa0B3M174ByIIsVvN3IbxNdy8S8E7YV70r4Ta7gDneB/86l0p veBPs64mMVc2GA+O0DNX/jqGwrdm/y66sdGEOrd4sIQRMJLkcLbuVHnTj2saKN77eJ1pjEydm a2tya3/8osTlKPKuxlfClb+fpsn51XSUStKO/1cds1DpAmB+Vnz6qPWy0Laut4Yy1JiQ75w X-Spam-Status: No, score=-97.5 required=5.0 tests=BAYES_00, GOOD_FROM_CORINNA_CYGWIN, JMQ_SPF_NEUTRAL, KAM_DMARC_STATUS, KAM_NUMSUBJECT, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NEUTRAL, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: cygwin@cygwin.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: General Cygwin discussions and problem reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 06 Jul 2020 11:23:04 -0000 On Jun 24 13:26, Josh Thompson wrote: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 > > On Monday, June 22, 2020 4:11:35 PM EDT Ken Brown wrote: > > On 6/15/2020 12:21 PM, Josh Thompson wrote: > > > We recently noticed a change in double quote (") handling that is causing > > > a > > > > > command we issue to fail. The command is: > > [...] > > > > > 3.1.4: > > > $ cmd.exe /c "echo \"" > > > " > > > > > > 3.1.5: > > > $ cmd.exe /c "echo \"" > > > \" > > > > I can confirm this change in behavior, and I thought it would be completely > > trivial to do a bisection to find the commit that caused it. Unfortunately, > > it seems that the issue is somehow tied up with the fact that the toolchain > > used for building the cygwin package was upgraded shortly after the release > > of 3.1.4. > > > > An attempt to rebuild 3.1.4 with the current toolchain fails because of some > > gcc/binutils changes. So I applied the attached patches, which were > > applied to the Cygwin git master shortly after the release of 3.1.4, in > > order to make the build succeed. > > > > After installing the rebuilt 3.1.4, however, the cmd.exe call above exhibits > > the "3.1.5" behavior rather than the "3.1.4" behavior. I can't see > > anything in the patches that would explain this. I thought maybe it was a > > compiler optimization problem, but rebuilding without optimization doesn't > > change anything. > > > > I'm stumped. > > > > Ken > > Hi Ken, > > Thanks for your testing on this and for following up. How strange - I totally > wouldn't have expected a toolchain upgrade to have changed how quotes get > handled. > > It sounds like it will be difficult to change the quote behavior. So, we'll > work to get VCL updated to handle the new behavior. I have a fix for that. It's a long standing bug, a buffer overrun, which seem to have had no effect pre-3.1.5 only because the older GCC toolchain had a subtily different stack allocation strategy. I uploaded developer snapshots to https://cygwin.com/snapshots/ for testing. Please give this a try and report back. If this fixes your problem, the bug is serious enough to qualify for a Cygwin 3.1.6 RSN. Thanks, Corinna -- Corinna Vinschen Cygwin Maintainer