From: Corinna Vinschen <corinna-cygwin@cygwin.com>
To: Josh Thompson <josh_thompson@ncsu.edu>
Cc: cygwin@cygwin.com, dev@vcl.apache.org
Subject: Re: change in handling quotes in cygwin package from 3.1.4-1 to 3.1.5-1
Date: Mon, 6 Jul 2020 20:15:49 +0200 [thread overview]
Message-ID: <20200706181549.GG514059@calimero.vinschen.de> (raw)
In-Reply-To: <3197699.QRb4To3urE@dvr>
On Jul 6 10:14, Josh Thompson wrote:
> > > On Monday, June 22, 2020 4:11:35 PM EDT Ken Brown wrote:
> > > > On 6/15/2020 12:21 PM, Josh Thompson wrote:
> > > > [...]
> > > > > 3.1.4:
> > > > > $ cmd.exe /c "echo \""
> > > > > "
> > > > >
> > > > > 3.1.5:
> > > > > $ cmd.exe /c "echo \""
> > > > > \"
> > > > [...]
> > > > After installing the rebuilt 3.1.4, however, the cmd.exe call above
> > > > exhibits the "3.1.5" behavior rather than the "3.1.4" behavior. I
> > > > can't see anything in the patches that would explain this. I thought
> > > > maybe it was a compiler optimization problem, but rebuilding without
> > > > optimization doesn't change anything.
> > > [...]
> > > It sounds like it will be difficult to change the quote behavior. So,
> > > we'll work to get VCL updated to handle the new behavior.
> >
> > I have a fix for that. It's a long standing bug, a buffer overrun,
> > which seem to have had no effect pre-3.1.5 only because the older GCC
> > toolchain had a subtily different stack allocation strategy.
> >
> > I uploaded developer snapshots to https://cygwin.com/snapshots/
> > for testing. Please give this a try and report back.
> >
> > If this fixes your problem, the bug is serious enough to qualify for
> > a Cygwin 3.1.6 RSN.
>
> Thank you for this! I can confirm that replacing cygwin1.dll with the
> cygwin1-20200706.dll that you uploaded to the snapshot site fixes the quote
> issue.
>
> I upgraded an installation I had to 3.1.5-1 and tested that I was seeing the
> problem by running
>
> cmd.exe /c "echo \""
> \"
>
> Next, I downloaded, uncompressed, and overwrote cygwin1.dll with
> cygwin1-20200706.dll and tested again
>
> cmd.exe /c "echo \""
> "
>
> Great job working through that issue.
Thanks for testing and confirming. Expect 3.1.6 in the next couple
of days.
Thanks,
Corinna
--
Corinna Vinschen
Cygwin Maintainer
next prev parent reply other threads:[~2020-07-06 18:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-15 16:21 Josh Thompson
2020-06-22 20:11 ` Ken Brown
2020-06-24 17:26 ` Josh Thompson
2020-07-06 11:22 ` Corinna Vinschen
2020-07-06 14:14 ` Josh Thompson
2020-07-06 18:15 ` Corinna Vinschen [this message]
2020-07-21 16:45 ` Josh Thompson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200706181549.GG514059@calimero.vinschen.de \
--to=corinna-cygwin@cygwin.com \
--cc=cygwin@cygwin.com \
--cc=dev@vcl.apache.org \
--cc=josh_thompson@ncsu.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).