From: Corinna Vinschen <corinna-cygwin@cygwin.com>
To: Marc Hoersken <info@marc-hoersken.de>
Cc: cygwin@cygwin.com
Subject: Re: [PATCH] Fix poll/select signal socket as write ready on connect failure
Date: Mon, 20 Jul 2020 09:55:58 +0200 [thread overview]
Message-ID: <20200720075558.GD16360@calimero.vinschen.de> (raw)
In-Reply-To: <7ec397c4-dc25-407c-7925-d61382e80f8a@marc-hoersken.de>
On Jul 17 21:33, Marc Hoersken via Cygwin wrote:
> Hi Corinna,
>
> Am 17.07.2020 um 21:21 schrieb Corinna Vinschen:
> > I don't agree here. The sole purpose for connect_errorcode is to set
> > SOL_SOCKET/SO_ERROR in case a caller requests FD_CONNECT and FD_CONNECT
> > is available. After being set once, SOL_SOCKET/SO_ERROR should not be
> > rewritten, given the description of SO_ERROR in `man 7 socket':
> >
> > SO_ERROR
> > Get and clear the pending socket error. This socket option is
> > ^^^^^^^^^
> > read-only. Expects an integer.
> >
> > [...]
> >
> > Make sense?
>
>
> yes, this makes sense. Please go for it.
Great, done!
> Is there a public changelog I can check regulary to see if this has been
> released (once it is)? Thanks!
git log? Or do you mean official Cygwin releases? The only public
changelog is the announcement on cygwin-announce in this case.
Thanks,
Corinna
--
Corinna Vinschen
Cygwin Maintainer
prev parent reply other threads:[~2020-07-20 7:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-15 18:54 Marc Hoersken
2020-07-16 9:25 ` Corinna Vinschen
2020-07-17 18:56 ` Marc Hoersken
2020-07-17 19:21 ` Corinna Vinschen
2020-07-17 19:33 ` Marc Hoersken
2020-07-20 7:55 ` Corinna Vinschen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200720075558.GD16360@calimero.vinschen.de \
--to=corinna-cygwin@cygwin.com \
--cc=cygwin@cygwin.com \
--cc=info@marc-hoersken.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).