public inbox for cygwin@cygwin.com
 help / color / mirror / Atom feed
From: Lemures Lemniscati <lemures.lemniscati@gmail.com>
To: cygwin@cygwin.com
Subject: cygport: calm can fail when BUILD_REQUIRES contains some newlines
Date: Mon, 03 Aug 2020 20:29:44 +0900	[thread overview]
Message-ID: <20200803202941.E3EE.50F79699@gmail.com> (raw)

Hi!

It may cause an issue when BUILD_REQUIRES contains some newlines in
a cygport file. 

Because cygport-0.34-1 generates *src.hint with raw BUILD_REQUIRES, and
extra newlines in 'build-depends' may be rejected by calm when uploading
packages.


This is a work-around patch by squeezing white spaces in BUILD_REQUIRES.

====

diff -ur a/cygport-0.34.0/lib/pkg_pkg.cygpart
b/cygport-0.34.0/lib/pkg_pkg.cygpart
--- a/cygport-0.34.0/lib/pkg_pkg.cygpart	2020-05-11 01:06:43.000000000 +0900
+++ b/cygport-0.34.0/lib/pkg_pkg.cygpart	2020-08-03 20:13:35.080509700 +0900
@@ -915,7 +915,7 @@
 		then
 			cat > ${distdir}/${PN}/${PN}-${PVR}-src.hint <<-_EOF
 category: ${!pkg_category_var:-${CATEGORY}}
-build-depends: cygport ${BUILD_REQUIRES}
+build-depends: $(printf "%s" "cygport ${BUILD_REQUIRES}" | sed -ze 's/[\t\n\f\r]/ /g;s/  */ /g;s/^ *//;s/ *$//')
 sdesc: "${!pkg_summary_var:-${SUMMARY}}"
 ldesc: "${!pkg_description_var:-${DESCRIPTION:-${!pkg_summary_var:-${SUMMARY}}}}"
 skip:


====

Regards, 

Lem

                 reply	other threads:[~2020-08-03 11:29 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200803202941.E3EE.50F79699@gmail.com \
    --to=lemures.lemniscati@gmail.com \
    --cc=cygwin@cygwin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).