From: Takashi Yano <takashi.yano@nifty.ne.jp>
To: cygwin@cygwin.com
Subject: Re: Cygwin doesn't handle SIGWINCH properly in Windows Terminal
Date: Tue, 16 Feb 2021 19:31:54 +0900 [thread overview]
Message-ID: <20210216193154.fd8d6268ce749983f565b058@nifty.ne.jp> (raw)
In-Reply-To: <20210214174358.f828f285a566846254c3c54a@nifty.ne.jp>
On Sun, 14 Feb 2021 17:43:58 +0900
Takashi Yano wrote:
> On Sat, 13 Feb 2021 20:39:39 +1000
> Alvin Seville wrote:
> > Windows build number: Win32NT 10.0.19042.0 Microsoft Windows NT 10.0.19042.0
> > Windows Terminal version (if applicable): 1.5.10271.0
> >
> > Script to reproduce this issue:
> >
> > #!/usr/bin/env bashfunction outputText()
> > {
> > local text=$1
> > local -i textLength=${#text}
> >
> > local -i line="$(tput lines) / 2"
> > local -i col="$(tput cols) / 2 - $textLength / 2"
> >
> > clear
> > echo -en "\e[$line;${col}H$text"
> > }
> > trap "outputText 'Hello world!'" SIGWINCH
> >
> > outputText 'Hello world!'while truedo
> > :done
>
> This is because cygwin console handles SIGWINCH when the input
> messages is processed. If the process does not call either read()
> or select(), SIGWINCH will not be sent. This is the long standing
> problem of the implementation and hard to fix.
I came up with a solution for this issue and implemented that.
It seems working as expected as far as I tested while I did not
have to change the code much contrary to my concern.
The point of the idea is to keep the basic structure of the
console code unchanged and introduce a new thread which handle
the only signals derived from input records. Handling of Ctrl-S
and Ctrl-Q also added.
I would like to submit the patch to cygwin-patches mailing list.
Corinna, could you please have a look?
--
Takashi Yano <takashi.yano@nifty.ne.jp>
next prev parent reply other threads:[~2021-02-16 10:32 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-13 10:39 Alvin Seville
2021-02-13 17:38 ` Brian Inglis
2021-02-14 8:43 ` Takashi Yano
2021-02-14 20:44 ` L A Walsh
2021-02-15 0:05 ` Takashi Yano
2021-02-16 2:17 ` L A Walsh
2021-02-16 5:48 ` Marco Atzeri
2021-02-16 6:20 ` Brian Inglis
2021-02-16 10:26 ` Thomas Wolff
2021-02-16 10:38 ` Thomas Wolff
2021-02-16 21:55 ` L A Walsh
2021-02-15 0:21 ` Takashi Yano
2021-02-16 10:31 ` Takashi Yano [this message]
2021-02-16 11:31 ` Takashi Yano
2021-02-16 16:26 ` Brian Inglis
2021-02-16 20:37 ` Takashi Yano
2021-02-16 20:50 ` Thomas Wolff
2021-02-16 22:11 ` Brian Inglis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210216193154.fd8d6268ce749983f565b058@nifty.ne.jp \
--to=takashi.yano@nifty.ne.jp \
--cc=cygwin@cygwin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).