From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from conssluserg-02.nifty.com (conssluserg-02.nifty.com [210.131.2.81]) by sourceware.org (Postfix) with ESMTPS id 3CF043857C5F for ; Fri, 19 Mar 2021 10:08:33 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 3CF043857C5F Received: from Express5800-S70 (y084061.dynamic.ppp.asahi-net.or.jp [118.243.84.61]) (authenticated) by conssluserg-02.nifty.com with ESMTP id 12JA868q003374 for ; Fri, 19 Mar 2021 19:08:07 +0900 DKIM-Filter: OpenDKIM Filter v2.10.3 conssluserg-02.nifty.com 12JA868q003374 X-Nifty-SrcIP: [118.243.84.61] Date: Fri, 19 Mar 2021 19:08:07 +0900 From: Takashi Yano To: cygwin@cygwin.com Subject: Re: stdin pipe rename in 3.2.0 Message-Id: <20210319190807.babb0c0312740f44e9119c17@nifty.ne.jp> In-Reply-To: References: X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.30; i686-pc-mingw32) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, KAM_NUMSUBJECT, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: cygwin@cygwin.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: General Cygwin discussions and problem reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Mar 2021 10:08:36 -0000 On Thu, 18 Mar 2021 21:28:40 +0100 Christoph Reiter wrote: > I noticed that the stdin pipe was renamed from > > "\msys-dd50a72ab4668b33-pty1-from-master" to > "\msys-dd50a72ab4668b33-pty0-to-slave" in > https://cygwin.com/git/?p=newlib-cygwin.git;a=commit;h=bb42852062073439 Actually, this is not renamed but newly introduced only for non-cygwin (native) apps. > This trips up https://github.com/k-takata/ptycheck to detect the > cygpty which is used in various code bases. If this change is affected, your process seems to be a non-cygwin process. > Is there a reason it was renamed? > > And while grepping I noticed the old name is still checked for in > other places like > https://cygwin.com/git/?p=newlib-cygwin.git;a=blob;f=winsup/cygwin/tty.cc;h=3c016315cdedb1dcca44cb3f3f96b87fd0b90a97;hb=HEAD#l162 > which seems weird. The name "from-master" is still used for cygwin processes. However, the naming was not appropriate. The name of output pipes are: "ptyNNNN-to-master-cyg" for cygwin process, and "ptyNNNN-to-master" for non-cygwin process. However, the name of input pipes are: "ptyNNNN-from-master" for cygwin process, and "ptyNNNN-to-slave" for non-cygwin process. This is not only consistent but also very confusing. I would like to rename these pipes to: "ptyNNNN-from-master-cyg" for cygwin process, "ptyNNNN-from-master" for non-cygwin process. Corinna, is it possble to apply the patch for 3.2.0 release? -- Takashi Yano