From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from conssluserg-06.nifty.com (conssluserg-06.nifty.com [210.131.2.91]) by sourceware.org (Postfix) with ESMTPS id 8D1BE3858D28 for ; Wed, 24 Nov 2021 03:41:08 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 8D1BE3858D28 Received: from Express5800-S70 (z221123.dynamic.ppp.asahi-net.or.jp [110.4.221.123]) (authenticated) by conssluserg-06.nifty.com with ESMTP id 1AO3ejln023550 for ; Wed, 24 Nov 2021 12:40:45 +0900 DKIM-Filter: OpenDKIM Filter v2.10.3 conssluserg-06.nifty.com 1AO3ejln023550 X-Nifty-SrcIP: [110.4.221.123] Date: Wed, 24 Nov 2021 12:40:55 +0900 From: Takashi Yano To: cygwin@cygwin.com Subject: Re: possible snprintf() regression in 3.3.2 Message-Id: <20211124124055.a90e254858b66d42aca6ecef@nifty.ne.jp> In-Reply-To: References: <20211118203538.a049809d57731fe375801c15@nifty.ne.jp> <7545bb24-43de-cd7d-0764-55c85f1af957@gmx.com> <20211121001613.GH10332@venus.tony.develop-help.com> <20211122232302.GI10332@venus.tony.develop-help.com> <20211123173409.0db4d5ccd94501ce1b8f69ea@nifty.ne.jp> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.30; i686-pc-mingw32) Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="Multipart=_Wed__24_Nov_2021_12_40_55_+0900_3DcUNHT0_HKTxpOV" X-Spam-Status: No, score=-5.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, KAM_LOTSOFHASH, KAM_NUMSUBJECT, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: cygwin@cygwin.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: General Cygwin discussions and problem reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 24 Nov 2021 03:41:11 -0000 This is a multi-part message in MIME format. --Multipart=_Wed__24_Nov_2021_12_40_55_+0900_3DcUNHT0_HKTxpOV Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Tue, 23 Nov 2021 10:48:21 +0100 Corinna Vinschen wrote: > On Nov 23 17:34, Takashi Yano via Cygwin wrote: > > However, in reality, for example in the case: > > snprintf(buf, sizeof(buf), "%.3f", 1234567890123456.789); > > 'ndigits' is only 3 even though total digits will be 20. > > > > So, Tony thinks current code does not correct. > > > > However, I think something is wrong with interpretation > > of 'ndigits' in dltoa.c. > > > > printf("%.3f\n", sqrt(2)*1e70); > > printf("%.50f\n", sqrt(2)*1e70); > > > > outputs > > > > 14142135623730951759073108307330633613786387000000000000000000000000000.000 > > 14142135623730951759073108307330633613786386978891021459448717416650727.13402790000888758223149296720949629080194006476078 > > > > Is this as intended? > > On Linux I see > > 14142135623730951759073108307330633613786387161811679011529922516615168.000 > 14142135623730951759073108307330633613786387161811679011529922516615168.00000000000000000000000000000000000000000000000000 > > The newlib output for .3f probably suffers from the fact that ldtoa > chooses the small buffer, which restricts the number of digits to 43 or > 44. But keep in mind that ldtoa *always* restricted the output to 42, > so you never got a more precise output anyway. Every digit beyond digit > 42 is only printed due to the bigger buffer sizes. > > So, what newlib and, in extension, Cygwin really needs at this point are > patches to the existing ldtoa or a change to gdtoa or equivalent. > > https://cygwin.com/acronyms/#SHTDI > https://cygwin.com/acronyms/#PTC The attached patch is the one which I think correct so far. With this patch: 14142135623730951759073108307330633613786386978891021459448717416650727.134 14142135623730951759073108307330633613786386978891021459448717416650727.13402790000888758223149296720949629080194006476078 Isn't this better than current behaviour? -- Takashi Yano --Multipart=_Wed__24_Nov_2021_12_40_55_+0900_3DcUNHT0_HKTxpOV Content-Type: application/octet-stream; name="ldtoa.patch" Content-Disposition: attachment; filename="ldtoa.patch" Content-Transfer-Encoding: base64 ZGlmZiAtLWdpdCBhL25ld2xpYi9saWJjL3N0ZGxpYi9sZHRvYS5jIGIvbmV3bGliL2xpYmMvc3Rk bGliL2xkdG9hLmMKaW5kZXggMWIzMmU4MDFjLi45NTM0N2UwMTcgMTAwNjQ0Ci0tLSBhL25ld2xp Yi9saWJjL3N0ZGxpYi9sZHRvYS5jCisrKyBiL25ld2xpYi9saWJjL3N0ZGxpYi9sZHRvYS5jCkBA IC04Myw3ICs4Myw3IEBAIHN0YXRpYyB2b2lkIGVjbGVhciAocmVnaXN0ZXIgc2hvcnQgdW5zaWdu ZWQgaW50ICp4KTsKIHN0YXRpYyB2b2lkIGVpbmZpbiAocmVnaXN0ZXIgc2hvcnQgdW5zaWduZWQg aW50ICp4LCByZWdpc3RlciBMRFBBUk1TICogbGRwKTsKIHN0YXRpYyB2b2lkIGVmbG9vciAoc2hv cnQgdW5zaWduZWQgaW50ICp4LCBzaG9ydCB1bnNpZ25lZCBpbnQgKnksCiAJCSAgICBMRFBBUk1T ICogbGRwKTsKLXN0YXRpYyB2b2lkIGV0b2FzYyAoc2hvcnQgdW5zaWduZWQgaW50ICp4LCBjaGFy ICpzdHJpbmcsIGludCBuZGlncywKK3N0YXRpYyB2b2lkIGV0b2FzYyAoc2hvcnQgdW5zaWduZWQg aW50ICp4LCBjaGFyICpzdHJpbmcsIGludCBuZGVjLCBpbnQgbmRpZ3MsCiAJCSAgICBpbnQgb3V0 Zm9ybWF0LCBMRFBBUk1TICogbGRwKTsKIAogdW5pb24gdWNvbnYKQEAgLTIxNyw3ICsyMTcsNyBA QCBzdGF0aWMgY29uc3QgY2hhciAqY29uc3QgZXJtc2dbN10gPSB7CiAgKgllMjR0b2FzYyggJmYs IHN0ciwgbiApCXNpbmdsZSB0byBBU0NJSSBzdHJpbmcsIG4gZGlnaXRzIGFmdGVyIGRlY2ltYWwK ICAqCWU1M3RvYXNjKCAmZCwgc3RyLCBuICkJZG91YmxlIHRvIEFTQ0lJIHN0cmluZywgbiBkaWdp dHMgYWZ0ZXIgZGVjaW1hbAogICoJZTY0dG9hc2MoICZkLCBzdHIsIG4gKQlsb25nIGRvdWJsZSB0 byBBU0NJSSBzdHJpbmcKLSAqCWV0b2FzYyhlLHN0cixuLGZtdCxsZHApZSB0byBBU0NJSSBzdHJp bmcsIG4gZGlnaXRzIGFmdGVyIGRlY2ltYWwKKyAqCWV0b2FzYyhlLHN0cixuZGVjLG4sZm10LGxk cCllIHRvIEFTQ0lJIHN0cmluZywgbiBkaWdpdHMgYWZ0ZXIgZGVjaW1hbAogICoJZXRvZTI0KCBl LCAmZiApCQljb252ZXJ0IGUgdHlwZSB0byBJRUVFIHNpbmdsZSBwcmVjaXNpb24KICAqCWV0b2U1 MyggZSwgJmQgKQkJY29udmVydCBlIHR5cGUgdG8gSUVFRSBkb3VibGUgcHJlY2lzaW9uCiAgKgll dG9lNjQoIGUsICZkICkJCWNvbnZlcnQgZSB0eXBlIHRvIElFRUUgbG9uZyBkb3VibGUgcHJlY2lz aW9uCkBAIC0yODM5LDIzICsyODM5LDMzIEBAIF9sZHRvYV9yIChzdHJ1Y3QgX3JlZW50ICpwdHIs IGxvbmcgZG91YmxlIGQsIGludCBtb2RlLCBpbnQgbmRpZ2l0cywKIAogLyogVGhpcyBzYW5pdHkg bGltaXQgbXVzdCBhZ3JlZSB3aXRoIHRoZSBjb3JyZXNwb25kaW5nIG9uZSBpbiBldG9hc2MsIHRv CiAgICBrZWVwIHN0cmFpZ2h0IHRoZSByZXR1cm5lZCB2YWx1ZSBvZiBvdXRleHBvbi4gIE5vdGUg dGhhdCB3ZSB1c2UgYSBkeW5hbWljCi0gICBsaW1pdCBub3csIGVpdGhlciBOREVDIG9yIE5ERUNf U01MLCBkZXBlbmRpbmcgb24gbmRpZ2l0cy4gIFNlZSB0aGUgdXNhZ2UKLSAgIG9mICJteV9OREVD IiBpbiBldG9hc2MuICovCi0gIGlmIChuZGlnaXRzID4gTkRFQykKLSAgICBuZGlnaXRzID0gTkRF QzsKKyAgIGxpbWl0IG5vdywgZWl0aGVyIG5kZWMgKDw9IE5ERUMpIG9yIE5ERUNfU01MLCBkZXBl bmRpbmcgb24gbmRpZ2l0cy4gKi8KKyAgaW50IG5kZWM7CisgIGlmIChtb2RlID09IDMpIC8qICVm ICovCisgICAgeworICAgICAgaW50IGV4cG9uID0gKGVbTkUgLSAxXSAmIDB4N2ZmZikgLSAoRVhP TkUgLSAxKTsgLyogZXhwb25lbnQgcGFydCAqLworICAgICAgLyogbG9nMigxMCkgYXBwcm94aW1h dGVseSA0ODUvMTQ2ICovCisgICAgICBuZGVjID0gZXhwb24gKiAxNDYgLyA0ODUgKyBuZGlnaXRz OworICAgIH0KKyAgZWxzZSAvKiAlZy8lZSAqLworICAgIG5kZWMgPSBuZGlnaXRzOworICBpZiAo bmRlYyA8IDApCisgICAgbmRlYyA9IDA7CisgIGlmIChuZGVjID4gTkRFQykKKyAgICBuZGVjID0g TkRFQzsKIAogICAvKiBBbGxvY2F0ZSBidWZmZXIgaWYgbW9yZSB0aGFuIE5ERUNfU01MIGRpZ2l0 cyBhcmUgcmVxdWVzdGVkLiAqLwotICBpZiAobmRpZ2l0cyA+IE5ERUNfU01MKQorICBpZiAobmRl YyA+IE5ERUNfU01MKQogICAgIHsKLSAgICAgIG91dGJ1ZiA9IChjaGFyICopIF9tYWxsb2NfciAo cHRyLCBOREVDICsgTUFYX0VYUF9ESUdJVFMgKyAxMCk7CisgICAgICBvdXRidWYgPSAoY2hhciAq KSBfbWFsbG9jX3IgKHB0ciwgbmRlYyArIE1BWF9FWFBfRElHSVRTICsgMTApOwogICAgICAgaWYg KCFvdXRidWYpCiAJewotCSAgbmRpZ2l0cyA9IE5ERUNfU01MOworCSAgbmRlYyA9IE5ERUNfU01M OwogCSAgb3V0YnVmID0gb3V0YnVmX3NtbDsKIAl9CiAgICAgfQogCi0gIGV0b2FzYyAoZSwgb3V0 YnVmLCBuZGlnaXRzLCBtb2RlLCBsZHApOworICBldG9hc2MgKGUsIG91dGJ1ZiwgbmRlYywgbmRp Z2l0cywgbW9kZSwgbGRwKTsKICAgcyA9IG91dGJ1ZjsKICAgaWYgKGVpc2luZiAoZSkgfHwgZWlz bmFuIChlKSkKICAgICB7CkBAIC0yOTkyLDggKzMwMDIsOCBAQCBfbGRjaGVjayAobG9uZyBkb3Vi bGUgKmQpCiB9CQkJCS8qIF9sZGNoZWNrICovCiAKIHN0YXRpYyB2b2lkCi1ldG9hc2MgKHNob3J0 IHVuc2lnbmVkIGludCAqeCwgY2hhciAqc3RyaW5nLCBpbnQgbmRpZ2l0cywgaW50IG91dGZvcm1h dCwKLQlMRFBBUk1TICogbGRwKQorZXRvYXNjIChzaG9ydCB1bnNpZ25lZCBpbnQgKngsIGNoYXIg KnN0cmluZywgaW50IG5kZWMsIGludCBuZGlnaXRzLAorCWludCBvdXRmb3JtYXQsIExEUEFSTVMg KiBsZHApCiB7CiAgIGxvbmcgZGlnaXQ7CiAgIHVuc2lnbmVkIHNob3J0IHlbTkldLCB0W05JXSwg dVtOSV0sIHdbTkldOwpAQCAtMzAwMyw3ICszMDEzLDYgQEAgZXRvYXNjIChzaG9ydCB1bnNpZ25l ZCBpbnQgKngsIGNoYXIgKnN0cmluZywgaW50IG5kaWdpdHMsIGludCBvdXRmb3JtYXQsCiAgIGNo YXIgKnMsICpzczsKICAgdW5zaWduZWQgc2hvcnQgbTsKICAgdW5zaWduZWQgc2hvcnQgKmVxdW90 ID0gbGRwLT5lcXVvdDsKLSAgaW50IG15X05ERUMgPSAobmRpZ2l0cyA+IE5ERUNfU01MKSA/IE5E RUMgOiBOREVDX1NNTDsKIAogICBuZGlncyA9IG5kaWdpdHM7CiAgIHJuZHNhdiA9IGxkcC0+cm5k cHJjOwpAQCAtMzEyOSw3ICszMTM4LDcgQEAgdG56cm86CiAgICAgICBlbHNlCiAJewogCSAgZW1v dmkgKHksIHcpOwotCSAgZm9yIChpID0gMDsgaSA8IG15X05ERUMgKyAxOyBpKyspCisJICBmb3Ig KGkgPSAwOyBpIDwgbmRlYyArIDE7IGkrKykKIAkgICAgewogCSAgICAgIGlmICgod1tOSSAtIDFd ICYgMHg3KSAhPSAwKQogCQlicmVhazsKQEAgLTMyMDUsOCArMzIxNCw4IEBAIGlzb25lOgogZWxz ZSBpZiggbmRpZ3MgPCAwICkKICAgICAgICAgbmRpZ3MgPSAwOwogKi8KLSAgaWYgKG5kaWdzID4g bXlfTkRFQykKLSAgICBuZGlncyA9IG15X05ERUM7CisgIGlmIChuZGlncyA+IG5kZWMpCisgICAg bmRpZ3MgPSBuZGVjOwogICBpZiAoZGlnaXQgPT0gMTApCiAgICAgewogICAgICAgKnMrKyA9ICcx JzsK --Multipart=_Wed__24_Nov_2021_12_40_55_+0900_3DcUNHT0_HKTxpOV--