From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lucy.dinwoodie.org (b.8.0.0.8.9.b.0.2.f.0.9.2.a.d.b.d.a.0.2.5.1.e.d.0.b.8.0.1.0.0.2.ip6.arpa [IPv6:2001:8b0:de15:20ad:bda2:90f2:b98:8b]) by sourceware.org (Postfix) with ESMTPS id A14313858402 for ; Fri, 25 Feb 2022 08:56:27 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org A14313858402 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=dinwoodie.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=dinwoodie.org Received: from adam by lucy.dinwoodie.org with local (Exim 4.94.2) (envelope-from ) id 1nNWOn-007WdD-Gn for cygwin@cygwin.com; Fri, 25 Feb 2022 08:56:25 +0000 Date: Fri, 25 Feb 2022 08:56:25 +0000 From: Adam Dinwoodie To: cygwin@cygwin.com Subject: Re: pcre regexps in git? Message-ID: <20220225085625.yfmiauyhxdradfzf@lucy.dinwoodie.org> Reply-To: cygwin@cygwin.com References: <20220224213229.berg5rjisexeuue3@lucy.dinwoodie.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220224213229.berg5rjisexeuue3@lucy.dinwoodie.org> X-Spam-Status: No, score=-0.8 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, PDS_RDNS_DYNAMIC_FP, RDNS_DYNAMIC, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: cygwin@cygwin.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: General Cygwin discussions and problem reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 Feb 2022 08:56:29 -0000 On Thu, Feb 24, 2022 at 09:32:29PM +0000, Adam Dinwoodie wrote: > On Thu, Feb 24, 2022 at 04:19:13PM -0500, Anthony Heading wrote: > > Hi, > > I appreciate this is just a birthday wish-list item, but... > > > > % git grep -P hopeful... > > fatal: cannot use Perl-compatible regexes when not compiled with USE_LIBPCRE > > > > It would be lovely (well, at least for me) if this could work. > > Huh. I think that used to work, so if it broke, it presumably broke > somewhere during the Cygwin Git build process wrangling I've been doing > of late. I'll see what I can do to get it working again for you! It looks like this actually broke some time ago, when the upstream Git project moved from using libpcre1 to libpcre2, which I didn't spot, and so didn't realise I needed to update the set of dependencies that are installed for building Git. Git's build-time config system is set up such that, if it can't find a library it wants but doesn't strictly need, it'll just silently carry on without it, so there's no indication that there's any function missing until someone notices and complains. So thank you, Anthony, for noticing and complaining! (The above is not entirely true: fairly recently upstream Git added -- after I pointed out exactly this problem with a different library -- the ability to tell the Git test suite that it should expect certain function to be available regardless of what libraries are installed. But I've not yet got around to setting that up for the Cygwin Git builds, and it's unlikely to have caught this problem anyway, since it predates that function being available.) Anyway, the key fix here should be pretty straightforward; I think it'll just be a case of rebuilding Git on a build server that has libpcre2 rather than libpcre1 installed. Currently the Git builds are failing for entirely unrelated reasons -- I understand the problem but I'm not yet certain what the right fix is -- but I'm currently expecting to be able to sort this all out within a week.