Re: keyboard problem under X and last snapshot (2022-03-01)

[Takashi Yano <takashi.yano@nifty.ne.jp>]

On Thu, 10 Mar 2022 18:10:31 +0900
Takashi Yano wrote:
> On Wed, 9 Mar 2022 22:24:45 +0100
> Denis Excoffier wrote:
> > I tried the last snapshot (dated 2022-03-01), which seems to work well, until i failed to launch X/Windows, giving the
> > following message in a Windows popup: Failed to activate virtual core keyboard: 2
> > 
> > Under the preceding snapshot (dated 2022-02-17) everything works perfectly.
> > 
> > Below the full content of the failing XWin.0.log. Any ideas?
> 
> I noticed this occurs after the commit:
> 
> commit 0ddf19d6ca6edf9edd7fc147124794fa9d5100e0
> Author: Takashi Yano <takashi.yano@nifty.ne.jp>
> Date:   Mon Feb 21 21:20:48 2022 +0900
> 
>     Cygwin: pty, console: Fix handle leak which occurs on exec() error.
> 
>     - This patch fixes the handle leak which occurs when exec() fails
>       with an error. The duplicated handles will be closed when the
>       exec'ed process is terminated. However, if exec() fails, the code
>       path does not reach to the code closing the duplicated handles.
>       To implement this fix more appropriately, the setup, cleanup and
>       closing pty codes which was previously located in spawn.cc are
>       encapsulated into the fhandler_pty_slave class functions.
> 
> Now, I am looking into this problem. Please wait a while.

I found the cause. The problem was access violation in the code
retrieving the pgid of the ctty.

I will submit a patch shortly.

-- 
Takashi Yano <takashi.yano@nifty.ne.jp>