Re: mintty crashes on Windows 7

[Takashi Yano <takashi.yano@nifty.ne.jp>]

On Fri, 6 May 2022 17:05:02 +0300
Orgad Shaneh wrote:
> On Fri, May 6, 2022 at 1:49 AM Takashi Yano <takashi.yano@nifty.ne.jp> wrote:
> > > Only bash in msys2 package fails.
> >
> > I identified the difference which causes the issue
> > between bash built from original source and msys2 bash.
> >
> > If --enable-readline and --with-installed-readline is specified
> > to configure, the problem causes even with bash built from original
> > source.
> >
> > Also, removing --with-installed-readline from configure and removing
> > READLINE_LDFLAGS= from make in PKGBUILD of MSYS2 bash package solves
> > the issue.
> >
> > So it seems to be a readline problem, not a bug in bash itself.
> 
> Adding @Johannes Schindelin to the loop.
> 
> Thanks for your investigation so far.
> 
> So how do we proceed, assuming MSYS project does want to use the
> installed readline? I checked the readline PKGBUILD, and it only has
> very basic patches, none of them looks suspicious.
> 
> Is (external) readline not used in cygwin/bash?

In cygwin the issue does not occur even with bash
configured with --enable-readline and --with-installed-readline.

> Do you suggest that there's a bug in readline, that your change in the
> runtime uncovered? Or is it the other way around?

I suspect it's the former.

> What might we break if we revert the part I referenced earlier in
> fhandler_tty.cc?

If you revert that commit, non-cygwin app recieves ctrl-c twice
in the following scenario.

1) Start mintty
2) Run cmd.exe
3) Run script command
4) Run non-cygwin app
5) Press ctrl-c

This is becase ctrl-c is processed by both mintty pty master
and script pty master.

-- 
Takashi Yano <takashi.yano@nifty.ne.jp>