From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dalaran.tastycake.net (dalaran.tastycake.net [IPv6:2001:ba8:0:1c0::1:1]) by sourceware.org (Postfix) with ESMTPS id 8D3C2385803D for ; Fri, 17 Jun 2022 07:20:25 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 8D3C2385803D Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=dinwoodie.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=dinwoodie.org Received: from b.8.0.0.8.9.b.0.2.f.0.9.2.a.d.b.d.a.0.2.5.1.e.d.0.b.8.0.1.0.0.2.ip6.arpa ([2001:8b0:de15:20ad:bda2:90f2:b98:8b] helo=lucy.dinwoodie.org) by dalaran.tastycake.net with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o26HH-0004oH-VV for cygwin@cygwin.com; Fri, 17 Jun 2022 08:20:23 +0100 Received: from adam by lucy.dinwoodie.org with local (Exim 4.94.2) (envelope-from ) id 1o26HH-002ZdF-0d for cygwin@cygwin.com; Fri, 17 Jun 2022 08:20:23 +0100 Date: Fri, 17 Jun 2022 08:20:22 +0100 From: Adam Dinwoodie To: cygwin@cygwin.com Subject: Re: unzip failure with files that contain colons Message-ID: <20220617072022.gqtwexwzcfrwoove@lucy.dinwoodie.org> Reply-To: cygwin@cygwin.com References: <20220615183007.7xchz44wwbx2gnio@lucy.dinwoodie.org> <20220617002939.65c772fc3504f992b6fcf4d9@nifty.ne.jp> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20220617002939.65c772fc3504f992b6fcf4d9@nifty.ne.jp> X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: cygwin@cygwin.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: General Cygwin discussions and problem reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 17 Jun 2022 07:20:28 -0000 On Fri, Jun 17, 2022 at 12:29:39AM +0900, Takashi Yano wrote: > On Thu, 16 Jun 2022 06:22:38 +0200 > Thomas Wolff wrote: > > Am 15.06.2022 um 20:30 schrieb Adam Dinwoodie: > > > Cygwin generally handles filenames with colons just fine, by mapping the > > > character to some higher Unicode character and remapping on the fly. > > > However Cygwin's `unzip` appears to have a bug: when unzipping an > > > archive that contains a filename with a colon, it replaces the colon > > > with an underscore. > > > > > > cygcheck.out and simple test script attached; expected behaviour from > > > running `bash unzip-bug.sh` is that you get an empty file called `a:b`, > > > but on Cygwin you instead get an empty file called `a_b`. > > It's an explicit #ifdef __CYGWIN__ in upstream unzip, file unix/unix.c, > > which transforms a bunch of characters. > > If I uncomment most of them (except \), all unpack fine: > > x0:z  x1z  x3|z  x4"z  x5?z  x6*z > > I have taken over the maintenance of unzip package, and > fix the problem in the updated unzip-6.0-18. > https://cygwin.com/pipermail/cygwin/2022-June/251653.html > > Please try. Confirmed fixed. Thank you for adopting this and the quick turnaround! Adam