public inbox for cygwin@cygwin.com
 help / color / mirror / Atom feed
From: Adam Dinwoodie <adam@dinwoodie.org>
To: cygwin@cygwin.com
Subject: Re: Outdated git-review package
Date: Wed, 20 Jul 2022 09:07:23 +0100	[thread overview]
Message-ID: <20220720080723.ijpszbv2yyjswc65@lucy.dinwoodie.org> (raw)
In-Reply-To: <PAXPR07MB7743BD3C99635A34A43E05218A899@PAXPR07MB7743.eurprd07.prod.outlook.com>

On Wed, Jul 13, 2022 at 08:44:22AM +0000, Oledzki, Maciej (Nokia - PL/Wroclaw) wrote:
> Hi,
> 
> Latest git-review package available in Cygwin repository (2.1.0-1) is not compatible with latest git package (2.37.0-1).
> Following error appears in during gerrit review:
> 
> Errors running git rebase -p -i remotes/gerrit/master
> fatal: --preserve-merges was replaced by --rebase-merges
> 
> This problem is fixed in git review 2.2.0:
> https://docs.opendev.org/opendev/git-review/latest/releasenotes.html#relnotes-2-2-0
> 
> It would be great if version 2.2.0 (or more recent) of git-review was available.

Marco, are you able to get this updated?  I've had a play with the
current cygport file, and it looks like the update works trivially,
although I haven't been able to set up a test environment to test it
locally.  My changes are at [0] if you want to see them, but I don't
think there's anything very interesting.

[0]: https://github.com/me-and/Cygwin-git-review/tree/prerelease

Maciej, it looks like you should be able to install this yourself from
PyPI or from the source itself.  Alternatively I've prepared a Cygwin
package that you should be able to install manually.

Options:

-   If you have an appropriate version of `python*-pip` installed, run

        python3 -m pip install git-review

-   If you want to install from source yourself, it's available at
    https://opendev.org/opendev/git-review

-   If you want to use my tentative Cygwin build, make sure you have
    the curl, python39 and python39-setuptools packages installed, and
    the git-review package _uninstalled_, then run:

        curl -L https://github.com/me-and/Cygwin-git-review/releases/download/v2.3.1-1-prerelease.10.1/git-review-2.3.1-1.tar.xz | tar -xJC/

    As above, I've not actually been able to test this package, so I
    can't provide any guarantees about it, but you're very welcome to
    give it a go!

HTH

Adam

  reply	other threads:[~2022-07-20  8:07 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-13  8:44 Oledzki, Maciej (Nokia - PL/Wroclaw)
2022-07-20  8:07 ` Adam Dinwoodie [this message]
2022-07-20 18:36   ` Marco Atzeri
2022-07-23 15:31     ` Adam Dinwoodie
  -- strict thread matches above, loose matches on Subject: below --
2021-05-18 11:22 Oledzki, Maciej (Nokia - PL/Wroclaw)
2021-05-18 19:52 ` Marco Atzeri
2021-05-19  8:50   ` Oledzki, Maciej (Nokia - PL/Wroclaw)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220720080723.ijpszbv2yyjswc65@lucy.dinwoodie.org \
    --to=adam@dinwoodie.org \
    --cc=cygwin@cygwin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).