public inbox for cygwin@cygwin.com
 help / color / mirror / Atom feed
From: Adam Dinwoodie <adam@dinwoodie.org>
To: cygwin@cygwin.com
Subject: Re: single key stroke `git add -p` bug
Date: Thu, 25 Aug 2022 11:34:45 +0100	[thread overview]
Message-ID: <20220825103445.j67sjtwmea4sfkoy@lucy.dinwoodie.org> (raw)
In-Reply-To: <fc4f96c5a3724e69932ffb0120f55a5a@grupawp.pl>

On Thu, Aug 25, 2022 at 01:17:28AM +0200, trashyankes wrote:
> Hello   I update recently all cygwin packages and after that `git add
> -p` stop working correctly.  (previous update I did around 2 month
> ago)  I use mintty on Windows 10 x64, and have set `git config
> --global interactive.singlekey true` when I run this command whole
> terminal freeze and show message from git:  ```  warning: reading
> single keystrokes not supported on this platform; reading line instead
> ```  mintty stop accepting any input even `Ctrl-C`.   I tried to
> revert mintty and git to older version but every one available have
> same behavior.  For now disabling `singlekey` make this git operation
> work again but this is big lose in productivity.

Confirmed.  I'm not sure what's going wrong here: as I understand it,
this function depends on the Term::ReadKey Perl module, provided by the
Cygwin perl-TermReadKey package, but that package is correctly listed as
both a buildtime and runtime dependency for the git package.

I'll add to my queue to do some more debugging, but I'm not expecting to
have time to do any serious investigation here for a while.  Obviously
if anyone else is able to identify the problem, I'm very happy to
consider patches!

Adam
(Cygwin Git maintainer)

  parent reply	other threads:[~2022-08-25 10:34 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-24 23:17 trashyankes
2022-08-24 23:17 ` trashyankes
2022-08-25 10:34 ` Adam Dinwoodie [this message]
2022-08-25 20:07 trashyankes
2022-08-25 20:07 ` trashyankes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220825103445.j67sjtwmea4sfkoy@lucy.dinwoodie.org \
    --to=adam@dinwoodie.org \
    --cc=cygwin@cygwin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).