From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from conssluserg-04.nifty.com (conssluserg-04.nifty.com [210.131.2.83]) by sourceware.org (Postfix) with ESMTPS id 280433858D32 for ; Mon, 2 Jan 2023 02:32:28 +0000 (GMT) Received: from HP-Z230 (aj135041.dynamic.ppp.asahi-net.or.jp [220.150.135.41]) (authenticated) by conssluserg-04.nifty.com with ESMTP id 3022W0VG016295 for ; Mon, 2 Jan 2023 11:32:01 +0900 DKIM-Filter: OpenDKIM Filter v2.10.3 conssluserg-04.nifty.com 3022W0VG016295 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.ne.jp; s=dec2015msa; t=1672626721; bh=EouH69eluPX5tD90wchCFWkMGZZw+yt4mmUZuGhv8Uk=; h=Date:From:To:Subject:In-Reply-To:References:From; b=xN619aCwvO+X3sm9y1wAVv3Pj2rJnMNBXKAHNt5G1lBCLnsxWXAunJztMhrnVJgps uo/ZRx0XSZr8MwXkvcZau5/AktJPHQNX3OFSLQ71O37h6DV+SuwGQVuPwBq5z/vszi yEWB972YpwFRjQXupGOQ5F14ZF+Iq4mPe5fjxbrXEVcqMYV2PGzAtpO+Do5XTKRV5P xxPvvGOvXR0Sl4xYBK0ATwa7PzDs77QPlnYJV2If2xQ+UwDYuSBklL5knFCZzPwPtk VbQH131FSWAwGRh1I32q4DIMLAFhoE2ALwle25gohyMVEfY4XAdBx3rp9MEz574gCo Zd31R70SeWBnQ== X-Nifty-SrcIP: [220.150.135.41] Date: Mon, 2 Jan 2023 11:32:01 +0900 From: Takashi Yano To: cygwin@cygwin.com Subject: Re: Cygwin 3.4.3 and 3.5.0... hangs in make, top, procps, ls /proc/PID/... Message-Id: <20230102113201.476c10bef7a5643bddc00762@nifty.ne.jp> In-Reply-To: <4a4427cc-422b-1d14-015e-26523e620d9b@Shaw.ca> References: <4a4427cc-422b-1d14-015e-26523e620d9b@Shaw.ca> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.30; i686-pc-mingw32) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-12.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Thu, 29 Dec 2022 21:59:45 -0700 Brian Inglis wrote: > I got some hangs (deadlock?) between (parallel?) make jobs, top, procps, and > even ls /proc/*/ when trying to cygport all check curl or look at the process > statuses when builds hung under Cygwin 3.4.3 and 3.5.0-0.69... > > Had to revert to a Cygwin 3.4.0-344 test build from Dec 16 sources to build and > check curl etc. > > Only external differences seems to be recent dll sizes are *MUCH* smaller: > > $ ls -glort /bin/cygwin1*.dll > -rwxr-xr-x 1 3588124 Sep 5 05:17 /bin/cygwin1-prev.dll > -rwxr-xr-x 1 3561202 Dec 16 00:33 /bin/cygwin1-test.dll > -rwxr-xr-x 1 3561202 Dec 16 00:33 /bin/cygwin1.dll > -rwxr-xr-x 1 2951221 Dec 16 05:50 /bin/cygwin1-save.dll > -rwxr-xr-x 1 2951221 Dec 16 05:50 /bin/cygwin1-curr.dll > -rwxr-xr-x 1 2940981 Dec 23 03:03 /bin/cygwin1-69.dll > > and tars: > -rwxr-xr-x 1 3563651 2022-12-04 06:09 usr/bin/cygwin1.dll cygwin-3.4.0-1 > -rwxr-xr-x 1 3563526 2022-12-10 13:12 usr/bin/cygwin1.dll cygwin-3.4.1-1 > -rwxr-xr-x 1 3564074 2022-12-11 05:06 usr/bin/cygwin1.dll cygwin-3.4.2-1 > -rwxr-xr-x 1 2951221 2022-12-16 05:50 usr/bin/cygwin1.dll cygwin-3.4.3-1 > -rwxr-xr-x 1 2940981 2022-12-23 03:03 usr/bin/cygwin1.dll cygwin-3.5.0-0.69... > > Anyone seen this issue or anything come to mind to cause or help diagnose this? > > Running MS Win 10.0.19044.2364 21H2 patched to date. I have looked into this issue a bit, and found that q->sigtls becomes sometimes NULL and access violation occurs at the following code. winsup/cygwin/sigproc.cc: 1378 if (q->sigtls->sigmask & (bit = SIGTOMASK (q->si.si_signo))) { tl_entry = cygheap->find_tls (q->si.si_signo, issig_wait); I'm not sure why this happens, however it seems that the following patch fixes the issue. diff --git a/winsup/cygwin/sigproc.cc b/winsup/cygwin/sigproc.cc index ce36c8be3..90eaa2a47 100644 --- a/winsup/cygwin/sigproc.cc +++ b/winsup/cygwin/sigproc.cc @@ -1375,6 +1375,8 @@ wait_sig (VOID *) *pack.mask = 0; while ((q = q->next)) { + if (q->sigtls == NULL) + continue; if (q->sigtls->sigmask & (bit = SIGTOMASK (q->si.si_signo))) { tl_entry = cygheap->find_tls (q->si.si_signo, issig_wait); Corinna, could you please have a look? On Sat, 31 Dec 2022 13:01:29 -0700 Brian Inglis wrote: > was also getting the messages below locally and still on GitHub scallywag: > > cygcheck (6936) child_copy: cygheap read copy failed, > > ../curl/scallywag/1_x86_64 build.log:2022-12-26T00:39:35.6163236Z 0 > [main] cygcheck (6936) child_copy: cygheap read copy failed, 0x0..0x80003B5F0, > done 0, windows pid 6936, Win32 error 299 > ../curl/scallywag/1_x86_64 build.log:2022-12-26T00:48:03.4525278Z 0 > [main] cygcheck (568) child_copy: cygheap read copy failed, 0x0..0x80003BA48, > done 0, windows pid 568, Win32 error 299 > ../dialog/scallywag/1_x86_64 build.log:2022-12-31T18:42:37.0939902Z 0 > [main] cygcheck (6992) child_copy: cygheap read copy failed, 0x0..0x80003CB38, > done 0, windows pid 6992, Win32 error 299 I guess this is another problem. -- Takashi Yano