From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from conssluserg-02.nifty.com (conssluserg-02.nifty.com [210.131.2.81]) by sourceware.org (Postfix) with ESMTPS id 840893858D39 for ; Mon, 2 Jan 2023 08:22:03 +0000 (GMT) Received: from HP-Z230 (aj135041.dynamic.ppp.asahi-net.or.jp [220.150.135.41]) (authenticated) by conssluserg-02.nifty.com with ESMTP id 3028Lkr3020840 for ; Mon, 2 Jan 2023 17:21:47 +0900 DKIM-Filter: OpenDKIM Filter v2.10.3 conssluserg-02.nifty.com 3028Lkr3020840 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.ne.jp; s=dec2015msa; t=1672647707; bh=Rsawj7UzEtwGRsNkWmcdJvZR6K/5mn13TAyGC2HJ2RY=; h=Date:From:To:Subject:In-Reply-To:References:From; b=uj9HrX0F23gTJcBvERS+rNU5Ho/37dFZqBpBYqpWVuUzVrRjV3o3I263UJWyppTyI 8u+uvYwnhTrQu+ANTeFcmejJTz7hDIkXFiecCK/+kayMFFwLBHxjFJuLiG0Cbeb3ob 5CN/TYhIcUpXi3v8MGtzvxweQnjI1XWzhs0nlQEcW2AjS/SjR+Un2JuAF/OI0AYbmW +/FZ8mS3Z7uPPZKK4c7dchx0CtM5822kdue2T1dafPw9j+1cIOSxV0fkgHo6IT3ePx NDpr09E/+QAu3B42hevzds5cZ1qbzzER/hhJIG64AHprRVQtuQdbRz/sqyA+IhKkJ0 GXVDz0tJcYN5Q== X-Nifty-SrcIP: [220.150.135.41] Date: Mon, 2 Jan 2023 17:21:47 +0900 From: Takashi Yano To: cygwin@cygwin.com Subject: Re: Cygwin 3.4.3 and 3.5.0... hangs in make, top, procps, ls /proc/PID/... Message-Id: <20230102172147.83789d400bb0400cb8c8ca74@nifty.ne.jp> In-Reply-To: <20230102143803.53f89d07a545a1bdd596e1e8@nifty.ne.jp> References: <4a4427cc-422b-1d14-015e-26523e620d9b@Shaw.ca> <20230102113201.476c10bef7a5643bddc00762@nifty.ne.jp> <20230102143803.53f89d07a545a1bdd596e1e8@nifty.ne.jp> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.30; i686-pc-mingw32) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-12.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Mon, 2 Jan 2023 14:38:03 +0900 Takashi Yano wrote: > On Mon, 2 Jan 2023 11:32:01 +0900 > Takashi Yano wrote: > > On Sat, 31 Dec 2022 13:01:29 -0700 > > Brian Inglis wrote: > > > was also getting the messages below locally and still on GitHub scallywag: > > > > > > cygcheck (6936) child_copy: cygheap read copy failed, > > > > > > ../curl/scallywag/1_x86_64 build.log:2022-12-26T00:39:35.6163236Z 0 > > > [main] cygcheck (6936) child_copy: cygheap read copy failed, 0x0..0x80003B5F0, > > > done 0, windows pid 6936, Win32 error 299 > > > ../curl/scallywag/1_x86_64 build.log:2022-12-26T00:48:03.4525278Z 0 > > > [main] cygcheck (568) child_copy: cygheap read copy failed, 0x0..0x80003BA48, > > > done 0, windows pid 568, Win32 error 299 > > > ../dialog/scallywag/1_x86_64 build.log:2022-12-31T18:42:37.0939902Z 0 > > > [main] cygcheck (6992) child_copy: cygheap read copy failed, 0x0..0x80003CB38, > > > done 0, windows pid 6992, Win32 error 299 > > > > I guess this is another problem. > > I found this issue occurs after the commit 30add3e6b3e3: > "Cygwin: exec: don't access cygheap before it's initialized" > . > > Reverting this commit solves the issue. > > To reproduce the problem relatively frequently, try: > while true; do cygcheck -cd cygwin > /dev/null; done > in bash. > > Corinna, could you please have a look at this issue as well? I'm not sure if this is the right thing, but the following patch seems to fix the issue. diff --git a/winsup/cygwin/dcrt0.cc b/winsup/cygwin/dcrt0.cc index 5c5a280cc..49b7a44ae 100644 --- a/winsup/cygwin/dcrt0.cc +++ b/winsup/cygwin/dcrt0.cc @@ -631,8 +631,6 @@ child_info_spawn::handle_spawn () if (!dynamically_loaded || get_parent_handle ()) { cygheap_fixup_in_child (true); - if (dynamically_loaded) - moreinfo->myself_pinfo = NULL; memory_init (); } diff --git a/winsup/cygwin/mm/cygheap.cc b/winsup/cygwin/mm/cygheap.cc index 72861d8d7..6a20c159a 100644 --- a/winsup/cygwin/mm/cygheap.cc +++ b/winsup/cygwin/mm/cygheap.cc @@ -95,6 +95,8 @@ cygheap_fixup_in_child (bool execed) cygheap = (init_cygheap *) VirtualAlloc ((LPVOID) CYGHEAP_STORAGE_LOW, commit_size, MEM_COMMIT, PAGE_READWRITE); + if (dynamically_loaded && execed) + spawn_info->moreinfo->myself_pinfo = NULL; cygheap_max = child_proc_info->cygheap_max; child_copy (child_proc_info->parent, false, child_proc_info->silentfail (), "cygheap", cygheap, cygheap_max, NULL); -- Takashi Yano