From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from conssluserg-05.nifty.com (conssluserg-05.nifty.com [210.131.2.90]) by sourceware.org (Postfix) with ESMTPS id 168543858D32 for ; Mon, 2 Jan 2023 23:04:19 +0000 (GMT) Received: from HP-Z230 (aj135041.dynamic.ppp.asahi-net.or.jp [220.150.135.41]) (authenticated) by conssluserg-05.nifty.com with ESMTP id 302N3nuT021834 for ; Tue, 3 Jan 2023 08:03:49 +0900 DKIM-Filter: OpenDKIM Filter v2.10.3 conssluserg-05.nifty.com 302N3nuT021834 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.ne.jp; s=dec2015msa; t=1672700629; bh=ISdpIfN//dRgVtrEcaAuAorl6bQQ0+DeVAiO/mRYHGg=; h=Date:From:To:Subject:In-Reply-To:References:From; b=RMmrHZNw6nOSknQuURKCxt/cMwhJ7bt5cbaWUt8ECZ/N9m/kc+PjvOhtsmpDgAIWM 52hfjsVHOYmQDoVKR8W5gaufS1psWijZg55s6QXxKAXuxY8BzqgQo7aLQ8iKKt+hoh 9+imaa/kPz7OfDTWUIK4q/EgNVqjDV5EtNcATj86BlbPGpMfQntY6qadJcMe7cZhRZ sfk0PgxQTQDkJujF5+uqTw8d75rSpdOTj7eWdsZvnDNRo6qJ9yo9EcCH+bUXEL/XzW uqLPBFDBpXXmM4+kLWsbHkMCY70YHQh8F9kJTIcvxyIpZ69QfyWjECFjmXZdX3Z1kN K9Jshw1OaqwMA== X-Nifty-SrcIP: [220.150.135.41] Date: Tue, 3 Jan 2023 08:03:50 +0900 From: Takashi Yano To: cygwin@cygwin.com Subject: Re: Cygwin 3.4.3 and 3.5.0... hangs in make, top, procps, ls /proc/PID/... Message-Id: <20230103080350.04a8f6cd63854e0a49f8942d@nifty.ne.jp> In-Reply-To: <20230102113201.476c10bef7a5643bddc00762@nifty.ne.jp> References: <4a4427cc-422b-1d14-015e-26523e620d9b@Shaw.ca> <20230102113201.476c10bef7a5643bddc00762@nifty.ne.jp> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.30; i686-pc-mingw32) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-12.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Mon, 2 Jan 2023 11:32:01 +0900 Takashi Yano wrote: > On Thu, 29 Dec 2022 21:59:45 -0700 > Brian Inglis wrote: > > I got some hangs (deadlock?) between (parallel?) make jobs, top, procps, and > > even ls /proc/*/ when trying to cygport all check curl or look at the process > > statuses when builds hung under Cygwin 3.4.3 and 3.5.0-0.69... > > > > Had to revert to a Cygwin 3.4.0-344 test build from Dec 16 sources to build and > > check curl etc. > > > > Only external differences seems to be recent dll sizes are *MUCH* smaller: > > > > $ ls -glort /bin/cygwin1*.dll > > -rwxr-xr-x 1 3588124 Sep 5 05:17 /bin/cygwin1-prev.dll > > -rwxr-xr-x 1 3561202 Dec 16 00:33 /bin/cygwin1-test.dll > > -rwxr-xr-x 1 3561202 Dec 16 00:33 /bin/cygwin1.dll > > -rwxr-xr-x 1 2951221 Dec 16 05:50 /bin/cygwin1-save.dll > > -rwxr-xr-x 1 2951221 Dec 16 05:50 /bin/cygwin1-curr.dll > > -rwxr-xr-x 1 2940981 Dec 23 03:03 /bin/cygwin1-69.dll > > > > and tars: > > -rwxr-xr-x 1 3563651 2022-12-04 06:09 usr/bin/cygwin1.dll cygwin-3.4.0-1 > > -rwxr-xr-x 1 3563526 2022-12-10 13:12 usr/bin/cygwin1.dll cygwin-3.4.1-1 > > -rwxr-xr-x 1 3564074 2022-12-11 05:06 usr/bin/cygwin1.dll cygwin-3.4.2-1 > > -rwxr-xr-x 1 2951221 2022-12-16 05:50 usr/bin/cygwin1.dll cygwin-3.4.3-1 > > -rwxr-xr-x 1 2940981 2022-12-23 03:03 usr/bin/cygwin1.dll cygwin-3.5.0-0.69... > > > > Anyone seen this issue or anything come to mind to cause or help diagnose this? > > > > Running MS Win 10.0.19044.2364 21H2 patched to date. > > I have looked into this issue a bit, and found that > q->sigtls becomes sometimes NULL and access violation > occurs at the following code. > > winsup/cygwin/sigproc.cc: 1378 > if (q->sigtls->sigmask & (bit = SIGTOMASK (q->si.si_signo))) > { > tl_entry = cygheap->find_tls (q->si.si_signo, issig_wait); > > I'm not sure why this happens, however it seems that > the following patch fixes the issue. > > diff --git a/winsup/cygwin/sigproc.cc b/winsup/cygwin/sigproc.cc > index ce36c8be3..90eaa2a47 100644 > --- a/winsup/cygwin/sigproc.cc > +++ b/winsup/cygwin/sigproc.cc > @@ -1375,6 +1375,8 @@ wait_sig (VOID *) > *pack.mask = 0; > while ((q = q->next)) > { > + if (q->sigtls == NULL) > + continue; > if (q->sigtls->sigmask & (bit = SIGTOMASK (q->si.si_signo))) > { > tl_entry = cygheap->find_tls (q->si.si_signo, issig_wait); > > Corinna, could you please have a look? Do we need to guard here as well? case __SIGPENDING: { unsigned bit; *pack.mask = 0; tl_entry = cygheap->find_tls (pack.sigtls); while ((q = q->next)) { /* Skip thread-specific signals for other threads. */ if (q->sigtls && pack.sigtls != q->sigtls) continue; -------> if (pack.sigtls->sigmask & (bit = SIGTOMASK (q->si.si_signo))) *pack.mask |= bit; } cygheap->unlock_tls (tl_entry); } break; -- Takashi Yano