public inbox for cygwin@cygwin.com
 help / color / mirror / Atom feed
From: Marco Atzeri <marco.atzeri@gmail.com>
To: cygwin@cygwin.com
Subject: Re: R does not handle package non-ASCII DESCRIPTION files properly
Date: Fri, 1 May 2020 12:44:31 +0200	[thread overview]
Message-ID: <22ac49be-c6af-12ef-7f93-56b7151d08a3@gmail.com> (raw)
In-Reply-To: <129c4e64-4051-0cc2-0706-c39eaacbdc9e@gmail.com>

Am 30.04.2020 um 22:17 schrieb Marco Atzeri:
> Am 30.04.2020 um 17:28 schrieb Markus Hoenicka:
>> Hi,
>>
>> I've contacted the processx package maintainer on a problem reported 
>> here previously (see 
>> https://cygwin.com/pipermail/cygwin/2020-April/244667.html). He 
>> suggested to try the github version but that triggered a different 
>> type of error which does not seem to be package-specific.

the original problem is caused by the lack of $(LIBR)
after $(CLIENT_OBJECTS) in src/Makevars

Cygwin as Windows need the link library after the objects.

$ grep SHLIB_LINK Makevars*
Makevars:       $(SHLIB_LINK) -o client$(SHLIB_EXT) $(CLIENT_OBJECTS) 
$(PKG_LIBS)
Makevars.win:   $(SHLIB_LINK) -o client$(SHLIB_EXT) $(CLIENT_OBJECTS) 
$(LIBR) $(SHLIB_LIBADD) $(PKG_LIBS)


the documentations

https://cran.r-project.org/doc/manuals/r-release/R-exts.html#Using-Makevars

suggest the form

$(SHLIB): $(OBJECTS)
         $(SHLIB_LINK) -o $ $(OBJECTS) $(ALL_LIBS)

and this should work as
  /usr/lib/R/etc/Makeconf
defines

ALL_LIBS = $(PKG_LIBS) $(SHLIB_LIBADD) $(LIBR) $(LIBINTL) $(LIBS)


so try with
$(SHLIB_LINK) -o client$(SHLIB_EXT) $(CLIENT_OBJECTS) $(ALL_LIBS)

  reply	other threads:[~2020-05-01 10:44 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-30 15:28 Markus Hoenicka
2020-04-30 20:17 ` Marco Atzeri
2020-05-01 10:44   ` Marco Atzeri [this message]
2020-05-04 11:20     ` Markus Hoenicka
2020-05-05  8:47   ` Markus Hoenicka
2020-05-05 14:55     ` Brian Inglis
2020-05-05 16:25       ` Marco Atzeri

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=22ac49be-c6af-12ef-7f93-56b7151d08a3@gmail.com \
    --to=marco.atzeri@gmail.com \
    --cc=cygwin@cygwin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).