From: Shaddy Baddah <lithium-cygwin@shaddybaddah.name>
To: cygwin@cygwin.com
Subject: Re: ssh-host-config: patch fix debug option + broken for me on Vista (non-domain)
Date: Thu, 19 Jan 2017 11:26:00 -0000 [thread overview]
Message-ID: <2cb5cd97-a711-8d11-c07a-2534ee67298b@shaddybaddah.name> (raw)
In-Reply-To: <20170119103840.GD13008@calimero.vinschen.de>
Hi,
On 19/01/17 21:38, Corinna Vinschen wrote:
> On Jan 18 14:34, Shaddy Baddah wrote:
...
>> And I'm sure the problem is that this well-intended change to the script
>> fails on the assumption that LOGONSERVER is always populated. It isn't
>> for me on Vista.
>>
>> cygwin-service-installation-helper.sh:2884: # This test succeeds on
>> domain member machines only, not on DCs.
>> cygwin-service-installation-helper.sh:2885: if [
>> "\\\\${COMPUTERNAME,,*}" != "${LOGONSERVER,,*}" \
>> cygwin-service-installation-helper.sh:2886: -a "${LOGONSERVER}" !=
>> "\\\\MicrosoftAccount" ]
>> cygwin-service-installation-helper.sh:2887: then
>> cygwin-service-installation-helper.sh:2888: # Lowercase of USERDOMAIN
>> cygwin-service-installation-helper.sh:2889:
>> csih_PRIVILEGED_USERNAME="${COMPUTERNAME,,*}+${username}"
>> cygwin-service-installation-helper.sh:2890: fi
>> cygwin-service-installation-helper.sh:2891: fi
>>
>> I fixed this by modifying the test to check LOGONSERVER is not empty:
>>
>> if [ -n "${LOGONSERVER}" -a "\\\\...
>>
>> Can this be fixed in the next release?
>
> Sure, please provide a patch, I'll check it in and release a new csih
> soonish.
I would, but there's a couple of hitches. Without understanding the
syntax (and I should bring up the bash man page here, I will do after
this), I can't be sure that the following test:
"\\\\${COMPUTERNAME,,*}" != "${LOGONSERVER,,*}"
wasn't designed to handled an empty LOGONSERVER variable. Though it
looks to me that it is a binary test (i.e. handling both variables being
empty).
And secondly, I am not sure that chucking in the -n "${LOGONSERVER}"
test is safe in a Vista domain environment. From the comment about the
line, it seems like the original author of those lines, whomever that
may be, might have a strong understanding to make the modification.
But that's not constructive on my part. I'll come up with a patch in the
next 24 hours (it is late where I am now).
--
Regards,
Shaddy
>
>
> Thanks,
> Corinna
>
--
Problem reports: http://cygwin.com/problems.html
FAQ: http://cygwin.com/faq/
Documentation: http://cygwin.com/docs.html
Unsubscribe info: http://cygwin.com/ml/#unsubscribe-simple
next prev parent reply other threads:[~2017-01-19 11:26 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-18 3:34 Shaddy Baddah
2017-01-18 3:38 ` Shaddy Baddah
2017-01-19 10:38 ` Corinna Vinschen
2017-01-19 11:26 ` Shaddy Baddah [this message]
2017-01-19 18:16 ` Corinna Vinschen
2017-01-20 22:40 ` szgyg
2017-01-23 3:13 ` Shaddy Baddah
2017-01-23 10:19 ` Corinna Vinschen
2017-01-23 19:50 ` Achim Gratz
2017-01-23 20:19 ` Wells, Roger K.
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2cb5cd97-a711-8d11-c07a-2534ee67298b@shaddybaddah.name \
--to=lithium-cygwin@shaddybaddah.name \
--cc=cygwin@cygwin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).