From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 33813 invoked by alias); 19 Jan 2017 11:26:52 -0000 Mailing-List: contact cygwin-help@cygwin.com; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: cygwin-owner@cygwin.com Mail-Followup-To: cygwin@cygwin.com Received: (qmail 33738 invoked by uid 89); 19 Jan 2017 11:26:51 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_LOW,SPF_SOFTFAIL autolearn=no version=3.3.2 spammy=Hx-spam-relays-external:sk:220-245, H*r:sk:220-245, H*RU:sk:220-245, hitches X-HELO: mail16.tpgi.com.au Received: from mail16.tpgi.com.au (HELO mail16.tpgi.com.au) (203.12.160.231) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 19 Jan 2017 11:26:50 +0000 X-TPG-Junk-Status: Message not scanned X-TPG-Abuse: host=220-245-251-204.static.tpgi.com.au; ip=220.245.251.204; date=Thu, 19 Jan 2017 22:26:45 +1100 Received: from [0.0.0.0] (220-245-251-204.static.tpgi.com.au [220.245.251.204]) by mail16.tpgi.com.au (envelope-from lithium-cygwin@shaddybaddah.name) (8.14.3/8.14.3) with ESMTP id v0JBQgxL010989 for ; Thu, 19 Jan 2017 22:26:45 +1100 Subject: Re: ssh-host-config: patch fix debug option + broken for me on Vista (non-domain) To: cygwin@cygwin.com References: <84a7692e-041a-8b99-2ea9-fb1c784fc01c@shaddybaddah.name> <20170119103840.GD13008@calimero.vinschen.de> From: Shaddy Baddah Message-ID: <2cb5cd97-a711-8d11-c07a-2534ee67298b@shaddybaddah.name> Date: Thu, 19 Jan 2017 11:26:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux i686; rv:45.0) Gecko/20100101 Icedove/45.6.0 MIME-Version: 1.0 In-Reply-To: <20170119103840.GD13008@calimero.vinschen.de> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2017-01/txt/msg00251.txt.bz2 Hi, On 19/01/17 21:38, Corinna Vinschen wrote: > On Jan 18 14:34, Shaddy Baddah wrote: ... >> And I'm sure the problem is that this well-intended change to the script >> fails on the assumption that LOGONSERVER is always populated. It isn't >> for me on Vista. >> >> cygwin-service-installation-helper.sh:2884: # This test succeeds on >> domain member machines only, not on DCs. >> cygwin-service-installation-helper.sh:2885: if [ >> "\\\\${COMPUTERNAME,,*}" != "${LOGONSERVER,,*}" \ >> cygwin-service-installation-helper.sh:2886: -a "${LOGONSERVER}" != >> "\\\\MicrosoftAccount" ] >> cygwin-service-installation-helper.sh:2887: then >> cygwin-service-installation-helper.sh:2888: # Lowercase of USERDOMAIN >> cygwin-service-installation-helper.sh:2889: >> csih_PRIVILEGED_USERNAME="${COMPUTERNAME,,*}+${username}" >> cygwin-service-installation-helper.sh:2890: fi >> cygwin-service-installation-helper.sh:2891: fi >> >> I fixed this by modifying the test to check LOGONSERVER is not empty: >> >> if [ -n "${LOGONSERVER}" -a "\\\\... >> >> Can this be fixed in the next release? > > Sure, please provide a patch, I'll check it in and release a new csih > soonish. I would, but there's a couple of hitches. Without understanding the syntax (and I should bring up the bash man page here, I will do after this), I can't be sure that the following test: "\\\\${COMPUTERNAME,,*}" != "${LOGONSERVER,,*}" wasn't designed to handled an empty LOGONSERVER variable. Though it looks to me that it is a binary test (i.e. handling both variables being empty). And secondly, I am not sure that chucking in the -n "${LOGONSERVER}" test is safe in a Vista domain environment. From the comment about the line, it seems like the original author of those lines, whomever that may be, might have a strong understanding to make the modification. But that's not constructive on my part. I'll come up with a patch in the next 24 hours (it is late where I am now). -- Regards, Shaddy > > > Thanks, > Corinna > -- Problem reports: http://cygwin.com/problems.html FAQ: http://cygwin.com/faq/ Documentation: http://cygwin.com/docs.html Unsubscribe info: http://cygwin.com/ml/#unsubscribe-simple