From: "$Bill Luebkert" <dbe@wgn.net>
To: "Steven I. Pollmann" <spollman@julian.uwo.ca>
Cc: gnu-win32@cygnus.com
Subject: Re: gcc and file reading HELP!!
Date: Sun, 26 Oct 1997 20:18:00 -0000 [thread overview]
Message-ID: <345415EA.A32C0630@wgn.net> (raw)
In-Reply-To: <199710262046.PAA17818@romeo.its.uwo.ca>
Steven I. Pollmann wrote:
>
> Sorry about the message, but I'm having a problem with my "c"
> program reading lines of text from a file with gnu-win32. The file compiles
> fine, but when it executes,
> the lines are displayed, and then stack errors are reported to the screen at
> the end, terminating the program. The program appears to work fine on the
> Unix operating system we have at school. Please help, I'd like to get this
> working with windows.
>
> here is the program:
More than likely you're overflowing a buffer.
> #include <stdio.h>
> #define maxFilename 40
40 is too small for long filenames.
> int main()
> {
> int OpenFile(FILE **filePoint, char fileName [maxFilename]);
> void CloseFile(FILE **filePoint);
> void PrintFileContents(FILE **filePoint);
>
> char userFile[maxFilename];
> FILE *sourcefp;
>
> printf("Enter a file to open: \n");
> scanf("%s",userFile);
> printf("file \"%s\" is being opened...",userFile);
>
> if (OpenFile(&sourcefp, userFile) == 1)
> {
> printf("file \"%s\" opened.\n",userFile);
>
> PrintFileContents(&sourcefp);
>
> CloseFile(&sourcefp);
> printf("file \"%s\" closed.\n",userFile);
> }
>
> return 0;
> }
>
> /* open file for reading */
>
> int OpenFile(FILE **filePoint, char fileName [maxFilename])
> {
> if ((*filePoint = fopen(fileName,"r")) == NULL)
> {
> printf("Can't open %s for reading \n",fileName);
> return 0;
> }
> else
> {
> *filePoint = fopen(fileName,"r");
> return 1;
> }
> }
>
> /*close file */
>
> void CloseFile(FILE **filePoint)
> {
> fclose(*filePoint);
> }
>
> /* Print File contents */
>
> void PrintFileContents(FILE **filePoint)
> {
> char info[20];
I would change this ridiculously small buffer from 20 to BUFSIZ.
fscanf is basically a terrible routine in that it can overwrite
your buffer.
> while ((fscanf(*filePoint,"%s",info)) != EOF)
> {
> printf("%s\n",info);
>
> }
> }
HTH,
--
,-/- __ _ _ $Bill Luebkert
(_/ / ) // // DBE Collectibles
/ ) /--< o // // http://www.wgn.net/~dbe/
-/-' /___/_<_</_</_ Email: dbe@wgn.net
-
For help on using this list (especially unsubscribing), send a message to
"gnu-win32-request@cygnus.com" with one line of text: "help".
prev parent reply other threads:[~1997-10-26 20:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
1997-10-26 12:46 Steven I. Pollmann
1997-10-26 20:18 ` $Bill Luebkert [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=345415EA.A32C0630@wgn.net \
--to=dbe@wgn.net \
--cc=gnu-win32@cygnus.com \
--cc=spollman@julian.uwo.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).