public inbox for cygwin@cygwin.com
 help / color / mirror / Atom feed
From: Andrey Repin <anrdaemon@yandex.ru>
To: Brian Inglis <cygwin@cygwin.com>, cygwin@cygwin.com
Subject: Re: Parameter expansion stopped working in recent ash/dash
Date: Thu, 9 Feb 2023 15:08:45 +0300	[thread overview]
Message-ID: <355862424.20230209150845@yandex.ru> (raw)
In-Reply-To: <2d41d3d5-f426-e7cc-eb07-7d3d6011f36d@Shaw.ca>

Greetings, Brian Inglis!

> On 2023-02-07 12:01, Brian Inglis via Cygwin wrote:
>> On 2023-02-07 10:19, Brian Inglis via Cygwin wrote:
>>> On 2023-02-07 05:07, Andrey Repin via Cygwin wrote:
>>>> In the attached script, that I always run using dash, the expansion is
>>>> supposed to strip leading/trailing spaces from provided parameter.
>>>> The upgrade that took place after which the expansion stopped working is
>>>> libsolv:   - dash-0.5.11.5-1.any -> dash-0.5.12-1.any
>>>> Downgrading to 0.5.11.5 restored the expected behavior.
>>>> I failed to find anything relevant in the dash 0.5.12 patch notes, but perhaps
>>>> community could help?

>>> Looks like something in dash broke space trimming of any sort: see attached >> script and logs.
>>> I will see what upstream has to say for themselves, or about Cygwin.

>> Stupid errors in test script, didn't actually run trim3 anyway, redone, and that > and updated logs attached.
>> It appears the locale dependent [[:space:]] regexp no longer works but using > escapes generated by echo still does, see corrected trim3, so perhaps use those > for now, if you can, while I follow this upstream.
>> You may need to add escape sequences for any locale dependent spacing characters > to the space string, so please let us know if there are.

> Hi Andrey,

> A new test release 0.5.12-2 has been uploaded so please install and test
> that behaves as expected in past releases.

At least it no longer clears the input in real world tests.
So that's good for me now.

> The issue was caused as glibc fnmatch and glob now support locale dependent
> named character classes, equivalents, etc. as in grep, so the build now
> defaults to using the local libc fnmatch and glob, without any config test for which libc or supported features.

That's proving importance of proper testing yet again. >.<

> Cygwin winsup and newlib libc fnmatch and glob do not support those locale
> dependent named character classes, equivalents, etc. as in grep, so those
> features are no longer provided in dash by default.

> The new test release disables the build from using libc fnmatch and glob
> and use those provided by dash (possibly by or from gnulib), so those
> classes again appear to work as expected: see attached log.

> If there are no further negative reports by this weekend, I will replace
> the current stable release with this latest test release.


-- 
With best regards,
Andrey Repin
Thursday, February 9, 2023 15:05:35

Sorry for my terrible english...

      reply	other threads:[~2023-02-09 12:20 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-07 12:07 Andrey Repin
2023-02-07 17:19 ` Brian Inglis
2023-02-07 19:01   ` Brian Inglis
2023-02-08 14:20     ` Brian Inglis
2023-02-09 12:08       ` Andrey Repin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=355862424.20230209150845@yandex.ru \
    --to=anrdaemon@yandex.ru \
    --cc=cygwin@cygwin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).