From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 123441 invoked by alias); 7 Nov 2018 21:02:09 -0000 Mailing-List: contact cygwin-help@cygwin.com; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: cygwin-owner@cygwin.com Mail-Followup-To: cygwin@cygwin.com Received: (qmail 123429 invoked by uid 89); 7 Nov 2018 21:02:09 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-0.5 required=5.0 tests=AWL,BAYES_05,KAM_LAZY_DOMAIN_SECURITY,RCVD_IN_DNSWL_LOW autolearn=no version=3.3.2 spammy=disturbing, tarxz, pvr, debuginfo-$ X-HELO: smtp-out-so.shaw.ca Received: from smtp-out-so.shaw.ca (HELO smtp-out-so.shaw.ca) (64.59.136.138) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 07 Nov 2018 21:02:08 +0000 Received: from [192.168.1.114] ([24.64.240.204]) by shaw.ca with ESMTP id KUxggmq5xctraKUxhgQ5JH; Wed, 07 Nov 2018 14:02:06 -0700 Reply-To: Brian.Inglis@SystematicSw.ab.ca Subject: Re: cygport fails with package starting with number To: cygwin@cygwin.com References: <703d2702-0407-82fa-3a84-237bc913cd41@gmail.com> <878t24d4qd.fsf@Rainer.invalid> From: Brian Inglis Openpgp: preference=signencrypt Message-ID: <35e00f32-4e09-34d9-d1f6-34544a92bd2e@SystematicSw.ab.ca> Date: Wed, 07 Nov 2018 21:02:00 -0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <878t24d4qd.fsf@Rainer.invalid> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2018-11/txt/msg00075.txt.bz2 On 2018-11-07 13:15, Achim Gratz wrote: > Marco Atzeri writes: >> It seems that the behaviour of cygport is changed recently >> and rebuilding the 4ti2 package fails on the name 4ti2. > Introduced by a3997ae7ac, which constructs a variable whose name starts > with the package name. However, a leading number does not result in a > valid identifier. So if such package names must be supported then the > substitution made earlier (replacing invalid characters from the name by > an underscore) also needs to handle that particular case. So something > like > local dbg_contents_var=${PN//[-+\.]/_}_debuginfo_CONTENTS; > + dbg_contents_var=${dbg_contents_var/#[0-9]/_} > __step "${PN}-debuginfo-${PVR}.tar.xz"; > in lib/pkg_pkg.cygpart should fix it. or just prefix var name with "_": [ -d ${autoloaddir} ] || autoloaddir= - local dbg_contents_var=${PN//[-+\.]/_}_debuginfo_CONTENTS; + local dbg_contents_var=_${PN//[-+\.]/_}_debuginfo_CONTENTS; -- Take care. Thanks, Brian Inglis, Calgary, Alberta, Canada This email may be disturbing to some readers as it contains too much technical detail. Reader discretion is advised. -- Problem reports: http://cygwin.com/problems.html FAQ: http://cygwin.com/faq/ Documentation: http://cygwin.com/docs.html Unsubscribe info: http://cygwin.com/ml/#unsubscribe-simple