public inbox for cygwin@cygwin.com
 help / color / mirror / Atom feed
* Setup 2.930: 'user_picked' flag not set for packages selected with -P option
@ 2024-03-03 14:42 Christian Franke
  2024-03-03 16:23 ` Jon Turney
  0 siblings, 1 reply; 2+ messages in thread
From: Christian Franke @ 2024-03-03 14:42 UTC (permalink / raw)
  To: cygwin

Setup 2.930 does not set the 'user_picked' flag in 
/etc/setup/installed.db if a package has been selected with the -P 
option instead of the chooser dialog.

An installation could be replicated by extracting a list of 
'user_picked' packages from installed.db and pass it via -P to setup. 
But in this new installation, all non-Base packages will appear in 
"Unneeded" view then.

I guess this is not a regression but longstanding behavior.

No patch provided for now as I don't know the best way to change this.

-- 
Regards,
Christian


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: Setup 2.930: 'user_picked' flag not set for packages selected with -P option
  2024-03-03 14:42 Setup 2.930: 'user_picked' flag not set for packages selected with -P option Christian Franke
@ 2024-03-03 16:23 ` Jon Turney
  0 siblings, 0 replies; 2+ messages in thread
From: Jon Turney @ 2024-03-03 16:23 UTC (permalink / raw)
  To: Christian Franke via Cygwin; +Cc: cygwin

On 03/03/2024 14:42, Christian Franke via Cygwin wrote:
> Setup 2.930 does not set the 'user_picked' flag in 
> /etc/setup/installed.db if a package has been selected with the -P 
> option instead of the chooser dialog.
> 
> An installation could be replicated by extracting a list of 
> 'user_picked' packages from installed.db and pass it via -P to setup. 
> But in this new installation, all non-Base packages will appear in 
> "Unneeded" view then.
> 
> I guess this is not a regression but longstanding behavior.

Hmm... I certainly envisioned it working that way when I added recording 
user_picked (See comments on [1], [2]), but I can believe it's got 
broken at some point...

[1] 
https://cygwin.com/cgit/cygwin-apps/setup/commit/?id=f6d6c600edffdb83a57ed13384e38a504fdc366b
[2] 
https://cygwin.com/cgit/cygwin-apps/setup/commit/?id=dbd295e75edfadd5fc6feebe11b482cd672575cf

> No patch provided for now as I don't know the best way to change this.

But yes, this is definitely a bug!


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2024-03-03 16:23 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-03-03 14:42 Setup 2.930: 'user_picked' flag not set for packages selected with -P option Christian Franke
2024-03-03 16:23 ` Jon Turney

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).