public inbox for cygwin@cygwin.com
 help / color / mirror / Atom feed
* setup 2.920 release candidate - please test
@ 2022-07-02 14:37 Jon Turney
  2022-08-14 12:38 ` Christian Franke
  0 siblings, 1 reply; 6+ messages in thread
From: Jon Turney @ 2022-07-02 14:37 UTC (permalink / raw)
  To: The Cygwin Mailing List


A new setup release candidate is available at:

  https://cygwin.com/setup/setup-2.920.x86_64.exe (64 bit version)
  https://cygwin.com/setup/setup-2.920.x86.exe    (32 bit version)

Please test, and report any problems here.

This is not the place for setup feature requests.


Changes compared to 2.919:

- Add perpetual support for preremove scripts (thanks to Christian Franke)

- Major update to libsolv (from 0.6.29 to 0.7.22)

- Allow packages to be marked as 'self-destruct'


For instructions on obtaining and building the source code for setup, 
see https://sourceware.org/cygwin-apps/setup.html

Please send bug reports, as usual, to the public mailing list cygwin AT 
cygwin DOT com.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: setup 2.920 release candidate - please test
  2022-07-02 14:37 setup 2.920 release candidate - please test Jon Turney
@ 2022-08-14 12:38 ` Christian Franke
  2022-08-14 16:47   ` Achim Gratz
  2022-08-14 18:56   ` Jon Turney
  0 siblings, 2 replies; 6+ messages in thread
From: Christian Franke @ 2022-08-14 12:38 UTC (permalink / raw)
  To: cygwin

Jon Turney wrote:
>
> A new setup release candidate is available at:
>
>  https://cygwin.com/setup/setup-2.920.x86_64.exe (64 bit version)
>  https://cygwin.com/setup/setup-2.920.x86.exe    (32 bit version)
>
> Please test, and report any problems here.
>

This version aborts if "Sync" setting is reverted to "Best".

Steps to reproduce:
- Install from Internet
- For All Users
- Use System Proxy Settings
- Mirror: any
- Change "Best" -> "Sync"
- Change "Sync" -> "Best"

Result: Setup silently aborts, no setup.log* written.

Console output:
---
Starting cygwin install, version 2.920
User has backup/restore rights
User has symlink creation right
Current Directory: E:\install\cygwin
source: network install
root: C:\cygwin64 system
Selected local directory: E:\install\cygwin
net: Preconfig
site: https://ftp.fau.de/cygwin/
solving: 0 tasks, update: yes, use test packages: no
solving: 0 tasks, update: yes, use test packages: no
solving: 0 tasks, update: yes, use test packages: no
---

With -v option, console output ends with:
---
...
libsolv: obsoletes data: 1 entries
libsolv: added 0 pkg rules for installed solvables
libsolv: added 0 pkg rules for updaters of installed solvables
libsolv: added 0 pkg rules for packages involved in a job
libsolv: added 0 pkg rules because of weak dependencies
libsolv: 2457 of 28475 installable solvables considered for solving
libsolv: pkg rule memory used: 327 K
libsolv: pkg rule creation took 0 ms
---

Could not be reproduced with the released cygwin*.exe 2.919 from 
https://cygwin.com/

Could also be reproduced with
- 32-bit version
- current git HEAD
- a rebuild of 2.919 from "git checkout release_2.919"

Possible problem in conjunction with newer versions Mingw-w64 toolchain ?

$ x86_64-w64-mingw32-g++ --version
x86_64-w64-mingw32-g++ (GCC) 11.3.0

$ x86_64-w64-mingw32-ld --version
GNU ld (GNU Binutils) 2.38


Found during testing of my recent setup patches ("Unneeded" view, 
keyboard accelerators Ctrl+I/R/U), see cygwin-apps.

-- 
Regards,
Christian


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: setup 2.920 release candidate - please test
  2022-08-14 12:38 ` Christian Franke
@ 2022-08-14 16:47   ` Achim Gratz
  2022-08-14 19:00     ` Jon Turney
  2022-08-15  8:18     ` Christian Franke
  2022-08-14 18:56   ` Jon Turney
  1 sibling, 2 replies; 6+ messages in thread
From: Achim Gratz @ 2022-08-14 16:47 UTC (permalink / raw)
  To: cygwin

Christian Franke writes:
> This version aborts if "Sync" setting is reverted to "Best".

If the abort goes away when building setup with the previous version of
libsolv then you might have found an easier reproducer for a bug I'm
chasing…  Running it in gdb should get you a SIGSEGV in
solver_addduprules in this case.


Regards,
Achim.
-- 
+<[Q+ Matrix-12 WAVE#46+305 Neuron microQkb Andromeda XTk Blofeld]>+

SD adaptation for Waldorf microQ V2.22R2:
http://Synth.Stromeko.net/Downloads.html#WaldorfSDada

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: setup 2.920 release candidate - please test
  2022-08-14 12:38 ` Christian Franke
  2022-08-14 16:47   ` Achim Gratz
@ 2022-08-14 18:56   ` Jon Turney
  1 sibling, 0 replies; 6+ messages in thread
From: Jon Turney @ 2022-08-14 18:56 UTC (permalink / raw)
  To: Christian Franke, The Cygwin Mailing List

On 14/08/2022 13:38, Christian Franke wrote:
> Jon Turney wrote:
>>
>> A new setup release candidate is available at:
>>
>>  https://cygwin.com/setup/setup-2.920.x86_64.exe (64 bit version)
>>  https://cygwin.com/setup/setup-2.920.x86.exe    (32 bit version)
>>
>> Please test, and report any problems here.
>>
> 
> This version aborts if "Sync" setting is reverted to "Best".
> 
> Steps to reproduce:
> - Install from Internet
> - For All Users
> - Use System Proxy Settings
> - Mirror: any
> - Change "Best" -> "Sync"
> - Change "Sync" -> "Best"
> 
> Result: Setup silently aborts, no setup.log* written.

Thanks for the clear reproduction steps.  I had reports that this setup 
version crashes, but nothing to investigate...

[....]
> libsolv: pkg rule creation took 0 ms
> ---
> 
> Could not be reproduced with the released cygwin*.exe 2.919 from 
> https://cygwin.com/
> 
> Could also be reproduced with
> - 32-bit version
> - current git HEAD
> - a rebuild of 2.919 from "git checkout release_2.919"
> 
> Possible problem in conjunction with newer versions Mingw-w64 toolchain ?

It's very likely caused by the long overdue libsolv update in that build.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: setup 2.920 release candidate - please test
  2022-08-14 16:47   ` Achim Gratz
@ 2022-08-14 19:00     ` Jon Turney
  2022-08-15  8:18     ` Christian Franke
  1 sibling, 0 replies; 6+ messages in thread
From: Jon Turney @ 2022-08-14 19:00 UTC (permalink / raw)
  To: The Cygwin Mailing List

[-- Attachment #1: Type: text/plain, Size: 609 bytes --]

On 14/08/2022 17:47, Achim Gratz wrote:
> Christian Franke writes:
>> This version aborts if "Sync" setting is reverted to "Best".
> 
> If the abort goes away when building setup with the previous version of
> libsolv then you might have found an easier reproducer for a bug I'm
> chasing…  Running it in gdb should get you a SIGSEGV in
> solver_addduprules in this case.

After some staring at this crash and the code involved, I think the 
attached is the fix for this.

I think this crash would only occur if the solver was used with at least 
one package marked for distupgrade, then reused without any.

[-- Attachment #2: 0001-Ensure-duplinvolvedmap_all-is-reset-when-a-solver-is.patch --]
[-- Type: text/plain, Size: 864 bytes --]

From 480123038537b89bcfca4a8ac9b40271eb7f5d5b Mon Sep 17 00:00:00 2001
From: Jon Turney <jon.turney@dronecode.org.uk>
Date: Sun, 14 Aug 2022 18:45:20 +0100
Subject: [PATCH] Ensure duplinvolvedmap_all is reset when a solver is reused

Otherwise this can cause solver_addduprules() to be called even though
needduprules is 0, which will crash because solver_createdupmaps()
hasn't been called.
---
 src/solver.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/solver.c b/src/solver.c
index 28341d6d..e3779e23 100644
--- a/src/solver.c
+++ b/src/solver.c
@@ -3533,6 +3533,7 @@ solver_solve(Solver *solv, Queue *job)
   map_zerosize(&solv->bestupdatemap);
   solv->fixmap_all = 0;
   map_zerosize(&solv->fixmap);
+  solv->dupinvolvedmap_all = 0;
   map_zerosize(&solv->dupmap);
   map_zerosize(&solv->dupinvolvedmap);
   solv->process_orphans = 0;
-- 
2.37.2


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: setup 2.920 release candidate - please test
  2022-08-14 16:47   ` Achim Gratz
  2022-08-14 19:00     ` Jon Turney
@ 2022-08-15  8:18     ` Christian Franke
  1 sibling, 0 replies; 6+ messages in thread
From: Christian Franke @ 2022-08-15  8:18 UTC (permalink / raw)
  To: cygwin

Achim Gratz wrote:
> Christian Franke writes:
>> This version aborts if "Sync" setting is reverted to "Best".
> If the abort goes away when building setup with the previous version of
> libsolv then you might have found an easier reproducer for a bug I'm
> chasing…  Running it in gdb should get you a SIGSEGV in
> solver_addduprules in this case.

Indeed:

Thread 1 received signal SIGSEGV, Segmentation fault.
0x00007ff60bb42a19 in solver_addduprules (solv=<optimized out>, 
addedmap=<optimized out>) at 
/usr/src/debug/mingw64-x86_64-libsolv-0.7.22-1/src/rules.c:2125
...


^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2022-08-15  8:18 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-07-02 14:37 setup 2.920 release candidate - please test Jon Turney
2022-08-14 12:38 ` Christian Franke
2022-08-14 16:47   ` Achim Gratz
2022-08-14 19:00     ` Jon Turney
2022-08-15  8:18     ` Christian Franke
2022-08-14 18:56   ` Jon Turney

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).