Patch for Cygwin's Emacs dired.el and loaddefs.el

Patch for Cygwin's Emacs dired.el and loaddefs.el

[Harig, Mark A.]

Below is a pair of patches that I submitted to the Emacs project.
This fixes a Cygwin-specific problem, namely, that the 'dired'
"change owner" command (shift-o) does not work in Emacs in the
Cygwin environment because 'cygwin' was not being included the
list of systems returned by 'system-type'.

If you would like to applies these patches to your installation
of Emacs, do the following:

  1. If you haven't downloaded the 'emacs-el' package (in
     the Editors category in setup.exe), then you need to
     do that so you'll have the lisp files that need to
     be patched.

  2. If you don't have 'patch' installed, you'll need that
     also.  It's in the Utils category in setup.exe.
     (Or, you can read the patches below and edit your
      .el files.)

  3. After you have installed these two packages, set your
     current working directory to the Emacs Lisp directory.
     By default, this is /usr/share/emacs/21.2/lisp.

       $ cd /usr/share/emacs/21.2/lisp

  4. Cut & paste the first patch below to the (new) text file
     'dired.patch'.  Cut & paste the second patch below to
     the (new) text file 'loaddefs.patch'.

  5. Patch the .el files with the 'patch' utility.  Of course,
     you can also byte-compile the new versions of these two
     .el files.


Patch 1: $ patch -p0 < dired.patch

--- dired.el.orig       2002-09-04 19:50:41.000000000 -0400
+++ dired.el    2002-09-04 19:51:01.000000000 -0400
@@ -62,7 +62,7 @@
 
 ;;;###autoload
 (defvar dired-chown-program
-  (if (memq system-type '(hpux dgux usg-unix-v irix linux gnu/linux))
+  (if (memq system-type '(cygwin hpux dgux usg-unix-v irix linux
gnu/linux))
       "chown"
     (if (file-exists-p "/usr/sbin/chown")
        "/usr/sbin/chown"



Patch 2: $ patch -p0 < loaddefs.patch

--- loaddefs.el.orig    2002-09-04 19:54:02.000000000 -0400
+++ loaddefs.el 2002-09-04 19:54:26.000000000 -0400
@@ -4711,7 +4711,7 @@
 may contain even `F', `b', `i' and `s'.  See also the variable
 `dired-ls-F-marks-symlinks' concerning the `F' switch.")
 
-(defvar dired-chown-program (if (memq system-type (quote (hpux dgux
usg-unix-v irix linux gnu/linux))) "chown" (if (file-exists-p
"/usr/sbin/chown") "/usr/sbin/chown" "/etc/chown")) "\
+(defvar dired-chown-program (if (memq system-type (quote (cygwin hpux
dgux usg-unix-v irix linux gnu/linux))) "chown" (if (file-exists-p
"/usr/sbin/chown") "/usr/sbin/chown" "/etc/chown")) "\
 Name of chown command (usually `chown' or `/etc/chown').")
 
 (defvar dired-ls-F-marks-symlinks nil "\



=== End of patches ===

--
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple
Bug reporting:         http://cygwin.com/bugs.html
Documentation:         http://cygwin.com/docs.html
FAQ:                   http://cygwin.com/faq/

Re: Patch for Cygwin's Emacs dired.el and loaddefs.el

[Joe Buehler]

Harig, Mark A. wrote:

> Below is a pair of patches that I submitted to the Emacs project.
> This fixes a Cygwin-specific problem, namely, that the 'dired'
> "change owner" command (shift-o) does not work in Emacs in the
> Cygwin environment because 'cygwin' was not being included the
> list of systems returned by 'system-type'.

I just made some changes to fix UNC path support, and will include
your patches in the upcoming -8 release of the Cygwin GNU emacs.

Joe Buehler




--
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple
Bug reporting:         http://cygwin.com/bugs.html
Documentation:         http://cygwin.com/docs.html
FAQ:                   http://cygwin.com/faq/

RE: Patch for Cygwin's Emacs dired.el and loaddefs.el

[Harig, Mark A.]

> -----Original Message-----
> From: Robinow, David [mailto:drobinow@dayton.adroit.com]
> Sent: Friday, September 06, 2002 10:42 AM
> To: Harig, Mark A.; Joe Buehler; cygwin@cygwin.com
> Subject: RE: Patch for Cygwin's Emacs dired.el and loaddefs.el
> 
(text deleted)
> 
>   Not sure if I qualify as "someone" wrt this issue, but I have an
> objection.
>   cygwin is for ports of unix tools. I can't see where you have ported
> anything.
>  Why increase the size of the distribution for no possible benefit?
> 
> > Here are the packages I plan on adding:
> > 
> > http://www.gnu.org/manual/elisp-manual-21-2.8/info/elisp-info.tar.gz
> > 
> >
http://www.gnu.org/manual/emacs-lisp-intro/info/emacs-lisp-intro.info.gz
> Right, that's where they are, there and at numerous mirrors. 
> Why add them to cygwin?
>
> >Of course, those two packages completely independent of the Emacs
package.
>
> >BTW, in some future version of Emacs, the Lisp Intro is planned
> >to be integrated into the Emacs distribution.

Two reasons:

  1. Convenience.  Many people don't know where to find these documents,
but
     can quickly navigate through 'setup' to find them.  In fact, many
     people don't even know that they exist.  My guess is that this is
     part of the reason why the Emacs Lisp Intro is being added to the
     Emacs CVS repository.

     Keep in mind that many (most?) packages included in the Cygwin
     distribution "compile out of the box", and so an argument could
     be made that it's not necessary to include any of those packages
     in 'setup'.  After all, any one who wants them could simply
     download them from one of the many mirrors and build/install
     them on their own, decreasing the size of the Cygwin mirrors.
     Similarly, most GNU/Linux packages could be obtained directly
     from the sources.  Red Hat, SUSE, Mandrake, et al., exist
     because people find it useful to have a large set of those
     packages built for them, and more, installed and set up for them.

  2. Because it is basic documentation.   There exist large libraries
     of Elisp code on many sites (the one at Ohio State comes to mind).
     Should Cygwin include these libraries on their mirrors?  (Where
     do you draw the line?  Cygwin includes Perl.  Shouldn't it then
     include all of CPAN?)  Documentation for Emacs Lisp is distinct
     from those libraries because of its generality.  It is not a
     particular package.  It is the instructions for creating any
     package.  That is why I think that it should be included, but the
     many libraries of Elisp code should not.

     If you think it should not, then wouldn't that argue that the
     documentation for Perl and Python should be excluded also?

---

--
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple
Bug reporting:         http://cygwin.com/bugs.html
Documentation:         http://cygwin.com/docs.html
FAQ:                   http://cygwin.com/faq/

RE: Patch for Cygwin's Emacs dired.el and loaddefs.el

[Nicholas Wourms]

--- "Robinow, David" <drobinow@dayton.adroit.com> wrote:
> 
> 
> > -----Original Message-----
> > From: Harig, Mark A. [mailto:maharig@idirect.net]
> > Sent: Thursday, September 05, 2002 5:14 PM
> > To: Joe Buehler; cygwin@cygwin.com
> > Subject: RE: Patch for Cygwin's Emacs dired.el and loaddefs.el
> > Ok.  I will look into adding the Emacs Lisp Intro and Emacs Lisp
> > manual to the Cygwin distribution soon (unless someone else does
> > it first, or someone has an objection) in the 'Doc' section.
>   Not sure if I qualify as "someone" wrt this issue, but I have an
> objection.
>   cygwin is for ports of unix tools. I can't see where you have
> ported
> anything.
>  Why increase the size of the distribution for no possible benefit?
> 
> > Here are the packages I plan on adding:
> > 
> >
>
http://www.gnu.org/manual/elisp-manual-21-2.8/info/elisp-info.tar.gz
> >
>
http://www.gnu.org/manual/emacs-lisp-intro/info/emacs-lisp-intro.info.gz
>  Right, that's where they are, there and at numerous mirrors.  Why
> add them
> to cygwin?

You *don't* have to install the docs if you don't want them, but I
think including the documentation as an optional install makes sense.
 Yes, Cygwin is for unix ports, but it has grown into a respectable
distribution which can be used for more then just "porting" unix
apps.

> 
> >Of course, those two packages completely independent of the Emacs
> package.
> 
> >BTW, in some future version of Emacs, the Lisp Intro is planned
> >to be integrated into the Emacs distribution.
> 
>  Interesting, but what interests me more is:
>  When are Joe's cygwin mods going to be integrated into the Emacs
> distribution?
>  I've just updated from the emacs cvs archive and I see none of the
> cygwin
> stuff.
>  Are the patches being rejected? Are they even being submitted?

Who cares???  This is a decision which Joe will make.  I'm sure if
you checked the appropriate mailing list you could answer this
question yourself.

Cheers,
Nicholas

__________________________________________________
Do You Yahoo!?
Yahoo! Finance - Get real-time stock quotes
http://finance.yahoo.com

--
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple
Bug reporting:         http://cygwin.com/bugs.html
Documentation:         http://cygwin.com/docs.html
FAQ:                   http://cygwin.com/faq/

RE: Patch for Cygwin's Emacs dired.el and loaddefs.el

[Robinow, David]

> From: Joe Buehler [mailto:jbuehler@hekimian.com]
> Subject: Re: Patch for Cygwin's Emacs dired.el and loaddefs.el
> 
> Robinow, David wrote:
> 
> >  Interesting, but what interests me more is:
> >  When are Joe's cygwin mods going to be integrated into the Emacs
> > distribution?
> >  I've just updated from the emacs cvs archive and I see 
> none of the cygwin
> > stuff.
> >  Are the patches being rejected? Are they even being submitted?
> 
> RMS will not take patches without a copyright assignment.  My management
> is processing it.  The next release of emacs is a bug patch release in
> any case, and RMS says he probably won't include the Cygwin patches.  So
> I guess in 21.4 maybe...\
  OK, sounds good.
> 
> In the meanwhile, the patches are currently in the Cygwin "src" package
> for emacs if you want them, along with a build script that makes it
> easy to build.
 Yes, I was aware of that.  Thanks for your contribution.

--
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple
Bug reporting:         http://cygwin.com/bugs.html
Documentation:         http://cygwin.com/docs.html
FAQ:                   http://cygwin.com/faq/

Re: Patch for Cygwin's Emacs dired.el and loaddefs.el

[Joe Buehler]

Robinow, David wrote:

>  Interesting, but what interests me more is:
>  When are Joe's cygwin mods going to be integrated into the Emacs
> distribution?
>  I've just updated from the emacs cvs archive and I see none of the cygwin
> stuff.
>  Are the patches being rejected? Are they even being submitted?

RMS will not take patches without a copyright assignment.  My management
is processing it.  The next release of emacs is a bug patch release in
any case, and RMS says he probably won't include the Cygwin patches.  So
I guess in 21.4 maybe...

In the meanwhile, the patches are currently in the Cygwin "src" package
for emacs if you want them, along with a build script that makes it
easy to build.
--
Joe Buehler


--
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple
Bug reporting:         http://cygwin.com/bugs.html
Documentation:         http://cygwin.com/docs.html
FAQ:                   http://cygwin.com/faq/

RE: Patch for Cygwin's Emacs dired.el and loaddefs.el

[Robinow, David]

> -----Original Message-----
> From: Harig, Mark A. [mailto:maharig@idirect.net]
> Sent: Thursday, September 05, 2002 5:14 PM
> To: Joe Buehler; cygwin@cygwin.com
> Subject: RE: Patch for Cygwin's Emacs dired.el and loaddefs.el
> Ok.  I will look into adding the Emacs Lisp Intro and Emacs Lisp
> manual to the Cygwin distribution soon (unless someone else does
> it first, or someone has an objection) in the 'Doc' section.
  Not sure if I qualify as "someone" wrt this issue, but I have an
objection.
  cygwin is for ports of unix tools. I can't see where you have ported
anything.
 Why increase the size of the distribution for no possible benefit?

> Here are the packages I plan on adding:
> 
> http://www.gnu.org/manual/elisp-manual-21-2.8/info/elisp-info.tar.gz
> http://www.gnu.org/manual/emacs-lisp-intro/info/emacs-lisp-intro.info.gz
 Right, that's where they are, there and at numerous mirrors.  Why add them
to cygwin?


>Of course, those two packages completely independent of the Emacs package.

>BTW, in some future version of Emacs, the Lisp Intro is planned
>to be integrated into the Emacs distribution.

 Interesting, but what interests me more is:
 When are Joe's cygwin mods going to be integrated into the Emacs
distribution?
 I've just updated from the emacs cvs archive and I see none of the cygwin
stuff.
 Are the patches being rejected? Are they even being submitted?


--
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple
Bug reporting:         http://cygwin.com/bugs.html
Documentation:         http://cygwin.com/docs.html
FAQ:                   http://cygwin.com/faq/

RE: Patch for Cygwin's Emacs dired.el and loaddefs.el

[Harig, Mark A.]

> -----Original Message-----
> From: Joe Buehler [mailto:jbuehler@hekimian.com]
> Sent: Thursday, September 05, 2002 9:21 AM
> To: cygwin@cygwin.com
> Subject: Re: Patch for Cygwin's Emacs dired.el and loaddefs.el
> 
> 
> Harig, Mark A. wrote:
> 
> > Below is a pair of patches that I submitted to the Emacs project.
> > This fixes a Cygwin-specific problem, namely, that the 'dired'
> > "change owner" command (shift-o) does not work in Emacs in the
> > Cygwin environment because 'cygwin' was not being included the
> > list of systems returned by 'system-type'.
> 
> I just made some changes to fix UNC path support, and will include
> your patches in the upcoming -8 release of the Cygwin GNU emacs.
> 
> Joe Buehler
> 

Ok.  I will look into adding the Emacs Lisp Intro and Emacs Lisp
manual to the Cygwin distribution soon (unless someone else does
it first, or someone has an objection) in the 'Doc' section.
Here are the packages I plan on adding:

http://www.gnu.org/manual/elisp-manual-21-2.8/info/elisp-info.tar.gz
http://www.gnu.org/manual/emacs-lisp-intro/info/emacs-lisp-intro.info.gz

Of course, those two packages completely independent of the Emacs
package.

BTW, in some future version of Emacs, the Lisp Intro is planned
to be integrated into the Emacs distribution.

> 
> 
> 
> --
> Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple
> Bug reporting:         http://cygwin.com/bugs.html
> Documentation:         http://cygwin.com/docs.html
> FAQ:                   http://cygwin.com/faq/
> 
> 

--
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple
Bug reporting:         http://cygwin.com/bugs.html
Documentation:         http://cygwin.com/docs.html
FAQ:                   http://cygwin.com/faq/