From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2110.outbound.protection.outlook.com [40.107.93.110]) by sourceware.org (Postfix) with ESMTPS id 6952E385843B for ; Tue, 7 Sep 2021 16:28:34 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 6952E385843B ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NB0Vg3IY61bwKdidnIGLHlaij/0hanrF2GAoccG4qZw9NJCD8uuRtUAWcdGg7f6ZhItUOh4sHUkWcLOivze2aySpWU4fa7SBcwkRdgzD67dASirNPoNjX0AThcbm94sm6GLWCoLeuxikU20OI802Bh2czS2AmS0CgtAga7YZoLJ/+SBWvbwe5IY8sdHS+MT6ING2Nxy/esNBIFUIX8Rn1FDEqe0BqX/0huwCGYT86ZlCK/IHgVR/CfAfGjrkeZQKb4pTmEOGinF6+dG/Hjj3us9dpuXw9Z5ejSlotHgxrcnF2OghESgenQXyLivl74FdDh/IjL7LVAsQIb8ZRQ/Neg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=C/xeHbET/EsHqTnVWfWYXnpZogQMLU3R3SHXCgiMMTk=; b=KWx6do2B40UHfVu6/E2V6rvJQmqIvSWe7H+6EzUAFVnXUGQX0pQdVDpayE2trFNgwA5MwLxj1pHthF1lpWvaSKu5GXQ87AXrbEuZn98J10XLA/l6asaEoGoEmtHwLYPLpqIY5Io4dCfwpRt4fA4UyYH2yGnng2HZP0AifYggL/xy4cYs1uBxomvBEumg+VMNUbMXHzCPN6qd044XQPWe/N8qSXido8qO2gJcX40ArtGzYLqJIek+CPXXFW5wbWT7M8t5ekwwD/+0CMGXPCDBf+2rFJElrO1qO4MeaMVqBzdXQDMa0O8/Pc36GPaa+PDCGwjG3xTQ0Qm4BQ5IGstZPA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=cornell.edu; dmarc=pass action=none header.from=cornell.edu; dkim=pass header.d=cornell.edu; arc=none Received: from BN7PR04MB4388.namprd04.prod.outlook.com (2603:10b6:406:f8::19) by BN3PR04MB2324.namprd04.prod.outlook.com (2603:10b6:400:1::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.22; Tue, 7 Sep 2021 16:28:32 +0000 Received: from BN7PR04MB4388.namprd04.prod.outlook.com ([fe80::b510:889b:1fd0:d80e]) by BN7PR04MB4388.namprd04.prod.outlook.com ([fe80::b510:889b:1fd0:d80e%7]) with mapi id 15.20.4478.025; Tue, 7 Sep 2021 16:28:32 +0000 Subject: Re: mmap failure [was: cygrunsrv + sshd + rsync = 20 times too slow -- throttled?] To: cygwin@cygwin.com References: <88fde5d5-4897-8792-576a-a62be0092ad8@cornell.edu> <94b5b6cf-1670-cbdd-2f51-84dae09d27b6@cornell.edu> <387d9062-1ff9-6eab-e268-e5070352a193@cornell.edu> <40275f71-7c10-55a9-e6c8-a948e32c37ac@cornell.edu> <33ae27cb-4e45-7484-40d1-6cbd88c958f1@cornell.edu> <3a63eb8c-3e8e-cd2c-b9de-8c34fa041a75@cornell.edu> <5b705ae7c9747a9cc25d2610cc6748e92bbe1d70.camel@dontech.dk> <890dad21-dec5-cdd1-bf99-bdb45e759a71@cornell.edu> <742331ee-4d9f-e86f-9314-c85b5f0cbfa8@SystematicSw.ab.ca> From: Ken Brown Message-ID: <3bb3814c-0584-c918-6710-f71c7abfbcc5@cornell.edu> Date: Tue, 7 Sep 2021 12:28:30 -0400 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 In-Reply-To: <742331ee-4d9f-e86f-9314-c85b5f0cbfa8@SystematicSw.ab.ca> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-ClientProxiedBy: CH0PR08CA0015.namprd08.prod.outlook.com (2603:10b6:610:33::20) To BN7PR04MB4388.namprd04.prod.outlook.com (2603:10b6:406:f8::19) MIME-Version: 1.0 Received: from [IPv6:2603:7081:7e3f:3419:d99d:97b7:c534:97e2] (2603:7081:7e3f:3419:d99d:97b7:c534:97e2) by CH0PR08CA0015.namprd08.prod.outlook.com (2603:10b6:610:33::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.20 via Frontend Transport; Tue, 7 Sep 2021 16:28:32 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 8547f302-82c6-4d43-ebd1-08d9721c8883 X-MS-TrafficTypeDiagnostic: BN3PR04MB2324: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:8273; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: /yaAfbfbMIZftq9fiepDFiS+IFHyegjaCYO0gofexy3gbly/SVmDNduddUw++gVvdzeyYkoz0zdMUMKsZcZM9bnq0g+KUpm6WiHX3ng2LaXu/YUjq0ubBDOghQf15HPncOAHfbadcwg7IVkDjIcs5LpUf1l0VdJAaHFlzokhCID2XQSZF/NiQlSX2aBLA9pPVQaTzk4x9HSpmQHByM/PEnjSh5V8H+N9JW6yOkTOAPASr414LkdjcbcsLLuBCziKBG5De+l8evVRqzLyFmux00uBTUXW0vGUTCfcHvSlVdUmq7pBXMhwiDkQXDrjx4qTgTvXUWdmgeYiTMywacsePpziWKXBTgT9OoM09AU49g6aIUNs0qQTro+QQw2IEyrvTQDgSm2ieOM1f/1mzrsiJiaJcosI6z7OdExzML4jeADj91CET/dRnNf9HejR8SPnxhteSGkgkyMiLAqFGZCYaDYADYUJRBjkiN4DIr8Ij53KUdqhHItiGPxfWFd6RubmuxWTUFwZE4xyCWGtZf+X/2AYj0Lku2kdS3eZCpdWgm7i7d99bint7Ow80dsa1kCLqZ6kqGSx05W4EYhs+Qg/Rji7eFvYf+sBJnKSi1BRJg1cqcq9S6WVVKvoHdNZ9yb6f3Kzp6PXDPE0qcMvifeZlIEzHu7g4rl+EdnVOt39Am0JxPDR40AcDlUwjx7PUF+swIik/EPNuLqEZ/P3oZqX3SZkTXrYFe5uzrllme0Zx9/g74w3gFJSiI/SQ5AY6khzhsZoV+RHu9S5gtahZWroTkLtYSSURYy7LoTupoKJC2Xg6twVIlOu6gEKrDV/Vo1XvVvW2/6GbhKzzdQWShSeZg== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN7PR04MB4388.namprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(396003)(376002)(136003)(366004)(39860400002)(346002)(8676002)(36756003)(5660300002)(8936002)(66556008)(38100700002)(83380400001)(6916009)(2906002)(6486002)(186003)(66946007)(316002)(31696002)(966005)(2616005)(478600001)(75432002)(31686004)(53546011)(86362001)(66476007)(43740500002)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?Windows-1252?Q?XR6v9vnN+JY/wSZlR+wbFwgBubg2Ga/c/D1egi9EnnSkpTOQ5iEigfOw?= =?Windows-1252?Q?TexuAZhubfBfOovWSXLhisai52r52X++sRh9CCOwNTYY2W1hCvBelsGk?= =?Windows-1252?Q?0T1+0i7zlwP6cJZnfidQSQ20o+YKoVawJqNmlnbpzRKAXuESsgoozyO9?= =?Windows-1252?Q?4GXdPbFdEh9m++xzcWTryBvAPHDXaqdBjzUYrKuBmHkqde1pYFhKUWOq?= =?Windows-1252?Q?l8vPbGC8lGotEf0IT0B2LfpPOyUOvJqJj/V/EV+WkBi25sb9AfcT/5nn?= =?Windows-1252?Q?seAIXmuS29I5di1/Tdtf1UXZlcsVpw+8VqLvzeP7HIU6r6+0QT7yDCr+?= =?Windows-1252?Q?VjMxW+GBNVuhOzwikWeNHwIWSzza2xDx+JW+oHg5YTzQh7UgHqRtcott?= =?Windows-1252?Q?MpUn0E1M77p5Ohl7H885cSP2+IhQMbOAhCoKWp7rwHjtysUkLp2cG6eM?= =?Windows-1252?Q?lCbWAJgFHdjIEQ1ihp3OgeAw4AyoYUfca+hxwCZK2g/xr5mfe7htz5PZ?= =?Windows-1252?Q?l0T3BKRAjJlTtu2bdjbkYgEHUL7oNxu9f1fhhLt00GtcpoAF+/kWiGFA?= =?Windows-1252?Q?hPbAx4YSNAuRJy6IHWtn/JlriZsKNQu6onbtFo/zsX3CHjzzZaZxYvDq?= =?Windows-1252?Q?HetF9Dd5kpYzk8cJr6dUhULiY0pOEen9cPydhk3S2mY6UBflMZMFF/Yq?= =?Windows-1252?Q?Re+bFSWOzSWbN9Xv+NoUZzwdRSTRT1NbdNaVlgj0zVWIwKdfcV3zdfP9?= =?Windows-1252?Q?WQ3Na3p6ga/TDPO9Y9HM0c6R0OkzHD4VU86VP+2Xw7VO6xMFQ1DP97Qv?= =?Windows-1252?Q?urdmdWd8SJVyROiqnAgOZ6QZOtXhjVDCtIMF7HJQTRSOtMUcPtOWwMR+?= =?Windows-1252?Q?lW+rnVLWDGPixvzJGxzRtkyFO3lSvln3IlIbuXinEoIndArzSQsxEulO?= =?Windows-1252?Q?LDDRFOeLjYl+c3a2kh0fQCFJK0ubj++2LZcnQjBGjItDdLaEAn/sPmtu?= =?Windows-1252?Q?OR3s7oEb284RwivFb3alrSNwX4pVIdhfR/a1eDr4GTowCWFG5ZDQwvcY?= =?Windows-1252?Q?81uxuu+/eSiIfP2sIb2s1t9h87jKprDbNm76tYINh2LjLP5+OPk9cHf6?= =?Windows-1252?Q?Q867nS/tg0768PdcICJzRvVFC+Jb5WrIG6MWjoQVo6RwrEZNlMfYe8aR?= =?Windows-1252?Q?6MDbQZFcP7DFA3h7Io13F3+xd70ShVIVcLPKLdU6WzammaTCzl41q1L+?= =?Windows-1252?Q?O1L3BX4MtmR1/621wKPf1/XbzYc7ti4q6QiPQBqj1mSgXE0bE319cRls?= =?Windows-1252?Q?Xj3mgUWR2+VOpbZbk4McMaOjgtdoSRSMPZdu2j7BuZbhDe3solfqpBXC?= =?Windows-1252?Q?i9SjMeKg7SXqo3bpRuS0zn+f3inva68uSrKMtbHOG5ENYQgiQVn1Kvgq?= =?Windows-1252?Q?Q/6RDXwiNnYBFSsWIMdhxgCmATueOhBE6F13blAT+HYQfKVjwavfWk7a?= =?Windows-1252?Q?vVYhxYA6?= X-OriginatorOrg: cornell.edu X-MS-Exchange-CrossTenant-Network-Message-Id: 8547f302-82c6-4d43-ebd1-08d9721c8883 X-MS-Exchange-CrossTenant-AuthSource: BN7PR04MB4388.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Sep 2021 16:28:32.7112 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 5d7e4366-1b9b-45cf-8e79-b14b27df46e1 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 8cR7WxsVcPcmlq20VKqwKAEnRjXW7PzpJdCjYZam8ykFd8LIIXTOdzBDSADt4Us3+aim1YJ1v6Hot3Dx9dENVw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN3PR04MB2324 X-Spam-Status: No, score=-0.3 required=5.0 tests=BAYES_00, BODY_8BITS, DKIM_INVALID, DKIM_SIGNED, JMQ_SPF_NEUTRAL, KAM_DMARC_STATUS, MSGID_FROM_MTA_HEADER, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: cygwin@cygwin.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: General Cygwin discussions and problem reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 07 Sep 2021 16:28:36 -0000 On 9/6/2021 11:34 PM, Brian Inglis wrote: > On 2021-09-06 15:24, Ken Brown via Cygwin wrote: >> On 9/6/2021 4:54 PM, Peter Dons Tychsen wrote: >>> Hi there, >>> >>> On Mon, 2021-09-06 at 14:40 -0400, Ken Brown via Cygwin wrote: >>>>> No, wait.  I get what you say.  The optimzation settings of the test >>>>> case should have no influence on the code inside the DLL.  That >>>>> doesn't >>>>> make sense for sure.  However, I ran the testcase under GDB, I could >>>>> reproduce the issue, and I could fix it by setting mmap_ext.Reserved >>>>> = 0; >>>>> Go figure! >>>> >>>> I don't get it, but I can confirm that the problem is fixed. >>> >>> That sounds a bit like a voodoo fix, that could quickly regress again. >>> >>> Here is my 2 cents: >>> >>> Currently the mmap_ext structure is setup like this: >>> >>>   215       MEM_EXTENDED_PARAMETER mmap_ext = { >>>   216         .Type = MemExtendedParameterAddressRequirements, >>>   217         .Pointer = (PVOID) &mmap_req >>>   218       }; >>> >>> This means that all other entries in the struct are zero at >>> initialization as described here: >>> https://en.cppreference.com/w/c/language/struct_initialization >>> >>> So if you set "mmap_ext.Reserved = 0" again after that its a double >>> failure. >> >> You're looking at the wrong source code.  The bug didn't occur until the code >> was changed to do the following: >> >>        /* g++ 11.2 workaround: don't use initializer */ >>        MEM_EXTENDED_PARAMETER mmap_ext; >>        mmap_ext.Type = MemExtendedParameterAddressRequirements; >>        mmap_ext.Pointer = (PVOID) &mmap_req; >> >> This left mmap_ext.Reserved uninitialized, which Corinna has now fixed. > > With undocumented structure member initialization an issue, maybe better to > future proof using e.g. > >     MEM_EXTENDED_PARAMETER mmap_ext = { 0 }; // or memset or bzero I don't see what this would accomplish. We're already initializing every member after Corinna's last patch. Ken