From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=6K+s=EY=maxrnd.com=mark@sourceware.org>
Received: from m0.truegem.net (m0.truegem.net [69.55.228.47])
	by sourceware.org (Postfix) with ESMTPS id 8CE973858D1E
	for <cygwin@cygwin.com>; Fri,  8 Sep 2023 05:18:35 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 8CE973858D1E
Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=maxrnd.com
Authentication-Results: sourceware.org; spf=none smtp.mailfrom=maxrnd.com
Received: (from daemon@localhost)
	by m0.truegem.net (8.12.11/8.12.11) id 3885IXA9015028
	for <cygwin@cygwin.com>; Thu, 7 Sep 2023 22:18:33 -0700 (PDT)
	(envelope-from mark@maxrnd.com)
Received: from 50-1-247-226.fiber.dynamic.sonic.net(50.1.247.226), claiming to be "[192.168.4.101]"
 via SMTP by m0.truegem.net, id smtpdOOjCVu; Thu Sep  7 22:18:32 2023
Subject: Re: [pkg cygwin-devel] /usr/include/sys/cpuset.h:52 error: missing
 return type
To: cygwin@cygwin.com
References: <CANNqMjCjZYPKw2XQjWhqmen6cVhYFjROg+oo5DDZpL52ppGngw@mail.gmail.com>
From: Mark Geisert <mark@maxrnd.com>
Message-ID: <3e525bb6-ce45-4e0c-fd65-29f4ae69454e@maxrnd.com>
Date: Thu, 7 Sep 2023 22:18:32 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101
 Firefox/52.0 SeaMonkey/2.49.4
MIME-Version: 1.0
In-Reply-To: <CANNqMjCjZYPKw2XQjWhqmen6cVhYFjROg+oo5DDZpL52ppGngw@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-Spam-Status: No, score=-3.0 required=5.0 tests=BAYES_00,KAM_DMARC_STATUS,KAM_LAZY_DOMAIN_SECURITY,NICE_REPLY_A,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org
List-Id: <cygwin.cygwin.com>

Hi Marco,

Marco Mason via Cygwin wrote:
> I just updated to 3.4.9-1 and compiled some code, and it complained about
> cpuset.h.
> Specifically, "C++ requires a type specifier for all declarations", and
> sure enough, there's no return type on line 52.  So I changed my local copy
> to the following, and it cleared things up:
> 
> #define CPU_ZERO_S(siz, set) __cpuset_zero_s (siz, set)
> static __inline /*MCM*/ void /*MCM*/
> __cpuset_zero_s (__size_t siz, cpu_set_t *set)
> {

Thanks for the report; right you are.

> I looked at a couple mailing list archives and saw that the cpuset.h header
> was worked on recently, but couldn't track it down any closer.  I also
> tried to find a git repository so I could find the commit so I could check
> for similar errors on other headers, but couldn't find the repo for
> cygwin-devel anywhere.

This error was introduced with the most recent update to cpuset.h.  There is a 
public-visible mirror of the Cygwin tree at
     https://github.com/cygwin/cygwin/blob/main/winsup/cygwin
and the problematic file can be found at
     include/sys/cpuset.h
within.

Your bug report and proposed correction are all we need for the issue you ran 
into.  I'll submit a patch shortly.
Thanks again,

..mark