From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5461 invoked by alias); 13 Sep 2006 23:58:41 -0000 Received: (qmail 5453 invoked by uid 22791); 13 Sep 2006 23:58:40 -0000 X-Spam-Check-By: sourceware.org Received: from vms042pub.verizon.net (HELO vms042pub.verizon.net) (206.46.252.42) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 13 Sep 2006 23:58:39 +0000 Received: from [127.0.0.1] ([71.112.120.90]) by vms042.mailsrvcs.net (Sun Java System Messaging Server 6.2-4.02 (built Sep 9 2005)) with ESMTPA id <0J5K00C212KZC6Y1@vms042.mailsrvcs.net> for cygwin@cygwin.com; Wed, 13 Sep 2006 18:58:16 -0500 (CDT) Date: Wed, 13 Sep 2006 23:58:00 -0000 From: David Rothenberger Subject: Re: bash-3.1-7　BUG In-reply-to: <45089854.8010705@scytek.de> To: cygwin@cygwin.com Message-id: <45089B13.7080105@acm.org> MIME-version: 1.0 Content-type: text/plain; charset=ISO-8859-1; format=flowed Content-transfer-encoding: 7bit References: <091320060438.11140.45078B490008FD8600002B8422007610640A050E040D0C079D0A@comcast.net> <20060913052510.GB1256@trixie.casa.cgf.cx> <45089854.8010705@scytek.de> User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.0.5) Gecko/20060719 Thunderbird/1.5.0.5 Mnenhy/0.7.4.666 X-IsSubscribed: yes Reply-To: cygwin@cygwin.com Mailing-List: contact cygwin-help@cygwin.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: cygwin-owner@cygwin.com Mail-Followup-To: cygwin@cygwin.com X-SW-Source: 2006-09/txt/msg00259.txt.bz2 On 9/13/2006 4:46 PM, Volker Quetschke wrote: > mwoehlke wrote: >> Eric Blake wrote: >>> mwoehlke tibco.com> writes: > (snip) >>> ... If the file starts life binary mode (ie. was on a binary >>> mount), skip the check for \r in the scan (under the assumption that >>> on a binary mount, \r is intentional and not a line ending to be >>> collapsed), and use lseeks. >> Sounds good! That will satisfy my request to not silently work on files >> that should be broken. :-) > > I'm seeing the next "make doesn't work anymore with DOS ... feature" coming > up here, only that it is bash this time. (snip) > > ... It is definitely in the eye of the beholder if one calls shell > scripts that worked so far as broken just because they have /r/n line > endings. I strongly agree with this. The users I support would be much happier if bash could continue to work correctly with \r\n in scripts on binary mounts. It sounds like bash will have to scan the first line regardless of the mount type (to check for a binary file), so perhaps the decision to treat \r as intentional or not could be an option? -- David Rothenberger spammer? -> spam@daveroth.dyndns.org GPG/PGP: 0x92D68FD8, DB7C 5146 1AB0 483A 9D27 DFBA FBB9 E328 92D6 8FD8 If Roosevelt were alive, he'd turn over in his grave. -Samuel Goldwyn -- Unsubscribe info: http://cygwin.com/ml/#unsubscribe-simple Problem reports: http://cygwin.com/problems.html Documentation: http://cygwin.com/docs.html FAQ: http://cygwin.com/faq/