initstate/setstate

initstate/setstate

[Yaakov (Cygwin Ports)]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Apparently cygwin has exported initstate and setstate for over ten years
(see winsup/cygwin/ChangeLog-1997), but I can't find a header definition
for it in 1.5.25-11.  POSIX requires these to be declared in <stdlib.h>.

Also, the signatures seem to differ slightly.  winsup/cygwin/random.cc
declares these as:

char *initstate(unsigned long seed, char *arg_state, long n);	
char *setstate(char *state);

but POSIX requires:

char *initstate(unsigned seed, char *state, size_t size);
char *setstate(const char *state);

Could someone please clarify?


Yaakov
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEAREIAAYFAkgnofYACgkQpiWmPGlmQSNQ7wCguXnKxYpxHY4dDNmmmO/GF5Dz
sosAn09l+y7AJS23MpWBk7ZpciSODDnJ
=GlzA
-----END PGP SIGNATURE-----

--
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple
Problem reports:       http://cygwin.com/problems.html
Documentation:         http://cygwin.com/docs.html
FAQ:                   http://cygwin.com/faq/

Re: initstate/setstate

[Corinna Vinschen]

On May 11 20:48, Yaakov (Cygwin Ports) wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA256
>
> Apparently cygwin has exported initstate and setstate for over ten years
> (see winsup/cygwin/ChangeLog-1997), but I can't find a header definition
> for it in 1.5.25-11.  POSIX requires these to be declared in <stdlib.h>.

stdlib.h is a newlib file.  You could just send a patch to the newlib
mailing list.

> Also, the signatures seem to differ slightly.  winsup/cygwin/random.cc
> declares these as:
>
> char *initstate(unsigned long seed, char *arg_state, long n);	
> char *setstate(char *state);
>
> but POSIX requires:
>
> char *initstate(unsigned seed, char *state, size_t size);
> char *setstate(const char *state);
>
> Could someone please clarify?

I'll align the Cygwin functions with POSIX.


Thanks for the report,
Corinna

-- 
Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Project Co-Leader          cygwin AT cygwin DOT com
Red Hat

--
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple
Problem reports:       http://cygwin.com/problems.html
Documentation:         http://cygwin.com/docs.html
FAQ:                   http://cygwin.com/faq/

Re: initstate/setstate

[Corinna Vinschen]

On May 13 09:59, Corinna Vinschen wrote:
> On May 11 20:48, Yaakov (Cygwin Ports) wrote:
> > -----BEGIN PGP SIGNED MESSAGE-----
> > Hash: SHA256
> >
> > Apparently cygwin has exported initstate and setstate for over ten years
> > (see winsup/cygwin/ChangeLog-1997), but I can't find a header definition
> > for it in 1.5.25-11.  POSIX requires these to be declared in <stdlib.h>.
> 
> stdlib.h is a newlib file.  You could just send a patch to the newlib
> mailing list.

I forgot that we have a cygwin-specific cygwin/stdlib.h file.  I added
both functions to that file.


Corinna

-- 
Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Project Co-Leader          cygwin AT cygwin DOT com
Red Hat

--
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple
Problem reports:       http://cygwin.com/problems.html
Documentation:         http://cygwin.com/docs.html
FAQ:                   http://cygwin.com/faq/

Re: initstate/setstate

[Yaakov (Cygwin Ports)]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Corinna Vinschen wrote:
| I forgot that we have a cygwin-specific cygwin/stdlib.h file.  I added
| both functions to that file.

Thanks!  I presume that the patch is only going into 1.7?


Yaakov
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEAREIAAYFAkgqJvoACgkQpiWmPGlmQSNdTgCghBGpcH4YiObQplIcEkRVbNlI
gOUAnRso8YnTahugp1acw9GrgkS9hJgW
=iu5q
-----END PGP SIGNATURE-----

--
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple
Problem reports:       http://cygwin.com/problems.html
Documentation:         http://cygwin.com/docs.html
FAQ:                   http://cygwin.com/faq/

Re: initstate/setstate

[Corinna Vinschen]

On May 13 18:40, Yaakov (Cygwin Ports) wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA256
>
> Corinna Vinschen wrote:
> | I forgot that we have a cygwin-specific cygwin/stdlib.h file.  I added
> | both functions to that file.
>
> Thanks!  I presume that the patch is only going into 1.7?

Yes.


Corinna

-- 
Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Project Co-Leader          cygwin AT cygwin DOT com
Red Hat

--
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple
Problem reports:       http://cygwin.com/problems.html
Documentation:         http://cygwin.com/docs.html
FAQ:                   http://cygwin.com/faq/