Re: GetDriveType on gnulib

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1113 bytes --]

On 03/22/2012 11:15 AM, marco atzeri wrote:
> Hi Eric Blake,
> 
> this portion of your gnulib code
> 
> ----------------------------------------------
> #ifdef __CYGWIN__
> #include <windows.h>
> #define ME_REMOTE me_remote
> /* All cygwin mount points include `:' or start with `//'; so it
>    requires a native Windows call to determine remote disks.  */

Hmm; cygwin has had some improvements since I first wrote this - not the
least of which is that we redid mounting as part of the transition from
1.5.x to 1.7.x; maybe the real solution is to determine if cygwin now
provides indications of a remote mount point that the code is looking
for without having to drop to native function calls, and kill the
<windows.h> include in that case.  It's okay if that still requires the
use of a cygwin-specific function (that is, use of cygwin_internal would
be okay) if that's what it takes.  It may be a few days before I have
time to properly look at fixing this in gnulib, though.

-- 
Eric Blake   eblake@redhat.com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 620 bytes --]