From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 64128 invoked by alias); 30 Aug 2019 09:54:41 -0000 Mailing-List: contact cygwin-help@cygwin.com; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: cygwin-owner@cygwin.com Mail-Followup-To: cygwin@cygwin.com Received: (qmail 64114 invoked by uid 89); 30 Aug 2019 09:54:41 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-4.4 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_2,NORMAL_HTTP_TO_IP,NUMERIC_HTTP_ADDR,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.1 spammy=snip X-HELO: lb1-smtp-cloud7.xs4all.net Received: from lb1-smtp-cloud7.xs4all.net (HELO lb1-smtp-cloud7.xs4all.net) (194.109.24.24) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 30 Aug 2019 09:54:31 +0000 Received: from tmp.YkXjGbR7A5 ([83.162.234.136]) by smtp-cloud7.xs4all.net with ESMTPSA id 3dbtipArwThuu3dbuiamFI; Fri, 30 Aug 2019 11:54:27 +0200 Date: Fri, 30 Aug 2019 12:42:00 -0000 Message-ID: <4a87b7a940fb0cf76aac5f3bc5b1a8b3@smtp-cloud7.xs4all.net> From: Houder Reply-To: cygwin@cygwin.com To: cygwin@cygwin.com Cc: eblake@redhat.com Subject: Re: Odd, is it not? mkdir 'e:\' cannot be undone by rmdir 'e:\' ... References: <20190827152549.GY11632@calimero.vinschen.de> <3E262D05-F393-453A-9E43-B248DDE50812@solidrocksystems.com> <20190828125939.GL11632@calimero.vinschen.de> <421ac447-b249-da21-1ca5-228041cfc884@redhat.com> <20190828141556.GM11632@calimero.vinschen.de> <20190828142220.GN11632@calimero.vinschen.de> In-Reply-to: Content-Type: text/plain; charset=UTF-8; format=fixed User-Agent: mua.awk 0.99 X-SW-Source: 2019-08/txt/msg00419.txt.bz2 On Thu, 29 Aug 2019 17:05:41, Houder wrote: > On Wed, 28 Aug 2019 16:22:20, Corinna Vinschen wrote: [snip] > > One problem here is, what to do about border cases like > > > > $ mkdir a\/\/\/ > > > > In theory slashes and backslashes should both be treated as dir > > separators. Handling a case like this so that all expectations > > are satisfied is next to impossible, I guess. > > How about dropping Eric's code snippet in winsup/cygwin/dir.cc ????? > > Subdirectory 'a' is created. No problem there. Perhaps the patch has > become superfluous/ redundant over time? > > I have tried different "values" for the path-argument to mkdir, and > have not found a problem while the code snippet is being skipped. > > What am I missing? A trailing forward slash in "pathname" is stripped in path_conv::check, (look for: *--tail = '\0' ) after "pathname" has been normalized in normalized_posix_path or normalized_win32_path (or both), before it is fed into conv_to_win32_path. Tests have shown that Eric's code snippet can be deleted w/o harm. Counter arguments? Henri > ----- > Breakpoint 1 at 0x1800548b9: file /usr/src/debug/cygwin-3.1.0-0.2/winsup/cygwin/dir.cc, line 317. > Breakpoint 2 at 0x1800548e3: file /usr/src/debug/cygwin-3.1.0-0.2/winsup/cygwin/dir.cc, line 326. > (gdb) r > Starting program: /usr/bin/mkdir 'a\/\/\/' > [New Thread 1064.0x1a8c] > [New Thread 1064.0x59c] > > Thread 1 "mkdir" hit Breakpoint 1, mkdir (dir=0x800041320 "a\\/\\/\\/", mode=511) > at /usr/src/debug/cygwin-3.1.0-0.2/winsup/cygwin/dir.cc:317 > 317 if (isdirsep (dir[strlen (dir) - 1])) > (gdb) j dir.cc:326 > Continuing at 0x1800548e3. > > Thread 1 "mkdir" hit Breakpoint 2, mkdir (dir=0x800041320 "a\\/\\/\\/", mode=511) > at /usr/src/debug/cygwin-3.1.0-0.2/winsup/cygwin/dir.cc:326 > 326 if (!(fh = build_fh_name (dir, PC_SYM_NOFOLLOW))) > (gdb) c > Continuing. > [Inferior 1 (process 1064) exited normally] > (gdb) quit > > 64-@@ ls -ld a* > drwxr-xr-x+ 1 Henri None 0 Aug 29 16:47 a > > ===== -- Problem reports: http://cygwin.com/problems.html FAQ: http://cygwin.com/faq/ Documentation: http://cygwin.com/docs.html Unsubscribe info: http://cygwin.com/ml/#unsubscribe-simple