From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 87146 invoked by alias); 17 Aug 2017 01:00:02 -0000 Mailing-List: contact cygwin-help@cygwin.com; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: cygwin-owner@cygwin.com Mail-Followup-To: cygwin@cygwin.com Received: (qmail 84178 invoked by uid 89); 17 Aug 2017 00:59:59 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=bruno, Bruno, HTo:U*bug-gnulib X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 17 Aug 2017 00:59:58 +0000 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id EFF956908E; Thu, 17 Aug 2017 00:59:56 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com EFF956908E Authentication-Results: ext-mx04.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx04.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=eblake@redhat.com Received: from [10.10.120.34] (ovpn-120-34.rdu2.redhat.com [10.10.120.34]) by smtp.corp.redhat.com (Postfix) with ESMTP id 32ED16BF72; Thu, 17 Aug 2017 00:59:56 +0000 (UTC) Subject: Re: stdnoreturn: fix for Cygwin To: Bruno Haible , bug-gnulib@gnu.org, The Cygwin Mailing List References: <4260817.MvLg4Vb6y4@omega> From: Eric Blake Openpgp: url=http://people.redhat.com/eblake/eblake.gpg Message-ID: <4e8c3f47-fb4b-eb8d-12d9-6ad40e219279@redhat.com> Date: Thu, 17 Aug 2017 01:00:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <4260817.MvLg4Vb6y4@omega> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="EhUPqkkSTLAGpmSr1xEpQAMD5lIMoGKT8" X-IsSubscribed: yes X-SW-Source: 2017-08/txt/msg00147.txt.bz2 --EhUPqkkSTLAGpmSr1xEpQAMD5lIMoGKT8 Content-Type: multipart/mixed; boundary="7KNKfwQlrC6UICv24IicVRKHU19E3K8K6"; protected-headers="v1" From: Eric Blake To: Bruno Haible , bug-gnulib@gnu.org, The Cygwin Mailing List Message-ID: <4e8c3f47-fb4b-eb8d-12d9-6ad40e219279@redhat.com> Subject: Re: stdnoreturn: fix for Cygwin References: <4260817.MvLg4Vb6y4@omega> In-Reply-To: <4260817.MvLg4Vb6y4@omega> --7KNKfwQlrC6UICv24IicVRKHU19E3K8K6 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable Content-length: 1290 Adding cygwin list... On 08/16/2017 07:01 PM, Bruno Haible wrote: > On Cygwin 1.7.30, I'm seeing this testdir build failure, when compiling > test-stdnoreturn.c: >=20 > /usr/include/stdlib.h:66:28: error: expected =E2=80=98,=E2=80=99 or =E2= =80=98;=E2=80=99 before =E2=80=98)=E2=80=99 token > _VOID _EXFUN(abort,(_VOID) _ATTRIBUTE ((noreturn))); > + > + Similarly, on Cygwin, standard include files contain declarations like > + void __cdecl abort (void) __attribute__ ((noreturn)); > + "#define noreturn _Noreturn" would cause this declaration to be rewri= tten > + to the invalid > + void __cdecl abort (void) __attribute__ ((__attribute__ ((__noretur= n__)))); Hmm. It's evil for any system .h file to ever use __attribute__((barename)), since barename is in the user's namespace and can therefore be defined to anything else, possibly breaking the header (as you just proved). Hopefully, the problem goes away if cygwin patches its headers to use __attribute__((__noreturn__)), so that gnulib can then define noreturn at will. I'll look into patching Cygwin to fix all barename attributes I can find that should be __barename__ instead. --=20 Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org --7KNKfwQlrC6UICv24IicVRKHU19E3K8K6-- --EhUPqkkSTLAGpmSr1xEpQAMD5lIMoGKT8 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" Content-length: 619 -----BEGIN PGP SIGNATURE----- Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEzBAEBCAAdFiEEccLMIrHEYCkn0vOqp6FrSiUnQ2oFAlmU6osACgkQp6FrSiUn Q2qKJwf/XMQLWhRYGsUETLypQfeVO/8stWMalB4UZVx+SgJdei0mBZpFpb21uV+j x3S6zX+xBFZSCCIlgmugk7MOc4tLkC5S2zKzllyzSkhwm/lYxZij2ph2eVRSWWgx GkbCZjM8ebkRxZYtDI+9tpg27x0uPyEG5vN3aiKrVnYDc8yYNutKaLZW14j7v8dm 9ZszSN5RcwgW1t0TlHQRi64s5tCXEHRKWtxKhaio+7uDZ+YOd1mKs6H5OFYLFRcm M4piJVSkLdjuRZIDMTM9vgvyZEBbuc5zSPN4U/rzvjMZ7WO1E6WjT8ASlcSGDYsS zZnLqaZ6r2R+M2d2fxIeOdjdAQKX7g== =K5rp -----END PGP SIGNATURE----- --EhUPqkkSTLAGpmSr1xEpQAMD5lIMoGKT8--