From: David Stacey <drstacey@tiscali.co.uk>
To: cygwin@cygwin.com
Subject: [PATCH] 'rebase' uninitialised variable (was: Cygwin64: Rebase problems)
Date: Sat, 30 Nov 2013 06:32:00 -0000 [thread overview]
Message-ID: <5299867E.2080301@tiscali.co.uk> (raw)
In-Reply-To: <5274DCA9.7020408@tiscali.co.uk>
[-- Attachment #1: Type: text/plain, Size: 794 bytes --]
On 02/11/2013 11:06, David Stacey wrote:
> I'm trying to reinstall 64-bit Cygwin, using a snapshot taken on
> 2013-10-24. The post-install step goes into an infinite loop whilst
> running 'texlive-collection-basic.sh': perl is attempting to load some
> modules (IO.dll, MD5.dll, Fcnt.dll, Cwd.dll), which fail with rebase
> errors. The script waits five seconds before trying (and failing)
> again; this repeats ad infinitum.
I am pleased to report that I have tracked down the cause of my rebase
woes to an uninitialised variable in the 'rebase' package. A simple
patch (attached) fixes the problem.
Jason Tishler: As rebase maintainer, if you agree with my diagnosis then
please could you make new versions of 'rebase' containing the fix for
both architectures. Thank you.
Dave.
[-- Attachment #2: rebase-4.4.0.1-1.src.patch --]
[-- Type: text/plain, Size: 593 bytes --]
--- origsrc/rebase/rebase.c 2013-03-19 17:33:54.000000000 +0000
+++ src/rebase/rebase.c 2013-11-29 18:32:08.760089000 +0000
@@ -861,6 +861,7 @@ collect_image_info (const char *pathname
img_info_list[img_info_size].slot_size
= roundup2 (img_info_list[img_info_size].size, ALLOCATION_SLOT);
img_info_list[img_info_size].flag.needs_rebasing = 1;
+ img_info_list[img_info_size].flag.cannot_rebase = 0;
/* This back and forth from POSIX to Win32 is a way to get a full path
more thoroughly. For instance, the difference between /bin and
/usr/bin will be eliminated. */
[-- Attachment #3: Type: text/plain, Size: 218 bytes --]
--
Problem reports: http://cygwin.com/problems.html
FAQ: http://cygwin.com/faq/
Documentation: http://cygwin.com/docs.html
Unsubscribe info: http://cygwin.com/ml/#unsubscribe-simple
next prev parent reply other threads:[~2013-11-30 6:32 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-02 11:12 Cygwin64: Rebase problems David Stacey
2013-11-02 20:03 ` David Stacey
2013-11-23 19:35 ` David Stacey
2013-11-25 19:28 ` Larry Hall (Cygwin)
2013-11-30 6:32 ` David Stacey [this message]
2013-12-01 12:23 ` [PATCH] 'rebase' uninitialised variable (was: Cygwin64: Rebase problems) Corinna Vinschen
2013-12-03 2:20 ` Jason Tishler
2013-12-03 10:22 ` Corinna Vinschen
2013-12-03 15:43 ` GOLD STAR (was Re: [PATCH] 'rebase' uninitialised variable) Christopher Faylor
2013-12-03 16:05 ` Corinna Vinschen
2013-12-03 16:10 ` Christopher Faylor
2013-12-03 16:32 ` Corinna Vinschen
2013-12-06 15:41 ` Andrew Schulman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5299867E.2080301@tiscali.co.uk \
--to=drstacey@tiscali.co.uk \
--cc=cygwin@cygwin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).