public inbox for cygwin@cygwin.com
 help / color / mirror / Atom feed
From: David Rothenberger <daveroth@acm.org>
To: cygwin@cygwin.com
Subject: Re: Severe performance degradation of writev
Date: Wed, 09 Jul 2014 16:46:00 -0000	[thread overview]
Message-ID: <53BD7161.5030209@acm.org> (raw)
In-Reply-To: <20140707134137.GK1803@calimero.vinschen.de>

Corinna Vinschen wrote:
> On Jul  7 12:10, Corinna Vinschen wrote:
>> On Jul  7 07:28, jojelino wrote:
>>> 2008-07-27  Corinna Vinschen  <corinna@vinschen.de>
>>> 
>>> * fhandler_socket.cc (fhandler_socket::send_internal): Send
>>> never more then 64K bytes at once.  For blocking sockets, loop
>>> until entire data has been sent or an error occurs. 
>>> (fhandler_socket::sendto): Drop code which sends on 64K bytes. 
>>> (fhandler_socket::sendmsg): Ditto.
>>> 
>>> This commit added workaround for KB823764. but it has brought
>>> another performance issue when writev sends <64k of data.
>> 
>> That's why the code contains that FIXME comment.  If you have a
>> good idea for simple code to split a message into the least
>> number of pieces to minimize the number of WsaSendTo calls...
> 
> I took a stab at the code and I think the new version improves
> writing multiple small buffers a lot.  In my testing it still works
> in other scenarios, too, but I would be very grateful if somebody
> could have a critical look into my code changes as posted in 
> https://cygwin.com/ml/cygwin-cvs/2014-q3/msg00003.html
> 
> I uploaded a new developer snapshot to
> http://cygwin.com/snapshots/ Please give it a thorough try.

FWIW, this snapshot fixed a recent performance degradation for me when
doing ssh/rsync transfers within my local network at work. These
transfers had run at about 25 MB/s but recently degraded to about 500
kB/s. The snapshot restored the original performance.


-- 
David Rothenberger  ----  daveroth@acm.org

Issawi's Laws of Progress:
        The Course of Progress:
                Most things get steadily worse.
        The Path of Progress:
                A shortcut is the longest distance between two points.

--
Problem reports:       http://cygwin.com/problems.html
FAQ:                   http://cygwin.com/faq/
Documentation:         http://cygwin.com/docs.html
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple

  reply	other threads:[~2014-07-09 16:46 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-06 22:28 jojelino
2014-07-06 22:35 ` jojelino
2014-07-07 10:10 ` Corinna Vinschen
2014-07-07 13:41   ` Corinna Vinschen
2014-07-09 16:46     ` David Rothenberger [this message]
2014-07-09 17:03       ` Corinna Vinschen
2014-07-09 17:19         ` David Rothenberger
2014-07-11 10:35           ` Corinna Vinschen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53BD7161.5030209@acm.org \
    --to=daveroth@acm.org \
    --cc=cygwin@cygwin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).