From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3485 invoked by alias); 31 Jul 2014 04:22:12 -0000 Mailing-List: contact cygwin-help@cygwin.com; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: cygwin-owner@cygwin.com Mail-Followup-To: cygwin@cygwin.com Received: (qmail 3445 invoked by uid 89); 31 Jul 2014 04:22:10 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 31 Jul 2014 04:22:08 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s6V4M7mv022501 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 31 Jul 2014 00:22:07 -0400 Received: from [10.3.113.65] (ovpn-113-65.phx2.redhat.com [10.3.113.65]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s6V4M6Qn013835; Thu, 31 Jul 2014 00:22:06 -0400 Message-ID: <53D9C46E.8060109@redhat.com> Date: Thu, 31 Jul 2014 04:22:00 -0000 From: Eric Blake User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.6.0 MIME-Version: 1.0 To: bug-gnulib@gnu.org, The Cygwin Mailing List Subject: Re: [PATCH] openat-die: use _Noreturn markup References: <1406755527-26369-1-git-send-email-eblake@redhat.com> <53D9BDAD.3000504@redhat.com> In-Reply-To: <53D9BDAD.3000504@redhat.com> OpenPGP: url=http://people.redhat.com/eblake/eblake.gpg Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="W5Q5aDfTWxJB3s9UIHeLncAwLGRT9SJHi" X-IsSubscribed: yes X-SW-Source: 2014-07/txt/msg00371.txt.bz2 --W5Q5aDfTWxJB3s9UIHeLncAwLGRT9SJHi Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Content-length: 1359 On 07/30/2014 09:53 PM, Eric Blake wrote: >=20 > Meanwhile, './gnulib-tool --test stdnoreturn' is failing on cygwin, so > I'm trying to track down why. >=20 > In file included from /usr/include/stdlib.h:11:0, > from ../../gltests/test-stdnoreturn.c:23: > ./../config.h:33:21: error: expected '(' before '__attribute__' > # define _Noreturn __attribute__ ((__noreturn__)) > ^ >=20 Oh, I think I see the problem. Pasting more of the error message: /usr/include/stdlib.h:66:28: error: expected ',' or ';' before ')' token _VOID _EXFUN(abort,(_VOID) _ATTRIBUTE ((noreturn))); ^ Looks like the cygwin headers are broken for misusing 'noreturn' instead of __noreturn__ inside __attribute__; something that is easier to patch in cygwin than work around in gnulib. For more proof: $ printf '#include \n#include \n' \ | gcc -xc -E - | grep abort void __attribute__((__cdecl__)) abort (void) __attribute__ ((_Noreturn)); $ printf '#include \n#include \n' \ | gcc -xc -E - -D_Noreturn=3D'__attribute__((__noreturn__))' \ | grep abort void __attribute__((__cdecl__)) abort (void) __attribute__ ((__attribute__((__noreturn__)))); --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --W5Q5aDfTWxJB3s9UIHeLncAwLGRT9SJHi Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" Content-length: 539 -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg iQEcBAEBCAAGBQJT2cRuAAoJEKeha0olJ0Nq8ZgH+wSxnXNc6J5tEqOA28mzNE+a AdekhekjkBVZemKK9Hz0dlf05qwdYbnj826HNnOKI2K//64ki4I18h8th6nWgATn 8sxR0MMWYS6Ax8bVfTejNtcjYfQ986Oo3UJ68ALaPXJZZ4VNvYuYMUNv00RN3N2z vshX72reaoBwBFRs5H0As+6N8PNi5b2OMBN99Lr7hCagrwWB6sTEv6NdD+dtbre2 Zyly0rqNlkT5SzOpy2UekysWvadPuGVpZ2I8RT3hBsnflXFnlyZvymLrNPnBAIF7 oV2N8x9eXrN0PChZt0++Uiq9px17pHf7a7Y1xQ39h563Ewdgc/0oqnKlt7O+eBA= =qsyB -----END PGP SIGNATURE----- --W5Q5aDfTWxJB3s9UIHeLncAwLGRT9SJHi--