From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13204 invoked by alias); 26 Aug 2015 23:28:20 -0000 Mailing-List: contact cygwin-help@cygwin.com; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: cygwin-owner@cygwin.com Mail-Followup-To: cygwin@cygwin.com Received: (qmail 13190 invoked by uid 89); 26 Aug 2015 23:28:19 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 26 Aug 2015 23:28:18 +0000 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (Postfix) with ESMTPS id CC2D38E3D5 for ; Wed, 26 Aug 2015 23:28:17 +0000 (UTC) Received: from [10.3.113.77] (ovpn-113-77.phx2.redhat.com [10.3.113.77]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t7QNSHiv004661 for ; Wed, 26 Aug 2015 19:28:17 -0400 Subject: Re: Updated [test]: coreutils-8.24-2 To: cygwin@cygwin.com References: <001c01d0e04c$d8ebc210$8ac34630$@bonhard.uklinux.net> <000001d0e051$965f38a0$c31da9e0$@bonhard.uklinux.net> From: Eric Blake Openpgp: url=http://people.redhat.com/eblake/eblake.gpg X-Enigmail-Draft-Status: N1110 Message-ID: <55DE4B8B.6000401@redhat.com> Date: Wed, 26 Aug 2015 23:50:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 MIME-Version: 1.0 In-Reply-To: <000001d0e051$965f38a0$c31da9e0$@bonhard.uklinux.net> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="f9KuPXTDNf2BFP5RcBmQEL1CBTegTwcmM" X-IsSubscribed: yes X-SW-Source: 2015-08/txt/msg00476.txt.bz2 --f9KuPXTDNf2BFP5RcBmQEL1CBTegTwcmM Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Content-length: 906 On 08/26/2015 04:50 PM, Fergus wrote: >> .. No, you're the first to report it (so 8.24-2 has the same issue), but >> now that I know about it, it will get fixed soon. Spot the bugs: int cygwin_spelling (char const *path) { ... int len; ... if (! path || ! *path || len > PATH_MAX) /* PATH will cause EINVAL or ENAMETOOLONG, treat it as non-existing. */ return -1; len =3D strlen (path); D'oh. But this same flub of mine was also present in at least 8.23-4; so it was the upstream churn in src/cp.c that caused the stack to be different to the point that it now matters. [For those keeping score, I should use size_t and not int to store strlen() values, since it matters on 64-bit when encountering the unlikely >2G string; and it helps to never branch on uninitialized memory] --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --f9KuPXTDNf2BFP5RcBmQEL1CBTegTwcmM Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" Content-length: 604 -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJV3kuMAAoJEKeha0olJ0NqPJwH/0dZVzPzdzA4/RVax/xbYAqB 7otFu34iCLzAy5mGb+0YzS4r/rVHRt5B6K/m4X+QGVwjMUO0WUCZGA5YNcpC1Z12 DV2L45Q/H9bFubCiW/BpGcBaaSOx9+hbqO0JgqU22OzDswP7h24yOhaGNx3Gv3Z2 r+nbzxjzRDEzpCDVv3MexbV8yEBhR+eeOVhJuCjUZxlXh+T2tUSV5PHj99YVCPl4 jy0uE+J21BVP2re8mNFamPGkE+lvKMyDO1cROcXMKsEoyvLKBloFZ/S9BItwBRk1 xTCM8nRsb9N/u4w0J2y6NF7OJHm9AYQcrmjha5+kHtzrNlwg4L0050g4pkdcAEw= =66BH -----END PGP SIGNATURE----- --f9KuPXTDNf2BFP5RcBmQEL1CBTegTwcmM--