From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 89393 invoked by alias); 10 Sep 2015 17:36:14 -0000 Mailing-List: contact cygwin-help@cygwin.com; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: cygwin-owner@cygwin.com Mail-Followup-To: cygwin@cygwin.com Received: (qmail 89380 invoked by uid 89); 10 Sep 2015 17:36:13 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.0 required=5.0 tests=AWL,BAYES_50,KAM_LAZY_DOMAIN_SECURITY,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=no version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 10 Sep 2015 17:36:12 +0000 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (Postfix) with ESMTPS id 56419A86 for ; Thu, 10 Sep 2015 17:36:11 +0000 (UTC) Received: from [10.3.113.15] ([10.3.113.15]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t8AHaACt003297 for ; Thu, 10 Sep 2015 13:36:11 -0400 Subject: Re: Group Permissions on root folders problem (Windows 10 TP build 10061) To: cygwin@cygwin.com References: <20150616155843.GE31537@calimero.vinschen.de> <20150905155916.8403bea8d4f631c1f7a314e3@nifty.ne.jp> <20150906114444.GA27066@calimero.vinschen.de> <20150910200439.bf06449af4f1e6efcb76676e@nifty.ne.jp> <20150910172348.GB26699@calimero.vinschen.de> <55F1BD86.1090001@redhat.com> <20150910173128.GD26699@calimero.vinschen.de> From: Eric Blake Openpgp: url=http://people.redhat.com/eblake/eblake.gpg Message-ID: <55F1BF8A.2050907@redhat.com> Date: Thu, 10 Sep 2015 17:36:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: <20150910173128.GD26699@calimero.vinschen.de> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="fGXDgxG1Q8GQNkHMX84FK1KSvLIPim65G" X-IsSubscribed: yes X-SW-Source: 2015-09/txt/msg00154.txt.bz2 --fGXDgxG1Q8GQNkHMX84FK1KSvLIPim65G Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Content-length: 1269 On 09/10/2015 11:31 AM, Corinna Vinschen wrote: >>>> - if [ "\\\\${COMPUTERNAME,,*}" !=3D "${LOGONSERVER,,*}" ] >>>> + if [ "\\\\${COMPUTERNAME,,*}" !=3D "${LOGONSERVER,,*}" \ >>>> + -a "${LOGONSERVER}" !=3D "\\\\MicrosoftAccount" ] >>>> then >>>> # Lowercase of USERDOMAIN >>>> csih_PRIVILEGED_USERNAME=3D"${COMPUTERNAME,,*}+${username}" >>> >>> Thanks a lot, much appreciated. Patch applied. >> >> [ ... -a ... ] is not portable; there are some inherently ambiguous >> situations that it cannot handle. POSIX recommends that you spell it [ >> ... ] && [ ... ] instead. >=20 > Does this matter in this very situation? This is always running under > bash, btw. Bash's a requirement for the csih helper script. Because you are at least using bash, you will get consistent behavior; and because both ... are 3-argument tests, it is unlikely that one of the tests can be confused with other operators like '(' or ')'. So, I guess it's okay to leave it alone here. But even with bash, the use of -a can cause problems when testing user-supplied variables that might happen to expand to text that looks like potential operators. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --fGXDgxG1Q8GQNkHMX84FK1KSvLIPim65G Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" Content-length: 604 -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJV8b+KAAoJEKeha0olJ0NqFhIH/R3D3++p8kTs5FrenNToUreF dYzcjzrj1uxY3NcqZaFm9s7Msyc4/NVEwIWzKZ+p2p8nKh7ynB4+SDnXcHJekNNB 28xAM8F8KzCuV92tBX7COapy7UKRUxX7hi7GAt5TG4CtY7r3mXOquUF7WvLnTwOr eBk3eQQ2Uh/wzbIelBwt6qkY+iygnJUbGfiLWUcKKUrfnEC5D7hDHBVP4chOeqJC hgI5hsN1hcFJsnkEK2vAOZ+5BXYoMOI8ZW+uFCDkVeu+muwKNwmB9PnbJFoTWNcS k0jAOzWoQO+8+fQRLHwPIc0Y8Dca66Shx0gsNKJdko1ZXtrZTG/BRBio5HnatOg= =T8gK -----END PGP SIGNATURE----- --fGXDgxG1Q8GQNkHMX84FK1KSvLIPim65G--