From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 73909 invoked by alias); 17 Dec 2015 21:41:07 -0000 Mailing-List: contact cygwin-help@cygwin.com; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: cygwin-owner@cygwin.com Mail-Followup-To: cygwin@cygwin.com Received: (qmail 73799 invoked by uid 89); 17 Dec 2015 21:41:06 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy=H*MI:sk:5673262, H*f:sk:5673262, Hx-languages-length:1623, H*i:sk:5673262 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 17 Dec 2015 21:41:05 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (Postfix) with ESMTPS id 67C12AA0B0 for ; Thu, 17 Dec 2015 21:41:04 +0000 (UTC) Received: from [10.3.113.99] (ovpn-113-99.phx2.redhat.com [10.3.113.99]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id tBHLf3mL031830 for ; Thu, 17 Dec 2015 16:41:04 -0500 Subject: Re: [ANNOUNCEMENT] TEST RELEASE: Cygwin 2.4.0-0.11 To: cygwin@cygwin.com References: <20151216164848.GM3507@calimero.vinschen.de> <5671EFF8.6030804@cornell.edu> <20151217093634.GP3507@calimero.vinschen.de> <56730350.1080002@cornell.edu> <20151217201709.GA28305@calimero.vinschen.de> <56731D8C.9020001@cornell.edu> <20151217210107.GC3507@calimero.vinschen.de> <56732621.6040101@redhat.com> From: Eric Blake Openpgp: url=http://people.redhat.com/eblake/eblake.gpg Message-ID: <56732BEB.7020507@redhat.com> Date: Thu, 17 Dec 2015 21:41:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <56732621.6040101@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="f5VxblCHDRTwkPl4WACMGHmIWabWF3pnJ" X-IsSubscribed: yes X-SW-Source: 2015-12/txt/msg00198.txt.bz2 --f5VxblCHDRTwkPl4WACMGHmIWabWF3pnJ Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Content-length: 1604 On 12/17/2015 02:16 PM, Eric Blake wrote: > On 12/17/2015 02:01 PM, Corinna Vinschen wrote: >=20 >>> Here's what happens: >>> >>> One of the Gnulib modules includes sys/types.h, which includes sys/sele= ct.h >>> because of the recent changes. This brings in Gnulib's sys/select.h, w= hich >>> includes signal.h. We then get the errors I posted because we haven't = yet >>> finished including sys/types.h. >=20 > Gnulib has been taught to work around early inclusion problems before; > sounds like this will be another case where gnulib has to make sure the > system header is complete before its own replacements kick in. >=20 >>> >>> All the build errors disappear if I remove '#include ' fr= om >>> sys/types.h. You said above that the macros related to select don't re= ally >>> belong in sys/types.h. So why does the latter include sys/select.h? Another data point: POSIX does NOT allow to pollute the namespace with symbols from . True, the use of __BSD_VISIBLE says that POSIX is not in play, but I'm suspecting that very few programs are written that use sys/select.h functionality but were relying on the BSD headers to indirectly include it via sys/types.h, since such programs would fail to compile on other systems where the indirect include is not present (more likely, any clients of sys/select.h are directly including it). So at this point, I'm leaning towards fixing the cygwin header to not include sys/select.h from sys/types.h. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --f5VxblCHDRTwkPl4WACMGHmIWabWF3pnJ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" Content-length: 604 -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWcyvrAAoJEKeha0olJ0Nq1xoH/2zwPkFUDcY7Yd2H/O7V1sy4 8TZSAEYJzwi3MT3FhL6J+MlH94pjKHnxnlvLytfsBecBJ8zTYX3vh1EmLQJbTYMf rco8/k8TBCXqU7rZyazNSxACom3vw3yQ4nO+Q2s3Vm8jaQklmBiIfQCR/3jQg/S1 VWzsR51Uv3uk/mhAQusjxeaUhNhKL/hP99lRMym9mBzDdZnoIPGm9ds+lCPa+Ww8 tW8uPVF94MDBMiMEB0OWnG0w2eQOW4ibN3hxU0UyMg1f2mGL9cWfsfkduJW3rHTZ nqTu8VaTtGWog05mGmxZyrly6PNPo70FMOkOhEFCA1weBDkg7UNmEazFPkLd1wQ= =KjS6 -----END PGP SIGNATURE----- --f5VxblCHDRTwkPl4WACMGHmIWabWF3pnJ--