From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 99294 invoked by alias); 9 Feb 2016 08:57:02 -0000 Mailing-List: contact cygwin-help@cygwin.com; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: cygwin-owner@cygwin.com Mail-Followup-To: cygwin@cygwin.com Received: (qmail 99283 invoked by uid 89); 9 Feb 2016 08:57:00 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.2 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 spammy=H*i:sk:CAFo71_, hacking, H*MI:sk:RVcyoDw, H*i:i57w_eAgeq X-HELO: mail.lysator.liu.se Received: from mail.lysator.liu.se (HELO mail.lysator.liu.se) (130.236.254.3) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Tue, 09 Feb 2016 08:56:59 +0000 Received: from mail.lysator.liu.se (localhost [127.0.0.1]) by mail.lysator.liu.se (Postfix) with ESMTP id 306D440120 for ; Tue, 9 Feb 2016 09:56:55 +0100 (CET) Received: from [192.168.0.96] (217-210-101-82-no95.business.telia.com [217.210.101.82]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.lysator.liu.se (Postfix) with ESMTPSA id E07074001C for ; Tue, 9 Feb 2016 09:56:54 +0100 (CET) Message-ID: <56B9A9D8.1030900@lysator.liu.se> Date: Tue, 09 Feb 2016 08:57:00 -0000 From: Peter Rosin User-Agent: Mozilla/5.0 (Windows NT 6.3; Win64; x64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 MIME-Version: 1.0 To: cygwin@cygwin.com Subject: Re: Problem with new acl code and cdrtools References: <20160208131835.GC12975@calimero.vinschen.de> <56B8C25F.7050206@lysator.liu.se> In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-SW-Source: 2016-02/txt/msg00106.txt.bz2 On 2016-02-09 08:56, Ismail Donmez wrote: > Hi, > > On Tue, Feb 9, 2016 at 6:14 AM, Warren Young wrote: >> On Feb 8, 2016, at 9:59 AM, Ismail Donmez wrote: >>> >>> On Mon, Feb 8, 2016 at 6:29 PM, Peter Rosin wrote: >>>> On 2016-02-08 14:31, Ismail Donmez wrote: >>>>> This is a generic code so I don't want to add a cygwin specific >>>>> dependency there. Is there a preprocessor definition for cygwin >>>>> version? I could use that to disable HAVE_SUN_ACL for cygwin 2.5+ >>>> >>>> Pardon me for butting in, but isn't adding a Cygwin version check >>>> about as non-generic as it gets? >>>> >>>> Wouldn't something like this work: >>>> >>>> .../configure ac_cv_func_aclfromtext=no >>> >>> Thats a hack :) >> >> I don’t know if that smiley means you’re joking or if you’re just trying to soften a negative judgement, but Peter’s proposal is as far from a hack as it gets. > > What Peter suggests is telling autoconf to assume aclfromtext() does > not exist on the system which is a hack and I already have a hack I > could use. > >> He is proposing that you write an autoconf test that determines if the platform has this new ACL behavior. Then in your C code: >> >> #include >> #if HAVE_FUNC_ACLFROMTEXT >> # include >> #endif > > I could check for __cygwin__ instead of that which would do the same thing. > > Anyhow the discussion diverged a lot, and for now I'll be using my > simple hack of disabling HAVE_SUN_ACL manually. My take on the situation was that you could disable SUN ACLs by telling configure that cdrtools should not use aclfromtext(), and that the code that backs this was already in place. I.e. that you could get a working build recipe w/o any hacking/patching of cdrtools at all. I might be misunderstanding something though, but if it works and if it is considered more of an hack than introducing a cygwin version check inside the cdrtools package, then that's not my headache. Just trying to help... Cheers, Peter -- Problem reports: http://cygwin.com/problems.html FAQ: http://cygwin.com/faq/ Documentation: http://cygwin.com/docs.html Unsubscribe info: http://cygwin.com/ml/#unsubscribe-simple